Skip to contentSkip to conversation

ACPI/IORT: Remove linker section for IORT entries again

PATCH In review Jia He 3 participants 5 messages Feb 7, 2018 – Feb 8, 2018 Generic include/asm header files

lore
Share & tools
lore

Jia He

author
#0 lore raw

PATCH 1/1 ACPI/IORT: Remove linker section for IORT entries again

In commit 316ca8804ea8 ("ACPI/IORT: Remove linker section for IORT entries probing"), iort entries was removed in vmlinux.lds.h. But in commit 2fcc112af37f ("clocksource/drivers: Rename clksrc table to timer"), this line was back incorrectly.

It does no harm except for adding some useless symbols, so fix it.

---
 include/asm-generic/vmlinux.lds.h | 1 -
 1 file changed, 1 deletion(-)
include/asm-generic/vmlinux.lds.h +0 -1
index 1ab0e52..58b1dab 100644
@@ -589,7 +589,6 @@
 	IRQCHIP_OF_MATCH_TABLE()					\
 	ACPI_PROBE_TABLE(irqchip)					\
 	ACPI_PROBE_TABLE(timer)						\
-	ACPI_PROBE_TABLE(iort)						\
 	EARLYCON_TABLE()
 
 #define INIT_TEXT							\
Signature · 1 line
2.7.4
Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · Jia He

In commit 316ca8804ea8 ("ACPI/IORT: Remove linker section for IORT entries probing"), iort entries was removed in vmlinux.lds.h. But in commit 2fcc112af37f ("clocksource/drivers: Rename clksrc table to timer"), this line was back incorrectly.

It does no harm except for adding some useless symbols, so fix it.

---
 include/asm-generic/vmlinux.lds.h | 1 -
 1 file changed, 1 deletion(-)

Who is picking this up ?

Quoted 15 lines
include/asm-generic/vmlinux.lds.h +0 -1
index 1ab0e52..58b1dab 100644
@@ -589,7 +589,6 @@
 	IRQCHIP_OF_MATCH_TABLE()					\
 	ACPI_PROBE_TABLE(irqchip)					\
 	ACPI_PROBE_TABLE(timer)						\
-	ACPI_PROBE_TABLE(iort)						\
 	EARLYCON_TABLE()
 
 #define INIT_TEXT							\
Signature · 1 line
2.7.4
author
#2 lore raw

On 2/7/2018 7:41 PM, Lorenzo Pieralisi Wrote:

Quoted 9 lines · Jia He
Quoted 8 lines

In commit 316ca8804ea8 ("ACPI/IORT: Remove linker section for IORT entries probing"), iort entries was removed in vmlinux.lds.h. But in commit 2fcc112af37f ("clocksource/drivers: Rename clksrc table to timer"), this line was back incorrectly.

It does no harm except for adding some useless symbols, so fix it.

forget to add another Signed-off-by line(because of my company's opensource rules)

Quoted 6 lines
Quoted 3 lines
---
  include/asm-generic/vmlinux.lds.h | 1 -
  1 file changed, 1 deletion(-)

Who is picking this up ?

Sorry, do you mean who is picking up acpi/iort subsystem?
I can't answer this question. I find this minor bug while doing the code review.

Cheers,
Jia

Quoted 15 lines
Quoted 15 lines
include/asm-generic/vmlinux.lds.h +0 -1
index 1ab0e52..58b1dab 100644
@@ -589,7 +589,6 @@
  	IRQCHIP_OF_MATCH_TABLE()					\
  	ACPI_PROBE_TABLE(irqchip)					\
  	ACPI_PROBE_TABLE(timer)						\
-	ACPI_PROBE_TABLE(iort)						\
  	EARLYCON_TABLE()
 
  #define INIT_TEXT							\
Signature · 1 line
2.7.4
#3 lore raw
Quoted 17 lines · Jia He

On 2/7/2018 7:41 PM, Lorenzo Pieralisi Wrote:

Quoted 9 lines · Jia He
Quoted 8 lines

In commit 316ca8804ea8 ("ACPI/IORT: Remove linker section for IORT entries probing"), iort entries was removed in vmlinux.lds.h. But in commit 2fcc112af37f ("clocksource/drivers: Rename clksrc table to timer"), this line was back incorrectly.

It does no harm except for adding some useless symbols, so fix it.

forget to add another Signed-off-by line(because of my company's opensource rules)

Quoted 7 lines
Quoted 6 lines
Quoted 3 lines
---
 include/asm-generic/vmlinux.lds.h | 1 -
 1 file changed, 1 deletion(-)

Who is picking this up ?

Sorry, do you mean who is picking up acpi/iort subsystem?

No, I meant who (as-in me or Daniel) will merge this patch.

I will take it.

Lorenzo

Quoted 19 lines

I can't answer this question. I find this minor bug while doing the code review.

Cheers,
Jia

Quoted 14 lines
Quoted 14 lines
include/asm-generic/vmlinux.lds.h +0 -1
index 1ab0e52..58b1dab 100644
@@ -589,7 +589,6 @@
 	IRQCHIP_OF_MATCH_TABLE()					\
 	ACPI_PROBE_TABLE(irqchip)					\
 	ACPI_PROBE_TABLE(timer)						\
-	ACPI_PROBE_TABLE(iort)						\
 	EARLYCON_TABLE()
 #define INIT_TEXT							\
Signature · 1 line
2.7.4
Acked-by on v1 1/1
#4 lore raw
In reply to Jia He
Quoted 8 lines · Jia He

In commit 316ca8804ea8 ("ACPI/IORT: Remove linker section for IORT entries probing"), iort entries was removed in vmlinux.lds.h. But in commit 2fcc112af37f ("clocksource/drivers: Rename clksrc table to timer"), this line was back incorrectly.

It does no harm except for adding some useless symbols, so fix it.

Quoted 16 lines
---
 include/asm-generic/vmlinux.lds.h | 1 -
 1 file changed, 1 deletion(-)
include/asm-generic/vmlinux.lds.h +0 -1
index 1ab0e52..58b1dab 100644
@@ -589,7 +589,6 @@
 	IRQCHIP_OF_MATCH_TABLE()					\
 	ACPI_PROBE_TABLE(irqchip)					\
 	ACPI_PROBE_TABLE(timer)						\
-	ACPI_PROBE_TABLE(iort)						\
 	EARLYCON_TABLE()
 
 #define INIT_TEXT							\
Signature · 5 lines
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog