Skip to contentSkip to conversation

ieee80211: Increase the PMK maximum length to 64 bytes

PATCH In review Srinivas Dasari 4 participants 5 messages Feb 7, 2018 – Feb 10, 2018 802.11 (including cfg80211/NL80211)

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ieee80211: Increase the PMK maximum length to 64 bytes

This is needed to cover the case of DPP with the NIST P-521 and brainpoolP512r1 curves which derive a PMK that is longer than the previously used limit.

---
 include/linux/ieee80211.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

v2:
-Modified the commit text and resending it to right recipients

include/linux/ieee80211.h +1 -1
index ee6657a..e4cba33 100644
@@ -2111,7 +2111,7 @@ enum ieee80211_key_len {
 #define FILS_ERP_MAX_REALM_LEN		253
 #define FILS_ERP_MAX_RRK_LEN		64
 
-#define PMK_MAX_LEN			48
+#define PMK_MAX_LEN			64
 
 /* Public action codes (IEEE Std 802.11-2016, 9.6.8.1, Table 9-307) */
 enum ieee80211_pub_actioncode {
Signature · 1 line
1.9.1
#1 lore raw
Quoted 3 lines · Srinivas Dasari

This is needed to cover the case of DPP with the NIST P-521 and brainpoolP512r1 curves which derive a PMK that is longer than the previously used limit.

So how are driver supposed to deal with this longer PMK. Maybe if you could elaborate on what DPP stands for in this context it would become more clear. Can we stick with PMK_MAX_LEN or does it need to be more fine-grained per use-case? If existing drivers only support 48 bytes PMK and trust nl80211 code to check that limit it may screw them up. Not? If this is preparation for subsequent patches I would put it all in one patch series.

Regards,
Arend

Quoted 4 lines
---
  include/linux/ieee80211.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
maintainer
#2 lore raw
Quoted 8 lines · Arend van Spriel
Quoted 3 lines · Srinivas Dasari

This is needed to cover the case of DPP with the NIST P-521 and brainpoolP512r1 curves which derive a PMK that is longer than the previously used limit.

So how are driver supposed to deal with this longer PMK. Maybe if you could elaborate on what DPP stands for in this context it would become more clear.

device provisioning protocol, I guess? But longer curves and longer PMK is kinda obvious, whichever way that ends up getting used.

Quoted 3 lines

Can we stick with PMK_MAX_LEN or does it need to be more fine-grained per use-case? If existing drivers only support 48 bytes PMK and trust nl80211 code to check that limit it may screw them up. Not?

Yeah I'm concerned about this too - and regardless of that issue, we probably need those drivers that do support it to advertise support for the new curves, and then allow the longer PMK length only for those that do?

johannes

#3 lore raw
Quoted 6 lines · Johannes Berg
Quoted 5 lines · Arend van Spriel
Quoted 3 lines · Srinivas Dasari

This is needed to cover the case of DPP with the NIST P-521 and brainpoolP512r1 curves which derive a PMK that is longer than the previously used limit.

Quoted 6 lines
Quoted 3 lines

So how are driver supposed to deal with this longer PMK. Maybe if you could elaborate on what DPP stands for in this context it would become more clear.

device provisioning protocol, I guess? But longer curves and longer PMK is kinda obvious, whichever way that ends up getting used.

Yes, that's what DPP stands for here. With those two curves, the PMK will be 64 octets.

Quoted 7 lines
Quoted 3 lines

Can we stick with PMK_MAX_LEN or does it need to be more fine-grained per use-case? If existing drivers only support 48 bytes PMK and trust nl80211 code to check that limit it may screw them up. Not?

Yeah I'm concerned about this too - and regardless of that issue, we probably need those drivers that do support it to advertise support for the new curves, and then allow the longer PMK length only for those that do?

Please note that some drivers may not support even the current PMK_MAX_LEN (48) value. In fact, most of the cfg80211 cases using NL80211_ATTR_PMK are separately enforcing shorter lengths (32 or that 48), so this change in PMK_MAX_LEN definition does not actually have any impact for many of the existing cases. The only place where it does make a difference is NL80211_CMD_SET_PMKSA and NL80211_ATTR_PMK was added for that command with FILS authentication in mind in the first place (and that would not get a 64 octet value from wpa_supplicant at least).

It turns out that there are no known use of PMK with DPP authentication at the moment in any driver, so for now, I think I'll just make wpa_supplicant skip addition of the NL80211_ATTR_PMK if the PMK is longer than 48 octets. This should take care of the most immediate need, but it would be good to prepare for the possibility of there being a driver/firmware that would like to offload roaming and 4-way handshake with DPP APs and do that using this PMK value from DPP network introduction rather than offloading network introduction. For that to work, PMK_MAX_LEN needs to be increased.

So DPP works just fine with most drivers even with the 64 octet PMK (as long as that wpa_supplicant change goes in) when there is no requirement of offloading 4-way handshake.

As far as driver support for various PMK lengths is concerned, how should that be advertised? The limits can be different for each particular use of NL80211_ATTR_PMK (NL80211_CMD_CONNECT, NL80211_CMD_ASSOCIATE, NL80211_START_AP, NL80211_CMD_SET_PMKSA (for FILS), NL80211_CMD_SET_PMKSA (for DPP), NL80211_CMD_SET_PMKSA (for something else), NL80211_CMD_SET_PMK).

Signature · 1 line
Jouni Malinen                                            PGP id EFC895FA
maintainer
#4 lore raw
Quoted 10 lines · Jouni Malinen
Quoted 4 lines

Yeah I'm concerned about this too - and regardless of that issue, we probably need those drivers that do support it to advertise support for the new curves, and then allow the longer PMK length only for those that do?

Please note that some drivers may not support even the current PMK_MAX_LEN (48) value. In fact, most of the cfg80211 cases using NL80211_ATTR_PMK are separately enforcing shorter lengths (32 or that 48), so this change in PMK_MAX_LEN definition does not actually have any impact for many of the existing cases.

Ok. If the drivers are checking/don't care then we can deal without extra feature bits or something, IMHO, at least with respect to this specific issue of length checks.

Quoted 4 lines

The only place where it does make
a difference is NL80211_CMD_SET_PMKSA and NL80211_ATTR_PMK was added for that command with FILS authentication in mind in the first place (and that would not get a 64 octet value from wpa_supplicant at least).

Ok.

Quoted 4 lines

It turns out that there are no known use of PMK with DPP authentication at the moment in any driver, so for now, I think I'll just make wpa_supplicant skip addition of the NL80211_ATTR_PMK if the PMK is longer than 48 octets. This should take care of the most immediate need,

Fair enough.

Quoted 5 lines

but it would be good to prepare for the possibility of there being a driver/firmware that would like to offload roaming and 4-way handshake with DPP APs and do that using this PMK value from DPP network introduction rather than offloading network introduction. For that to work, PMK_MAX_LEN needs to be increased.

So let's do the patch anyway? I mean ... it's one patch or the other, so doesn't really make a huge difference?

Quoted 3 lines

So DPP works just fine with most drivers even with the 64 octet PMK (as long as that wpa_supplicant change goes in) when there is no requirement of offloading 4-way handshake.

Right.

Quoted 6 lines

As far as driver support for various PMK lengths is concerned, how should that be advertised? The limits can be different for each particular use of NL80211_ATTR_PMK (NL80211_CMD_CONNECT, NL80211_CMD_ASSOCIATE, NL80211_START_AP, NL80211_CMD_SET_PMKSA (for FILS), NL80211_CMD_SET_PMKSA (for DPP), NL80211_CMD_SET_PMKSA (for something else), NL80211_CMD_SET_PMK).

Yeah, that seems somewhat problematic? Though I'd hope they're kinda all the same limits?

Perhaps we rather need something like "DPP supported" vs. "long PMK supported" since just "long PMK" doesn't really say anything about the supported curves?

johannes