Skip to contentSkip to conversation

ARM: dts: phycore-imx6: set buck regulator modes explicitly

PATCH In review Christoph Fritz 2 participants 4 messages Feb 8, 2018 – Feb 9, 2018 3 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: phycore-imx6: set buck regulator modes explicitly

This patch sets initial buck regulator modes explicitly to a state this hardware needs. So a wrong initial mode set by bootloader or pmic itself does not interfere anymore.

---
 arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi +4 -0
index 53e4337..2ad1336 100644
@@ -109,6 +109,7 @@
 				regulator-name = "vdd_arm";
 				regulator-min-microvolt = <730000>;
 				regulator-max-microvolt = <1380000>;
+				regulator-initial-mode = <2>; /* SYNC */
 				regulator-always-on;
 			};
 
@@ -116,6 +117,7 @@
 				regulator-name = "vdd_soc";
 				regulator-min-microvolt = <730000>;
 				regulator-max-microvolt = <1380000>;
+				regulator-initial-mode = <2>; /* SYNC */
 				regulator-always-on;
 			};
 
@@ -123,6 +125,7 @@
 				regulator-name = "vdd_ddr3";
 				regulator-min-microvolt = <1500000>;
 				regulator-max-microvolt = <1500000>;
+				regulator-initial-mode = <2>; /* SYNC */
 				regulator-always-on;
 			};
 
@@ -130,6 +133,7 @@
 				regulator-name = "vdd_eth";
 				regulator-min-microvolt = <1200000>;
 				regulator-max-microvolt = <1200000>;
+				regulator-initial-mode = <2>; /* SYNC */
 				regulator-always-on;
 			};
 
Signature · 6 lines
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 1518088421.2347.9.camel-gM/[email protected]

#2 lore raw

Hi Christoph,

Quoted 15 lines · Christoph Fritz

This patch sets initial buck regulator modes explicitly to a state this hardware needs. So a wrong initial mode set by bootloader or pmic itself does not interfere anymore.

---
 arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi +0 -0
index 53e4337..2ad1336 100644

arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi line 112

Quoted 4 lines
arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi +1 -0
@@ -109,6 +109,7 @@
                                regulator-name = "vdd_arm";
                                regulator-min-microvolt = <730000>;
                                regulator-max-microvolt = <1380000>;
+                               regulator-initial-mode = <2>; /* SYNC */

According to Documentation/devicetree/bindings/regulator/twl-regulator.txt:

"- regulator-initial-mode: initial operating mode. The set of possible operating
modes depends on the capabilities of every hardware so each device binding documentation explains which values the regulator supports."

However, I haven't found the explanation of this property for the da9062-regulator.

Could you please add it into Documentation/devicetree/bindings/mfd/da9062.txt, so that we we know what the value 2 means here?
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): CAOMZO5Bsp2VGY0++XBqMd4aXj6uo-guzfH-jQ9R6uyanStfMtA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#4 lore raw
Quoted 1 line · Fabio Estevam

According to Documentation/devicetree/bindings/regulator/twl-regulator.txt:

Sorry, I mean "Documentation/devicetree/bindings/regulator/regulator.txt".

Quoted 11 lines

"- regulator-initial-mode: initial operating mode. The set of possible operating
modes depends on the capabilities of every hardware so each device binding documentation explains which values the regulator supports."

However, I haven't found the explanation of this property for the da9062-regulator.

Could you please add it into Documentation/devicetree/bindings/mfd/da9062.txt, so that we we know what the value 2 means here?

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): CAOMZO5CbKWXmFGzB25HtZuVa+C3wZk9DncBoe54ir8jWhyw7aw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#6 lore raw
Quoted 5 lines · Fabio Estevam
Quoted 1 line · Fabio Estevam

According to Documentation/devicetree/bindings/regulator/twl-regulator.txt:

Sorry, I mean "Documentation/devicetree/bindings/regulator/regulator.txt".

Thanks for pointing that out, I'll send a patchset with all changes.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html