nvme: use define instead of magic value for identify size
PATCH 1/1 nvme: use define instead of magic value for identify size
NVME_IDENTIFY_DATA_SIZE was added to linux/nvme.h by following commit.
commit 0add5e8e588c ("nvmet: use NVME_IDENTIFY_DATA_SIZE")
Make it use NVME_IDENTIFY_DATA_SIZE define instead of magic value 0x1000 in case of identify data size.
Signed-off-by Minwoo Im <minwoo.im.dev at gmail.com>
--- drivers/nvme/host/core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/nvme/host/core.c +3 -2
@@ -944,7 +944,8 @@ static int nvme_identify_ns_list(struct nvme_ctrl *dev, unsigned nsid, __le32 *n c.identify.opcode = nvme_admin_identify; c.identify.cns =NVME_ID_CNS_NS_ACTIVE_LIST ; c.identify.nsid =cpu_to_le32 (nsid); -return nvme_submit_sync_cmd (dev->admin_q, &c, ns_list,0x1000 ); +return nvme_submit_sync_cmd (dev->admin_q, &c, ns_list, +NVME_IDENTIFY_DATA_SIZE ); } static struct nvme_id_ns *nvme_identify_ns(struct nvme_ctrl *ctrl,
@@ -3100,7 +3101,7 @@ static int nvme_scan_ns_list(struct nvme_ctrl *ctrl, unsigned nn)unsigned i, j, nsid, prev =0 , num_lists =DIV_ROUND_UP (nn,1024 );int ret =0 ; - ns_list =kzalloc (0x1000 ,GFP_KERNEL ); + ns_list =kzalloc (NVME_IDENTIFY_DATA_SIZE ,GFP_KERNEL );if (!ns_list)return -ENOMEM ;
Signature · 1 line
2.7.4
PATCH 1/1 nvme: use define instead of magic value for identify size
Looks good
Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>
Signature · 6 lines
Johannes Thumshirn Storage jthumshirn at suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850