Skip to contentSkip to conversation

drivers: base: add description for .coredump() callback

PATCH In review Arend van Spriel 3 participants 4 messages Feb 9, 2018 – Mar 15, 2018 Driver core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: base: add description for .coredump() callback

Commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") added a new callback in struct device_driver, but not a kerneldoc description so here it is.

Fixes 3c47d19ff4dc ("drivers: base: add coredump driver ops")
---
 include/linux/device.h | 1 +
 1 file changed, 1 insertion(+)
include/linux/device.h +1 -0
index b093405..0b32a42 100644
@@ -256,6 +256,7 @@ enum probe_type {
  *		automatically.
  * @pm:		Power management operations of the device which matched
  *		this driver.
+ * @coredump:	Called through sysfs to initiate a device coredump.
  * @p:		Driver core's private data, no one other than the driver
  *		core can touch this.
  *
Signature · 1 line
1.9.1
#1 lore raw
Quoted 3 lines · Arend van Spriel

Commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") added a new callback in struct device_driver, but not a kerneldoc description so here it is.

Hi Greg,

Revisiting the header file I notice this patch is not yet applied. I am pretty sure I got an automated email from you regarding the merge window, but nothing else so did this one slip the cracks?

Regards,
Arend

Quoted 19 lines
Fixes 3c47d19ff4dc ("drivers: base: add coredump driver ops")
---
  include/linux/device.h | 1 +
  1 file changed, 1 insertion(+)
include/linux/device.h +1 -0
index b093405..0b32a42 100644
@@ -256,6 +256,7 @@ enum probe_type {
   *		automatically.
   * @pm:		Power management operations of the device which matched
   *		this driver.
+ * @coredump:	Called through sysfs to initiate a device coredump.
   * @p:		Driver core's private data, no one other than the driver
   *		core can touch this.
   *
#2 lore raw
Quoted 10 lines · Arend van Spriel
Quoted 3 lines · Arend van Spriel

Commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") added a new callback in struct device_driver, but not a kerneldoc description so here it is.

Hi Greg,

Revisiting the header file I notice this patch is not yet applied. I am pretty sure I got an automated email from you regarding the merge window, but nothing else so did this one slip the cracks?

Hi Greg,

As I am touching this in follow-up patch, can we just drop this one? I will be posting a couple of new patch assuming it is fine to drop this. Let me know how you want to handle this.

Regards,
Arend

Quoted 23 lines

Regards,
Arend

Quoted 19 lines
Fixes 3c47d19ff4dc ("drivers: base: add coredump driver ops")
---
  include/linux/device.h | 1 +
  1 file changed, 1 insertion(+)
include/linux/device.h +1 -0
index b093405..0b32a42 100644
@@ -256,6 +256,7 @@ enum probe_type {
   *        automatically.
   * @pm:        Power management operations of the device which matched
   *        this driver.
+ * @coredump:    Called through sysfs to initiate a device coredump.
   * @p:        Driver core's private data, no one other than the driver
   *        core can touch this.
   *
#3 lore raw
Quoted 12 lines · Arend van Spriel
Quoted 10 lines · Arend van Spriel
Quoted 3 lines · Arend van Spriel

Commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") added a new callback in struct device_driver, but not a kerneldoc description so here it is.

Hi Greg,

Revisiting the header file I notice this patch is not yet applied. I am pretty sure I got an automated email from you regarding the merge window, but nothing else so did this one slip the cracks?

Quoted 5 lines

Hi Greg,

As I am touching this in follow-up patch, can we just drop this one? I will be posting a couple of new patch assuming it is fine to drop this. Let me know how you want to handle this.

Just applied this, it's trivial and should be simple to merge around.

thanks,

greg k-h