Skip to contentSkip to conversation

v4l: vsp1: Fix header display list status check in continuous mode

PATCH New Kieran Bingham 1 participant 1 message Feb 9, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 v4l: vsp1: Fix header display list status check in continuous mode

From: Kieran Bingham <[email protected]>

To allow dual pipelines utilising two WPF entities when available, the VSP was updated to support header-mode display list in continuous pipelines.

A small bug in the status check of the command register causes the second pipeline to be directly afflicted by the running of the first; appearing as a perceived performance issue with stuttering display.

Fix the vsp1_dl_list_hw_update_pending() call to ensure that the read comparison corresponds to the correct pipeline.

Fixes eaf4bfad6ad8 ("v4l: vsp1: Add support for header display

lists in continuous mode")
Cc: "Stable v4.14+" <[email protected]>

---
 drivers/media/platform/vsp1/vsp1_dl.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/media/platform/vsp1/vsp1_dl.c +2 -1
index 8cd03ee45f79..34b5ed2592f8 100644
@@ -509,7 +509,8 @@ static bool vsp1_dl_list_hw_update_pending(struct vsp1_dl_manager *dlm)
 		return !!(vsp1_read(vsp1, VI6_DL_BODY_SIZE)
 			  & VI6_DL_BODY_SIZE_UPD);
 	else
-		return !!(vsp1_read(vsp1, VI6_CMD(dlm->index) & VI6_CMD_UPDHDR));
+		return !!(vsp1_read(vsp1, VI6_CMD(dlm->index))
+			  & VI6_CMD_UPDHDR);
 }
 
 static bool vsp1_dl_hw_active(struct vsp1_dl_manager *dlm)
Signature · 1 line
2.7.4