perf kmem: Document a missing option & an argument
PATCH 1/2 perf kmem: Document a missing option & an argument
First, perf kmem has --force option, but didn't document it on the man page. So add missing --force option.
Second, --time option has to get a value, but didn't specify it on the man page. So describe --time option's argument.
--- tools/perf/Documentation/perf-kmem.txt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
tools/perf/Documentation/perf-kmem.txt +4 -1
@@ -25,6 +25,9 @@ OPTIONS --input=<file>:: Select the input file (default: perf.data unless stdin is a fifo) +-f:: +--force:: + Don't do ownership validation -v:: --verbose:: Be more verbose. (show symbol address, etc)
@@ -61,7 +64,7 @@ OPTIONS default, but this option shows live (currently allocated) pages instead. (This option works with --page option only) ---time:: +--time=<start>,<stop>:: Only analyze samples within given time window: <start>,<stop>. Times have the format seconds.microseconds. If start is not given (i.e., time string is ',x.y') then analysis starts at the beginning of the file. If
Signature · 1 line
2.7.4
PATCH 2/2 perf mem: Document a missing option
Add the missing --force option on the man page.
--- tools/perf/Documentation/perf-mem.txt | 4 ++++ 1 file changed, 4 insertions(+)
tools/perf/Documentation/perf-mem.txt +4 -0
@@ -28,6 +28,10 @@ OPTIONS <command>...:: Any command you can specify in a shell. +-f:: +--force:: + Don't do ownership validation + -t:: --type=:: Select the memory operation type: load or store (default: load,store)
Signature · 1 line
2.7.4
Re: [PATCH 2/2] perf mem: Document a missing option
Quoted 6 lines · Sangwon Hong
Add the missing --force option on the man page.
Cc Jiri Olsa <[email protected]>Cc Namhyung Kim <[email protected]>Cc Taeung Song <[email protected]>Signed-off-by Sangwon Hong <[email protected]>
Thanks,
Namhyung
Quoted 22 lines
--- tools/perf/Documentation/perf-mem.txt | 4 ++++ 1 file changed, 4 insertions(+)tools/perf/Documentation/perf-mem.txt +4
-0@@ -28,6 +28,10 @@ OPTIONS <command>...:: Any command you can specify in a shell. +-f:: +--force:: + Don't do ownership validation + -t:: --type=:: Select the memory operation type: load or store (default: load,store)Signature · 1 line
2.7.4
tip-bot for Sangwon Hong
merge bot[tip:perf/core] perf mem: Document a missing option
In reply to Sangwon Hongperf mem: Document a missing option
Commit-ID: 7e99b1972263c2f611d7f2fb67d09f3384006593 Gitweb: https://git.kernel.org/tip/7e99b1972263c2f611d7f2fb67d09f3384006593 Author: Sangwon Hong <[email protected]> AuthorDate: Mon, 12 Feb 2018 05:38:37 +0900 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Fri, 16 Feb 2018 14:55:42 -0300
perf mem: Document a missing option
Add the missing --force option on the man page.
--- tools/perf/Documentation/perf-mem.txt | 4 ++++ 1 file changed, 4 insertions(+)
tools/perf/Documentation/perf-mem.txt +4 -0
@@ -28,6 +28,10 @@ OPTIONS <command>...:: Any command you can specify in a shell. +-f:: +--force:: + Don't do ownership validation + -t:: --type=:: Select the memory operation type: load or store (default: load,store)
Quoted 10 lines · Sangwon Hong
First, perf kmem has --force option, but didn't document it on the man page. So add missing --force option.
Second, --time option has to get a value, but didn't specify it on the man page. So describe --time option's argument.
Cc Jiri Olsa <[email protected]>Cc Namhyung Kim <[email protected]>Cc Taeung Song <[email protected]>Signed-off-by Sangwon Hong <[email protected]>
A nit below though..
Quoted 9 lines
--- tools/perf/Documentation/perf-kmem.txt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)tools/perf/Documentation/perf-kmem.txt +0
-0
tools/perf/Documentation/perf-kmem.txt OPTIONS · line 30
Quoted 6 lines
tools/perf/Documentation/perf-kmem.txt +3
-0@@ -25,6 +25,9 @@ OPTIONS --input=<file>:: Select the input file (default: perf.data unless stdin is a fifo) +-f:: +--force:: + Don't do ownership validation
Please add a blank line here
Thanks,
Namhyung
Quoted 15 lines
tools/perf/Documentation/perf-kmem.txt +1
-1-v:: --verbose:: Be more verbose. (show symbol address, etc)@@ -61,7 +64,7 @@ OPTIONS default, but this option shows live (currently allocated) pages instead. (This option works with --page option only) ---time:: +--time=<start>,<stop>:: Only analyze samples within given time window: <start>,<stop>. Times have the format seconds.microseconds. If start is not given (i.e., time string is ',x.y') then analysis starts at the beginning of the file. IfSignature · 1 line
2.7.4
Arnaldo Carvalho de Melo
maintainerEm Mon, Feb 12, 2018 at 10:51:28AM +0900, Namhyung Kim escreveu:
Quoted 29 lines · Sangwon Hong
Quoted 10 lines
First, perf kmem has --force option, but didn't document it on the man page. So add missing --force option.
Second, --time option has to get a value, but didn't specify it on the man page. So describe --time option's argument.
Cc Jiri Olsa <[email protected]>Cc Namhyung Kim <[email protected]>Cc Taeung Song <[email protected]>Signed-off-by Sangwon Hong <[email protected]>Acked-by Namhyung Kim <[email protected]>A nit below though..
Quoted 12 lines
--- tools/perf/Documentation/perf-kmem.txt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)tools/perf/Documentation/perf-kmem.txt +0
-0@@ -25,6 +25,9 @@ OPTIONS --input=<file>:: Select the input file (default: perf.data unless stdin is a fifo)
Quoted 5 lines
tools/perf/Documentation/perf-kmem.txt OPTIONS · line 30
Quoted 3 lines
tools/perf/Documentation/perf-kmem.txt +3
-0+-f:: +--force:: + Don't do ownership validationPlease add a blank line here
Done
Quoted 19 lines
Thanks,
NamhyungQuoted 15 lines
tools/perf/Documentation/perf-kmem.txt +1
-1-v:: --verbose:: Be more verbose. (show symbol address, etc)@@ -61,7 +64,7 @@ OPTIONS default, but this option shows live (currently allocated) pages instead. (This option works with --page option only) ---time:: +--time=<start>,<stop>:: Only analyze samples within given time window: <start>,<stop>. Times have the format seconds.microseconds. If start is not given (i.e., time string is ',x.y') then analysis starts at the beginning of the file. IfSignature · 1 line
2.7.4
tip-bot for Sangwon Hong
merge botperf kmem: Document a missing option & an argument
Commit-ID: 577980a00063935815a55f461601579fd5e61f59 Gitweb: https://git.kernel.org/tip/577980a00063935815a55f461601579fd5e61f59 Author: Sangwon Hong <[email protected]> AuthorDate: Mon, 12 Feb 2018 05:38:36 +0900 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Fri, 16 Feb 2018 14:55:42 -0300
perf kmem: Document a missing option & an argument
First, 'perf kmem' has a '--force' option, but didn't document it on the man page. So add it.
Second, the '--time' option has to get a value, but isn't documented on the man page. Describe it.
--- tools/perf/Documentation/perf-kmem.txt | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
tools/perf/Documentation/perf-kmem.txt +5 -1
@@ -25,6 +25,10 @@ OPTIONS --input=<file>:: Select the input file (default: perf.data unless stdin is a fifo) +-f:: +--force:: + Don't do ownership validation + -v:: --verbose:: Be more verbose. (show symbol address, etc)
@@ -61,7 +65,7 @@ OPTIONS default, but this option shows live (currently allocated) pages instead. (This option works with --page option only) ---time:: +--time=<start>,<stop>:: Only analyze samples within given time window: <start>,<stop>. Times have the format seconds.microseconds. If start is not given (i.e., time string is ',x.y') then analysis starts at the beginning of the file. If