irqchip/irq-imx-gpcv2: Remove unused function
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/1 irqchip/irq-imx-gpcv2: Remove unused function
From: Fabio Estevam <[email protected]>
imx_gpcv2_get_wakeup_source() is not used anywhere, so remove it.
This fixes the following sparse warning:
drivers/irqchip/irq-imx-gpcv2.c:34:5: warning: symbol 'imx_gpcv2_get_wakeup_source' was not declared. Should it be static?
--- drivers/irqchip/irq-imx-gpcv2.c | 14 -------------- 1 file changed, 14 deletions(-)
drivers/irqchip/irq-imx-gpcv2.c +0 -14
@@ -28,20 +28,6 @@ struct gpcv2_irqchip_data {static struct gpcv2_irqchip_data *imx_gpcv2_instance; -/* -* Interface for the low level wakeup code. -*/ -u32 imx_gpcv2_get_wakeup_source (u32 **sources) -{ -if (!imx_gpcv2_instance) -return 0 ; - -if (sources) - *sources = imx_gpcv2_instance->wakeup_sources; - -return IMR_NUM ; -} -static int gpcv2_wakeup_source_save (void ) {struct gpcv2_irqchip_data *cd;
Signature · 1 line
2.7.4
Quoted 29 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
imx_gpcv2_get_wakeup_source()is not used anywhere, so remove it.This fixes the following sparse warning:
drivers/irqchip/irq-imx-gpcv2.c:34:5: warning: symbol 'imx_gpcv2_get_wakeup_source' was not declared. Should it be static?Signed-off-by Fabio Estevam <[email protected]>--- drivers/irqchip/irq-imx-gpcv2.c | 14 -------------- 1 file changed, 14 deletions(-)drivers/irqchip/irq-imx-gpcv2.c +0
-7@@ -28,20 +28,6 @@ struct gpcv2_irqchip_data {static struct gpcv2_irqchip_data *imx_gpcv2_instance; -/* -* Interface for the low level wakeup code. -*/ -u32 imx_gpcv2_get_wakeup_source (u32 **sources) -{ -if (!imx_gpcv2_instance) -return 0 ;
drivers/irqchip/irq-imx-gpcv2.c struct gpcv2_irqchip_data { · line 33
Quoted 10 lines
drivers/irqchip/irq-imx-gpcv2.c +0
-7- -if (sources) - *sources = imx_gpcv2_instance->wakeup_sources; - -return IMR_NUM ; -} -static int gpcv2_wakeup_source_save (void ) {struct gpcv2_irqchip_data *cd;
I'll queue this up for -rc2, with this addition:
sources")
Thanks,
M.
Signature · 1 line
Jazz is not dead. It just smells funny...
Fabio Estevam
reviewerHi Marc,
Quoted 4 lines · Marc Zyngier
I'll queue this up for -rc2, with this addition:
Fixes e324c4dc4a59 ("irqchip/imx-gpcv2: IMX GPCv2 driver for wakeupsources")
It seems this one got missed?
Thanks
Quoted 11 lines · Fabio Estevam
Hi Marc,
Quoted 4 lines · Marc Zyngier
I'll queue this up for -rc2, with this addition:
Fixes e324c4dc4a59 ("irqchip/imx-gpcv2: IMX GPCv2 driver for wakeupsources")
It seems this one got missed?
Yes, that's quite bizarre. I see it in the queue of patches for the -rc2 pull request, but I managed not to apply it. I have no idea how I managed that, as the process is pretty much automatic... I must have dropped it when rebasing the branch on -rc1. Sorry about that.
I've now moved the patch to the -rc5 tag which I'm about to send to Thomas with the few patches I had already queued.
Thanks for the heads up.
M.
Signature · 1 line
Jazz is not dead, it just smell funny.