vmw_pvrdma: Fix SRQN returned to library
PATCH 1/1 vmw_pvrdma: Fix SRQN returned to library
From: Aditya Sarwade <[email protected]>
Here's a fix for the vmw_pvrdma library. It needs to go into the stable branch for 16.0 as well since we can then add it to OFED-4.8-2.
The PR is here:
https://github.com/linux-rdma/rdma-core/pull/291
Thanks,
Adit
---
Use the correct SQN reported by the driver.
--- providers/vmw_pvrdma/qp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
providers/vmw_pvrdma/qp.c +3 -3
@@ -108,7 +108,7 @@ struct ibv_srq *pvrdma_create_srq(struct ibv_pd *pd, {struct pvrdma_device *dev =to_vdev (pd->context->device);struct user_pvrdma_create_srq cmd; -struct ib_uverbs_create_srq_resp resp; +struct user_pvrdma_create_srq_resp resp;struct pvrdma_srq *srq;int ret;
@@ -142,12 +142,12 @@ struct ibv_srq *pvrdma_create_srq(struct ibv_pd *pd, ret =ibv_cmd_create_srq (pd, &srq->ibv_srq, attr, &cmd.ibv_cmd,sizeof (cmd), - &resp,sizeof (resp)); + &resp.ibv_resp,sizeof (resp));if (ret) goto err_free; - srq->srqn = resp.srqn; + srq->srqn = resp.udata.srqn;return &srq->ibv_srq;
Signature · 6 lines
1.8.5.6 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 1518460956-4629-1-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org
Quoted 35 lines · Adit Ranadive
From: Aditya Sarwade <[email protected]>
Here's a fix for the
vmw_pvrdmalibrary. It needs to go into the stable branch for 16.0 as well since we can then add it to OFED-4.8-2.The PR is here:
https://github.com/linux-rdma/rdma-core/pull/291Thanks,
AditUse the correct SQN reported by the driver.
Fixes 4c8ed14eb6b7 ("vmw_pvrdma: Add SRQ support")Reviewed-by Adit Ranadive <[email protected]>Reviewed-by Bryan Tan <[email protected]>Signed-off-by Aditya Sarwade <[email protected]>providers/vmw_pvrdma/qp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)providers/vmw_pvrdma/qp.c +2
-1+++ b/providers/vmw_pvrdma/qp.c@@ -108,7 +108,7 @@ struct ibv_srq *pvrdma_create_srq(struct ibv_pd *pd, {struct pvrdma_device *dev =to_vdev (pd->context->device);struct user_pvrdma_create_srq cmd; -struct ib_uverbs_create_srq_resp resp; +struct user_pvrdma_create_srq_resp resp;struct pvrdma_srq *srq;int ret;@@ -142,12 +142,12 @@ struct ibv_srq *pvrdma_create_srq(struct ibv_pd *pd,
providers/vmw_pvrdma/qp.c struct ibv_srq *pvrdma_create_srq(struct ibv_pd *pd, · line 150
Quoted 10 lines
providers/vmw_pvrdma/qp.c +2
-2ret =ibv_cmd_create_srq (pd, &srq->ibv_srq, attr, &cmd.ibv_cmd,sizeof (cmd), - &resp,sizeof (resp)); + &resp.ibv_resp,sizeof (resp));if (ret) goto err_free; - srq->srqn = resp.srqn; + srq->srqn = resp.udata.srqn;
I can't make sense of this.
Why doesn't grep turn up anything for struct pvrdma_create_srq_resp in the kernel?
And why do we have two things called srqn in this struct?
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 20180212185906.GE5005-VPRAkNaXOzVWk0Htik3J/[email protected]
Quoted 6 lines · Jason Gunthorpe
Quoted 5 lines · Adit Ranadive
From: Aditya Sarwade <[email protected]>
Here's a fix for the
vmw_pvrdmalibrary. It needs to go into the stable branch for 16.0 as well since we can then add it to OFED-4.8-2.
<snip>
Quoted 5 lines
I can't make sense of this.
Why doesn't grep turn up anything for struct
pvrdma_create_srq_respin the kernel?
Do you mean user_pvrdma_create_srq_resp? There isn’t one. Its part of our ABI fix up in rdma-core.
Quoted 2 lines
And why do we have two things called srqn in this struct?
It looks like the uverbs in the kernel reports the XRC SRQN in the one of these while the other gets populated by the driver in the udata here. The SRQN for a regular SRQ only gets reported in this second srqn field. I'm not sure why that's the case but we need to report the one from the driver here then.
Quoted 3 lines
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): ab90a493-3680-d776-e52b-3918b2bd1a6a-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org
Quoted 6 lines · Adit Ranadive
Quoted 4 lines
I can't make sense of this.
Why doesn't grep turn up anything for struct
pvrdma_create_srq_respin the kernel?Do you mean
user_pvrdma_create_srq_resp? There isn’t one.
No, I mean what I wrote..
include/uapi/rdma/vmw_pvrdma-abi.h:struct pvrdma_create_srq_resp {
Why isn't it used anywhere?
Quoted 7 lines
Quoted 1 line
And why do we have two things called srqn in this struct?
It looks like the uverbs in the kernel reports the XRC SRQN in the one of these while the other gets populated by the driver in the udata here. The SRQN for a regular SRQ only gets reported in this second srqn field. I'm not sure why that's the case but we need to report the one from the driver here then.
Ok
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 20180212222650.GA10773-VPRAkNaXOzVWk0Htik3J/[email protected]
Quoted 7 lines · Jason Gunthorpe
Quoted 5 lines · Adit Ranadive
Quoted 4 lines
I can't make sense of this.
Why doesn't grep turn up anything for struct
pvrdma_create_srq_respin the kernel?
Quoted 7 lines
Quoted 1 line
Do you mean
user_pvrdma_create_srq_resp? There isn’t one.No, I mean what I wrote..
include/uapi/rdma/vmw_pvrdma-abi.h:struct
pvrdma_create_srq_resp{Why isn't it used anywhere?
Hrm, it should be. We seem to be copying the srqn directly into the udata rather than using this structure for copying. I'll send out a patch for this. We still need the rdma-core patch though independently of this kernel patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Le 12/02/2018 à 19:42, Adit Ranadive a écrit :
Quoted 5 lines
From: Aditya Sarwade <[email protected]>
Here's a fix for the
vmw_pvrdmalibrary. It needs to go into the stable branch for 16.0 as well since we can then add it to OFED-4.8-2.
Quoted 7 lines
The PR is here:
https://github.com/linux-rdma/rdma-core/pull/291Thanks,
Adit
---
Submitted to stable-v16.
Do you know when OFED 4.8-2 is going out ? Is a new v16.3 release needed right now ?
Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): de50c35a-731d-bfb6-efe9-7f2ad83ea7b3-l3A5Bk7waGM@public.gmane.org
OFED 4.8.2 rc1 was just released on 02/09/2018.
The Openfabrics EWG chair thinks maybe 2-4 weeks out for OFED 4.8.2.
Cheers.
--
Llolsten
-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Nicolas Morey-Chaisemartin
Sent: Tuesday, February 13, 2018 7:24 AM
To: Adit Ranadive <[email protected]>; [email protected]; jgg-VPRAkNaXOzVWk0Htik3J/[email protected]; [email protected]
Cc: [email protected]; Aditya Sarwade <[email protected]>; [email protected]
Subject: Re: [PATCH rdma-core] vmw_pvrdma: Fix SRQN returned to library
Quoted 5 lines · Adit Ranadive
From: Aditya Sarwade <[email protected]>
Here's a fix for the
vmw_pvrdmalibrary. It needs to go into the stable branch for 16.0 as well since we can then add it to OFED-4.8-2.
Quoted 7 lines
The PR is here:
https://github.com/linux-rdma/rdma-core/pull/291Thanks,
Adit
---
Submitted to stable-v16.
Do you know when OFED 4.8-2 is going out ? Is a new v16.3 release needed right now ?
Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 4 lines · Nicolas Morey-Chaisemartin
Submitted to stable-v16.
Do you know when OFED 4.8-2 is going out ? Is a new v16.3 release needed right now ?
Thanks Nicolas!
We would need a v16.3 for OFED-4.8-2 but let me test OFED-4.8-2 RC1 with this change and get back to you today.
Thanks,
Adit
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 6 lines · Nicolas Morey-Chaisemartin
Submitted to stable-v16.
Do you know when OFED 4.8-2 is going out ? Is a new v16.3 release needed right now ?
Thanks Nicolas! I have completed my testing so we would need a new v16.3 release. I can let Vlad know once its generated for him to pick up the new rdma-core.
Thanks,
Adit
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 8b4f73e6-af5c-d5e2-5425-fbd706a50f66-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org
Le 14/02/2018 à 07:12, Adit Ranadive a écrit :
Quoted 6 lines · Nicolas Morey-Chaisemartin
Quoted 5 lines
Submitted to stable-v16.
Do you know when OFED 4.8-2 is going out ? Is a new v16.3 release needed right now ?
Quoted 6 lines
Thanks Nicolas! I have completed my testing so we would need a new v16.3 release. I can let Vlad know once its generated for him to pick up the new rdma-core.
Thanks,
Adit
--
Do you mind if I wait til next week for a release ?
There are no more fixes pending atm, but if you're not in a hurry, I'd like to wait a bit to avoid releasing too often.
Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): b5512350-48f1-c4e6-096f-a44307bdf015-l3A5Bk7waGM@public.gmane.org
Quoted 12 lines · Nicolas Morey-Chaisemartin
Le 14/02/2018 à 07:12, Adit Ranadive a écrit :
Quoted 9 lines · Nicolas Morey-Chaisemartin
Quoted 5 lines
Submitted to stable-v16.
Do you know when OFED 4.8-2 is going out ? Is a new v16.3 release needed right now ?Thanks Nicolas! I have completed my testing so we would need a new v16.3 release. I can let Vlad know once its generated for him to pick up the new rdma-core.
Quoted 7 lines
Quoted 3 lines
Thanks,
Adit
--Do you mind if I wait til next week for a release ?
There are no more fixes pending atm, but if you're not in a hurry, I'd like to wait a bit to avoid releasing too often.
That's fine with me. Unless, Vlad needs it asap.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 12 lines · Nicolas Morey-Chaisemartin
Le 14/02/2018 à 07:12, Adit Ranadive a écrit :
Quoted 9 lines · Nicolas Morey-Chaisemartin
Quoted 5 lines
Submitted to stable-v16.
Do you know when OFED 4.8-2 is going out ? Is a new v16.3 release needed right now ?Thanks Nicolas! I have completed my testing so we would need a new v16.3 release. I can let Vlad know once its generated for him to pick up the new rdma-core.
Quoted 6 lines
Quoted 3 lines
Thanks,
Adit
--Do you mind if I wait til next week for a release ?
There are no more fixes pending atm, but if you're not in a hurry, I'd like to wait a bit to avoid releasing too often.
Hi Nicolas,
Turns out there is one more patch that needs to go into v16.3. It was an older internal branch which I had forgotten about after we moved to a new git repo. Sorry for the mixup and thanks for holding up the release! I'll send out the other patch.
Thanks,
Adit
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html