drm/etnaviv: etnaviv_sched: Staticize functions when possible
Subsystems (2)
PATCH 1/1 drm/etnaviv: etnaviv_sched: Staticize functions when possible
From: Fabio Estevam <[email protected]>
etnaviv_sched_dependency() and etnaviv_sched_run_job() are only used in this file, so make them static.
This fixes the following sparse warnings:
drivers/gpu/drm/etnaviv/etnaviv_sched.c:30:18: warning: symbol 'etnaviv_sched_dependency' was not declared. Should it be static? drivers/gpu/drm/etnaviv/etnaviv_sched.c:81:18: warning: symbol 'etnaviv_sched_run_job' was not declared. Should it be static?
--- drivers/gpu/drm/etnaviv/etnaviv_sched.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/gpu/drm/etnaviv/etnaviv_sched.c +4 -3
@@ -27,8 +27,9 @@ module_param_named(job_hang_limit, etnaviv_job_hang_limit, int , 0444);static int etnaviv_hw_jobs_limit =2 ;module_param_named (hw_job_limit, etnaviv_hw_jobs_limit, int ,0444 ); -struct dma_fence *etnaviv_sched_dependency (struct drm_sched_job *sched_job, -struct drm_sched_entity *entity) +static struct dma_fence * +etnaviv_sched_dependency (struct drm_sched_job *sched_job, +struct drm_sched_entity *entity) {struct etnaviv_gem_submit *submit =to_etnaviv_submit (sched_job);struct dma_fence *fence;
@@ -78,7 +79,7 @@ struct dma_fence *etnaviv_sched_dependency(struct drm_sched_job *sched_job,return NULL ; } -struct dma_fence *etnaviv_sched_run_job (struct drm_sched_job *sched_job) +static struct dma_fence *etnaviv_sched_run_job (struct drm_sched_job *sched_job) {struct etnaviv_gem_submit *submit =to_etnaviv_submit (sched_job);struct dma_fence *fence =NULL ;
Signature · 6 lines
2.7.4 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Lucas Stach
maintainerAm Dienstag, den 13.02.2018, 16:36 -0200 schrieb Fabio Estevam:
Quoted 11 lines
Quoted 1 line
From: Fabio Estevam <[email protected]>
etnaviv_sched_dependency()andetnaviv_sched_run_job()are only used in this file, so make them static.This fixes the following sparse warnings:
drivers/gpu/drm/etnaviv/etnaviv_sched.c:30:18: warning: symbol 'etnaviv_sched_dependency' was not declared. Should it be static?drivers/gpu/drm/etnaviv/etnaviv_sched.c:81:18: warning: symbol 'etnaviv_sched_run_job' was not declared. Should it be static?Signed-off-by Fabio Estevam <[email protected]>
Thanks, I've applied this to my etnaviv/next tree.
Regards,
Lucas
Quoted 26 lines
---
drivers/gpu/drm/etnaviv/etnaviv_sched.c | 7 ++++---1 file changed, 4 insertions(+), 3 deletions(-)drivers/gpu/drm/etnaviv/etnaviv_sched.c +0
-0@@ -27,8 +27,9 @@ module_param_named(job_hang_limit, etnaviv_job_hang_limit, int , 0444); static int etnaviv_hw_jobs_limit = 2; module_param_named(hw_job_limit, etnaviv_hw_jobs_limit, int , 0444);
-structdma_fence*etnaviv_sched_dependency(structdrm_sched_job*sched_job,Quoted 1 line
drivers/gpu/drm/etnaviv/etnaviv_sched.c +0
-1- struct drm_sched_entity *entity)drivers/gpu/drm/etnaviv/etnaviv_sched.c +2
-0+static struct dma_fence * +etnaviv_sched_dependency(struct drm_sched_job *sched_job,drivers/gpu/drm/etnaviv/etnaviv_sched.c module_param_named(job_hang_limit, etnaviv_job_hang_limit, int , 0444); · line 32
Quoted 1 line
drivers/gpu/drm/etnaviv/etnaviv_sched.c +1
-0+ struct drm_sched_entity *entity){
Quoted 2 lines
struct
etnaviv_gem_submit*submit =to_etnaviv_submit(sched_job); structdma_fence*fence;drivers/gpu/drm/etnaviv/etnaviv_sched.c +0
-0@@ -78,7 +79,7 @@ struct dma_fence *etnaviv_sched_dependency(struct drm_sched_job *sched_job, > return NULL; }drivers/gpu/drm/etnaviv/etnaviv_sched.c +1
-1-struct dma_fence *etnaviv_sched_run_job (struct drm_sched_job *sched_job) +static struct dma_fence *etnaviv_sched_run_job (struct drm_sched_job *sched_job)
Quoted 3 lines
{
Quoted 2 lines
struct
etnaviv_gem_submit*submit =to_etnaviv_submit(sched_job); structdma_fence*fence = NULL;
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel