drm/imx: ipuv3-plane: Make functions static when possible
Subsystems (3)
Fabio Estevam
reviewerPATCH 1/2 drm/imx: ipuv3-plane: Make functions static when possible
From: Fabio Estevam <[email protected]>
ipu_plane_state_reset(), ipu_plane_duplicate_state() and ipu_plane_destroy_state() are only used in this file, so make them static.
This fixes the following sparse warnings:
drivers/gpu/drm/imx/ipuv3-plane.c:275:6: warning: symbol 'ipu_plane_state_reset' was not declared. Should it be static? drivers/gpu/drm/imx/ipuv3-plane.c:295:24: warning: symbol 'ipu_plane_duplicate_state' was not declared. Should it be static? drivers/gpu/drm/imx/ipuv3-plane.c:309:6: warning: symbol 'ipu_plane_destroy_state' was not declared. Should it be static?
--- drivers/gpu/drm/imx/ipuv3-plane.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/gpu/drm/imx/ipuv3-plane.c +5 -4
@@ -272,7 +272,7 @@ static void ipu_plane_destroy(struct drm_plane *plane)kfree (ipu_plane); } -void ipu_plane_state_reset (struct drm_plane *plane) +static void ipu_plane_state_reset (struct drm_plane *plane) {struct ipu_plane_state *ipu_state;
@@ -292,7 +292,8 @@ void ipu_plane_state_reset(struct drm_plane *plane) plane->state = &ipu_state->base; } -struct drm_plane_state *ipu_plane_duplicate_state (struct drm_plane *plane) +static struct drm_plane_state * +ipu_plane_duplicate_state (struct drm_plane *plane) {struct ipu_plane_state *state;
@@ -306,8 +307,8 @@ struct drm_plane_state *ipu_plane_duplicate_state(struct drm_plane *plane)return &state->base; } -void ipu_plane_destroy_state (struct drm_plane *plane, -struct drm_plane_state *state) +static void ipu_plane_destroy_state (struct drm_plane *plane, +struct drm_plane_state *state) {struct ipu_plane_state *ipu_state =to_ipu_plane_state (state);
Signature · 6 lines
2.7.4 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Fabio Estevam
reviewerPATCH 2/2 drm/imx: ipuv3-plane: Include "imx-drm.h" header file
From: Fabio Estevam <[email protected]>
ipu_planes_assign_pre() prototype is in "imx-drm.h" header file, so include it to fix the following sparse warning:
drivers/gpu/drm/imx/ipuv3-plane.c:729:5: warning: symbol 'ipu_planes_assign_pre' was not declared. Should it be static?
--- drivers/gpu/drm/imx/ipuv3-plane.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/imx/ipuv3-plane.c +1 -0
@@ -22,6 +22,7 @@#include <drm/drm_plane_helper.h> #include "video/imx-ipu-v3.h" +#include "imx-drm.h" #include "ipuv3-plane.h" struct ipu_plane_state {
Signature · 6 lines
2.7.4 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Philipp Zabel
AppliedQuoted 5 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
ipu_plane_state_reset(),ipu_plane_duplicate_state()andipu_plane_destroy_state()are only used in this file, so make them static.
Quoted 7 lines
This fixes the following sparse warnings:
drivers/gpu/drm/imx/ipuv3-plane.c:275:6: warning: symbol 'ipu_plane_state_reset' was not declared. Should it be static?drivers/gpu/drm/imx/ipuv3-plane.c:295:24: warning: symbol 'ipu_plane_duplicate_state' was not declared. Should it be static?drivers/gpu/drm/imx/ipuv3-plane.c:309:6: warning: symbol 'ipu_plane_destroy_state' was not declared. Should it be static?Signed-off-by Fabio Estevam <[email protected]>
Applied both to imx-drm/fixes, thanks.
regards
Philipp
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel