Skip to contentSkip to conversation

ASoC: wm9712: Use empty struct initializer

PATCH New Fabio Estevam 1 participant 2 messages Feb 13, 2018

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 ASoC: wm9712: Use empty struct initializer

From: Fabio Estevam <[email protected]>

{ 0 } only clears the first member of the structure.

The first member of the snd_soc_dapm_update struct is a pointer, and writing 0 to a pointer results in the following sparse warning:

sound/soc/codecs/wm9712.c:229:47: warning: Using plain integer as NULL pointer

Use the empty struct initializer that clears all the struct members and fixes the sparse warning.

---
Changes since v1:
- Fix typos in commit log

 sound/soc/codecs/wm9712.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/wm9712.c +1 -1
index 7aeeeec..953d94d 100644
@@ -226,7 +226,7 @@ static int wm9712_hp_mixer_put(struct snd_kcontrol *kcontrol,
 	struct soc_mixer_control *mc =
 		(struct soc_mixer_control *)kcontrol->private_value;
 	unsigned int mixer, mask, shift, old;
-	struct snd_soc_dapm_update update = { 0 };
+	struct snd_soc_dapm_update update = {};
 	bool change;
 
 	mixer = mc->shift >> 8;
Signature · 1 line
2.7.4
#1 lore raw

PATCH v2 2/2 ASoC: tlv320aic3x: Use empty struct initializer

From: Fabio Estevam <[email protected]>

{ 0 } only clears the first member of the structure.

The first member of the snd_soc_dapm_update struct is a pointer, and writing 0 to a pointer results in the following sparse warning:

sound/soc/codecs/tlv320aic3x.c:175:47: warning: Using plain integer as NULL pointer

Use the empty struct initializer that clears all the struct members and fixes the sparse warning.

---
Changes since v1:
- Fix typos in commit log

 sound/soc/codecs/tlv320aic3x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/tlv320aic3x.c +1 -1
index dbfa0d8..6a271e6 100644
@@ -172,7 +172,7 @@ static int snd_soc_dapm_put_volsw_aic3x(struct snd_kcontrol *kcontrol,
 	unsigned int mask = (1 << fls(max)) - 1;
 	unsigned int invert = mc->invert;
 	unsigned short val;
-	struct snd_soc_dapm_update update = { 0 };
+	struct snd_soc_dapm_update update = {};
 	int connect, change;
 
 	val = (ucontrol->value.integer.value[0] & mask);
Signature · 1 line
2.7.4