powerpc/eeh: Add conditional check on notify_resume
Subsystems (2)
PATCH 1/1 powerpc/eeh: Add conditional check on notify_resume
From: "Juan J. Alvarez" <[email protected]>
EEH structure is not populated with function notify resume when running on systems that do not support it, i.e: BMC. Hence adding a conditional check for NULL for systems that don't add function notify_resume.
--- arch/powerpc/kernel/eeh_driver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
arch/powerpc/kernel/eeh_driver.c +2 -1
@@ -384,7 +384,8 @@ static void *eeh_report_resume(void *data, void *userdata)eeh_pcid_put (dev);pci_uevent_ers (dev,PCI_ERS_RESULT_RECOVERED );#ifdef CONFIG_PCI_IOV - eeh_ops->notify_resume (eeh_dev_to_pdn (edev)); +if (eeh_ops->notify_resume &&eeh_dev_to_pdn (edev)) + eeh_ops->notify_resume (eeh_dev_to_pdn (edev));#endif return NULL ; }
Signature · 1 line
2.7.2
Quoted 5 lines · Bryant G. Ly
From: "Juan J. Alvarez" <[email protected]>
EEH structure is not populated with function notify resume when running on systems that do not support it, i.e: BMC. Hence adding a conditional check for NULL for
Seems to me that by "BMC" you really mean "powernv platform"?
Quoted 5 lines
systems that don't add function
notify_resume.Signed-off-by Juan J. Alvarez <[email protected]>Reviewed-by Bryant G. Ly <[email protected]>Tested-by Carol L. Soto <[email protected]>
Quoted 19 lines
--- arch/powerpc/kernel/eeh_driver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)arch/powerpc/kernel/eeh_driver.c +2
-1@@ -384,7 +384,8 @@ static void *eeh_report_resume(void *data, void *userdata)eeh_pcid_put (dev);pci_uevent_ers (dev,PCI_ERS_RESULT_RECOVERED );#ifdef CONFIG_PCI_IOV - eeh_ops->notify_resume (eeh_dev_to_pdn (edev)); +if (eeh_ops->notify_resume &&eeh_dev_to_pdn (edev)) + eeh_ops->notify_resume (eeh_dev_to_pdn (edev));#endif return NULL ; }
Signature · 2 lines
Andrew Donnellan OzLabs, ADL Canberra [email protected] IBM Australia Limited
Quoted 10 lines · Bryant G. Ly
From: "Juan J. Alvarez" <[email protected]>
EEH structure is not populated with function notify resume when running on systems that do not support it, i.e: BMC. Hence adding a conditional check for NULL for systems that don't add function
notify_resume.Signed-off-by Juan J. Alvarez <[email protected]>Reviewed-by Bryant G. Ly <[email protected]>Tested-by Carol L. Soto <[email protected]>
Thanks! I was debugging it and I'm glad you proposed a fix already.
Quoted 21 lines
--- arch/powerpc/kernel/eeh_driver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)arch/powerpc/kernel/eeh_driver.c +2
-1@@ -384,7 +384,8 @@ static void *eeh_report_resume(void *data, void *userdata)eeh_pcid_put (dev);pci_uevent_ers (dev,PCI_ERS_RESULT_RECOVERED );#ifdef CONFIG_PCI_IOV - eeh_ops->notify_resume (eeh_dev_to_pdn (edev)); +if (eeh_ops->notify_resume &&eeh_dev_to_pdn (edev)) + eeh_ops->notify_resume (eeh_dev_to_pdn (edev));#endif return NULL ; }Signature · 1 line
2.7.2
Quoted 10 lines · Bryant G. Ly
From: "Juan J. Alvarez" <[email protected]> =20
EEH structure is not populated with function notify resume when running on systems that do not support it, i.e: BMC. Hence adding a conditional check for NULL for systems that don't add functionnotify_resume.
=20Signed-off-by Juan J. Alvarez <[email protected]>Reviewed-by Bryant G. Ly <[email protected]>Tested-by Carol L. Soto <[email protected]>
arch/powerpc/kernel/eeh_driver.c static void *eeh_report_resume(void *data, void *user=
Quoted 10 lines
--- arch/powerpc/kernel/eeh_driver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)=20
arch/powerpc/kernel/eeh_driver.c +0
-0@@ -384,7 +384,8 @@ static void *eeh_report_resume(void *data, void *user=
data)
Quoted 9 lines
arch/powerpc/kernel/eeh_driver.c +2
-1eeh_pcid_put (dev);pci_uevent_ers (dev,PCI_ERS_RESULT_RECOVERED );#ifdef CONFIG_PCI_IOV - eeh_ops->notify_resume (eeh_dev_to_pdn (edev)); +if (eeh_ops->notify_resume &&eeh_dev_to_pdn (edev)) + eeh_ops->notify_resume (eeh_dev_to_pdn (edev));#endif return NULL ; }
Michael Ellerman
AppliedQuoted 7 lines · Bryant G. Ly
From: "Juan J. Alvarez" <[email protected]>
EEH structure is not populated with function notify resume when running on systems that do not support it, i.e: BMC. Hence adding a conditional check for NULL for systems that don't add function
notify_resume.
Quoted 6 lines
Signed-off-by Juan J. Alvarez <[email protected]>Reviewed-by Bryant G. Ly <[email protected]>Tested-by Carol L. Soto <[email protected]>Reviewed-by Andrew Donnellan <[email protected]>Acked-by Michael Neuling <[email protected]>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/521ca5a9859a870e354d1a6b84a6ff
cheers