i40evf: pass struct virtchnl_filter by reference rather than by value
Subsystems (4)
PATCH 1/1 i40evf: pass struct virtchnl_filter by reference rather than by value
From: Colin Ian King <[email protected]>
Passing struct virtchnl_filter f by value requires a 272 byte copy on x86_64, so instead pass it by reference is much more efficient. Also adjust some lines that are over 80 chars.
Detected by CoverityScan, CID#1465285 ("Big parameter passed by value")
--- .../net/ethernet/intel/i40evf/i40evf_virtchnl.c | 32 ++++++++++++---------- 1 file changed, 18 insertions(+), 14 deletions(-)
drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c +18 -14
@@ -1048,24 +1048,28 @@ void i40evf_disable_channels(struct i40evf_adapter *adapter)* Print the cloud filter **/ static void i40evf_print_cloud_filter (struct i40evf_adapter *adapter, -struct virtchnl_filter f) +struct virtchnl_filter *f) { -switch (f.flow_type) { +switch (f->flow_type) {case VIRTCHNL_TCP_V4_FLOW :dev_info (&adapter->pdev->dev,"dst_mac: %pM src_mac: %pM vlan_id: %hu dst_ip: %pI4 src_ip %pI4 dst_port %hu src_port %hu\n" , - &f.data.tcp_spec.dst_mac, &f.data.tcp_spec.src_mac, -ntohs (f.data.tcp_spec.vlan_id), - &f.data.tcp_spec.dst_ip[0 ], &f.data.tcp_spec.src_ip[0 ], -ntohs (f.data.tcp_spec.dst_port), -ntohs (f.data.tcp_spec.src_port)); + &f->data.tcp_spec.dst_mac, + &f->data.tcp_spec.src_mac, +ntohs (f->data.tcp_spec.vlan_id), + &f->data.tcp_spec.dst_ip[0 ], + &f->data.tcp_spec.src_ip[0 ], +ntohs (f->data.tcp_spec.dst_port), +ntohs (f->data.tcp_spec.src_port));break ;case VIRTCHNL_TCP_V6_FLOW :dev_info (&adapter->pdev->dev,"dst_mac: %pM src_mac: %pM vlan_id: %hu dst_ip: %pI6 src_ip %pI6 dst_port %hu src_port %hu\n" , - &f.data.tcp_spec.dst_mac, &f.data.tcp_spec.src_mac, -ntohs (f.data.tcp_spec.vlan_id), - &f.data.tcp_spec.dst_ip, &f.data.tcp_spec.src_ip, -ntohs (f.data.tcp_spec.dst_port), -ntohs (f.data.tcp_spec.src_port)); + &f->data.tcp_spec.dst_mac, + &f->data.tcp_spec.src_mac, +ntohs (f->data.tcp_spec.vlan_id), + &f->data.tcp_spec.dst_ip, + &f->data.tcp_spec.src_ip, +ntohs (f->data.tcp_spec.dst_port), +ntohs (f->data.tcp_spec.src_port));break ; } }
@@ -1303,7 +1307,7 @@ void i40evf_virtchnl_completion(struct i40evf_adapter *adapter,i40evf_stat_str (&adapter->hw, v_retval));i40evf_print_cloud_filter (adapter, - cf->f); + &cf->f);list_del (&cf->list);kfree (cf); adapter->num_cloud_filters--;
@@ -1322,7 +1326,7 @@ void i40evf_virtchnl_completion(struct i40evf_adapter *adapter,i40evf_stat_str (&adapter->hw, v_retval));i40evf_print_cloud_filter (adapter, - cf->f); + &cf->f); } } }
Signature · 1 line
2.15.1
Ramamurthy
PATCH 1/1 i40evf: pass struct virtchnl_filter by reference rather than by value
Quoted 7 lines · Colin King
From: Colin Ian King <[email protected]>
Passing struct
virtchnl_filterf by value requires a 272 byte copy onx86_64, so instead pass it by reference is much more efficient. Also
adjust some lines that are over 80 chars.
Quoted 5 lines
Detected by CoverityScan, CID#1465285 ("Big parameter passed by value")
Signed-off-by Colin Ian King <[email protected]>---
Quoted 91 lines
?.../net/ethernet/intel/i40evf/i40evf_virtchnl.c????| 32
++++++++++++----------
?1 file changed, 18 insertions(+), 14 deletions(-)drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c +0
-0@@ -1048,24 +1048,28 @@ void i40evf_disable_channels(struct i40evf_adapter *adapter)? * Print the cloud filter
? **/
?static void i40evf_print_cloud_filter(structi40evf_adapter*adapter,drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c +1
-1- ??????struct virtchnl_filter f) + ??????struct virtchnl_filter *f)?{
drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c +1
-1-switch (f.flow_type) { +switch (f->flow_type) {? case
VIRTCHNL_TCP_V4_FLOW:
? dev_info(&adapter->pdev->dev, "dst_mac: %pMsrc_mac:
%pMvlan_id: %hudst_ip: %pI4src_ip%pI4dst_port%husrc_port%hu\n",drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c +0
-1- ?&f.data.tcp_spec.dst_mac,&f.data.tcp_spec.src_mac,
drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c +0
-2- ?ntohs(f.data.tcp_spec.vlan_id), - ?&f.data.tcp_spec.dst_ip[0],&f.data.tcp_spec.src_ip[0],
drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c +7
-2- ?ntohs(f.data.tcp_spec.dst_port), - ?ntohs(f.data.tcp_spec.src_port)); + ?&f->data.tcp_spec.dst_mac, + ?&f->data.tcp_spec.src_mac, + ?ntohs(f->data.tcp_spec.vlan_id), + ?&f->data.tcp_spec.dst_ip[0], + ?&f->data.tcp_spec.src_ip[0], + ?ntohs(f->data.tcp_spec.dst_port), + ?ntohs(f->data.tcp_spec.src_port));? break;
? caseVIRTCHNL_TCP_V6_FLOW:
? dev_info(&adapter->pdev->dev, "dst_mac: %pMsrc_mac:
%pMvlan_id: %hudst_ip: %pI6src_ip%pI6dst_port%husrc_port%hu\n",drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c +0
-1- ?&f.data.tcp_spec.dst_mac,&f.data.tcp_spec.src_mac,
drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c +0
-2- ?ntohs(f.data.tcp_spec.vlan_id), - ?&f.data.tcp_spec.dst_ip,&f.data.tcp_spec.src_ip,
drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c +7
-2- ?ntohs(f.data.tcp_spec.dst_port), - ?ntohs(f.data.tcp_spec.src_port)); + ?&f->data.tcp_spec.dst_mac, + ?&f->data.tcp_spec.src_mac, + ?ntohs(f->data.tcp_spec.vlan_id), + ?&f->data.tcp_spec.dst_ip, + ?&f->data.tcp_spec.src_ip, + ?ntohs(f->data.tcp_spec.dst_port), + ?ntohs(f->data.tcp_spec.src_port));? break;
? }
?}drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c +0
-0@@ -1303,7 +1307,7 @@ void i40evf_virtchnl_completion(struct i40evf_adapter *adapter,? ?i40evf_stat_str(&ad
apter->hw,
? ?v_r
etval));
? i40evf_print_cloud_filter(ad
apter,drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c +1
-2- ??cf ->f); + ??&c
f->f);
?list_del(&cf->list);
? kfree(cf);
?adapter->num_cloud_filters
--;drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c +0
-0@@ -1322,7 +1326,7 @@ void i40evf_virtchnl_completion(struct i40evf_adapter *adapter,? ?i40evf_stat_str(&ad
apter->hw,
? ?v_r
etval));
? i40evf_print_cloud_filter(ad
apter,drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c +1
-2- ??cf ->f); + ??&c
f->f);
? }
? }
? }
Bowers
PATCH 1/1 i40evf: pass struct virtchnl_filter by reference rather than by value
In reply to Colin KingQuoted 16 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Colin King
Sent: Thursday, February 15, 2018 11:26 AM
To: Kirsher, Jeffrey T <[email protected]>; intel-wired- lan at lists.osuosl.org; netdev at vger.kernel.org
Cc: kernel-janitors at vger.kernel.org; linux-kernel at vger.kernel.org
Subject: [Intel-wired-lan] [PATCH] i40evf: pass structvirtchnl_filterby reference rather than by valueFrom: Colin Ian King <[email protected]>
Passing struct
virtchnl_filterf by value requires a 272 byte copy onx86_64, so instead pass it by reference is much more efficient. Also adjust some lines that are over 80 chars.
Quoted 6 lines
Detected by CoverityScan, CID#1465285 ("Big parameter passed by value")
Signed-off-by Colin Ian King <[email protected]>--- .../net/ethernet/intel/i40evf/i40evf_virtchnl.c | 32 ++++++++++++---------- 1 file changed, 18 insertions(+), 14 deletions(-)