ARM: dts: aspeed: Enable iBT and LPC, Palmetto fixes
Subsystems (2)
Joel Stanley
maintainercover ARM: dts: aspeed: Enable iBT and LPC, Palmetto fixes
Hello,
These changes enable recently (and not-so-recently) upstreamed drivers for the ASPEED BMC device trees.
Palmetto also has some updates that bring it close to being able to boot a host with an upstream kernel.
I will merge them through the ASPEED tree once they have been reviewed.
Joel Stanley (6):
ARM: dts: aspeed: Add IPMI BT node
ARM: dts: aspeed: Enable IPMI BT node on OpenPower machines
ARM: dts: aspeed-g5: Update LPC node
ARM: dts: aspeed: Add LPC clock phandles
ARM: dts: palmetto: Add LEDs and GPIO keys
ARM: dts: aspeed: Add Palmetto GPIO hogs
arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts | 188 +++++++++++++++++++++++ arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 4 + arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 4 + arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts | 4 + arch/arm/boot/dts/aspeed-g4.dtsi | 8 + arch/arm/boot/dts/aspeed-g5.dtsi | 15 +- 6 files changed, 219 insertions(+), 4 deletions(-)
Signature · 1 line
2.15.1
Joel Stanley
maintainerPATCH 1/6 ARM: dts: aspeed: Add IPMI BT node
The IPMI BT device part of the LPC interface and is used for communication with the host processor.
--- arch/arm/boot/dts/aspeed-g4.dtsi | 7 +++++++ arch/arm/boot/dts/aspeed-g5.dtsi | 7 +++++++ 2 files changed, 14 insertions(+)
arch/arm/boot/dts/aspeed-g4.dtsi +7 -0
@@ -247,6 +247,13 @@ compatible = "aspeed,ast2400-lhc"; reg = <0x20 0x24 0x48 0x8>; }; + + ibt: ibt at c0 { + compatible = "aspeed,ast2400-ibt-bmc"; + reg = <0xc0 0x18>; + interrupts = <8>; + status = "disabled"; + }; }; };
arch/arm/boot/dts/aspeed-g5.dtsi +7 -0
@@ -298,6 +298,13 @@ compatible = "aspeed,ast2500-lhc"; reg = <0x20 0x24 0x48 0x8>; }; + + ibt: ibt at c0 { + compatible = "aspeed,ast2500-ibt-bmc"; + reg = <0xc0 0x18>; + interrupts = <8>; + status = "disabled"; + }; }; };
Signature · 1 line
2.15.1
Joel Stanley
maintainerPATCH 2/6 ARM: dts: aspeed: Enable IPMI BT node on OpenPower machines
In reply to Joel StanleyThese BMC systems require this device to communicate with the host.
--- arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts | 4 ++++ arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 4 ++++ arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 4 ++++ arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts | 4 ++++ 4 files changed, 16 insertions(+)
arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts +4 -0
@@ -111,3 +111,7 @@ &vuart { status = "okay"; }; + +&ibt { + status = "okay"; +};
arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts +4 -0
@@ -257,3 +257,7 @@ aspeed,fan-tach-ch = /bits/ 8 <0x0e>; }; }; + +&ibt { + status = "okay"; +};
arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts +4 -0
@@ -546,3 +546,7 @@ pinctrl-names = "default"; pinctrl-0 = <&pinctrl_wdtrst1_default>; }; + +&ibt { + status = "okay"; +};
arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts +4 -0
@@ -424,3 +424,7 @@ aspeed,fan-tach-ch = /bits/ 8 <0x03>; }; }; + +&ibt { + status = "okay"; +};
Signature · 1 line
2.15.1
Joel Stanley
maintainerPATCH 3/6 ARM: dts: aspeed-g5: Update LPC node
In reply to Joel StanleyThis addresses some differences between the G5 and G4 LPC nodes that make them hard to compare. There is no functional change.
--- arch/arm/boot/dts/aspeed-g5.dtsi | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
arch/arm/boot/dts/aspeed-g5.dtsi +3 -4
@@ -264,7 +264,7 @@ #address-cells = <1>; #size-cells = <1>; - ranges = <0 0x1e789000 0x1000>; + ranges = <0x0 0x1e789000 0x1000>; lpc_bmc: lpc-bmc at 0 { compatible = "aspeed,ast2500-lpc-bmc";
@@ -274,12 +274,11 @@ lpc_host: lpc-host at 80 { compatible = "aspeed,ast2500-lpc-host", "simple-mfd", "syscon"; reg = <0x80 0x1e0>; + reg-io-width = <4>; #address-cells = <1>; #size-cells = <1>; - ranges = <0 0x80 0x1e0>; - - reg-io-width = <4>; + ranges = <0x0 0x80 0x1e0>; lpc_ctrl: lpc-ctrl at 0 { compatible = "aspeed,ast2500-lpc-ctrl";
Signature · 1 line
2.15.1
PATCH 3/6 ARM: dts: aspeed-g5: Update LPC node
Quoted 4 lines · Joel Stanley
This addresses some differences between the G5 and G4 LPC nodes that make them hard to compare. There is no functional change.
Signed-off-by Joel Stanley <[email protected]>
Quoted 22 lines
--- arch/arm/boot/dts/aspeed-g5.dtsi | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)arch/arm/boot/dts/aspeed-g5.dtsi +2
-1@@ -264,7 +264,7 @@ #address-cells = <1>; #size-cells = <1>; - ranges = <0 0x1e789000 0x1000>; + ranges = <0x0 0x1e789000 0x1000>; lpc_bmc: lpc-bmc at 0 { compatible = "aspeed,ast2500-lpc-bmc";@@ -274,12 +274,11 @@ lpc_host: lpc-host at 80 { compatible = "aspeed,ast2500-lpc-host", "simple-mfd", "syscon"; reg = <0x80 0x1e0>; + reg-io-width = <4>;
arch/arm/boot/dts/aspeed-g5.dtsi line 284
Quoted 10 lines
arch/arm/boot/dts/aspeed-g5.dtsi +1
-3#address-cells = <1>; #size-cells = <1>; - ranges = <0 0x80 0x1e0>; - - reg-io-width = <4>; + ranges = <0x0 0x80 0x1e0>; lpc_ctrl: lpc-ctrl at 0 { compatible = "aspeed,ast2500-lpc-ctrl";
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180216/9d534d0f/attachment.sig>
Joel Stanley
maintainerPATCH 4/6 ARM: dts: aspeed: Add LPC clock phandles
In reply to Joel StanleyThe LPC device uses LCLK.
--- arch/arm/boot/dts/aspeed-g4.dtsi | 1 + arch/arm/boot/dts/aspeed-g5.dtsi | 1 + 2 files changed, 2 insertions(+)
arch/arm/boot/dts/aspeed-g4.dtsi +1 -0
@@ -233,6 +233,7 @@ lpc_ctrl: lpc-ctrl at 0 { compatible = "aspeed,ast2400-lpc-ctrl"; reg = <0x0 0x80>; + clocks = <&syscon ASPEED_CLK_GATE_LCLK>; status = "disabled"; };
arch/arm/boot/dts/aspeed-g5.dtsi +1 -0
@@ -283,6 +283,7 @@ lpc_ctrl: lpc-ctrl at 0 { compatible = "aspeed,ast2500-lpc-ctrl"; reg = <0x0 0x80>; + clocks = <&syscon ASPEED_CLK_GATE_LCLK>; status = "disabled"; };
Signature · 1 line
2.15.1
Joel Stanley
maintainerPATCH 5/6 ARM: dts: palmetto: Add LEDs and GPIO keys
In reply to Joel StanleyThese describe the front panel LEDs that are present on a Palmetto chassis, and the checkstop GPIO that comes from the Power8 CPU to indicate a host error.
--- arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+)
arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts +27 -0
@@ -2,6 +2,7 @@ /dts-v1/; #include "aspeed-g4.dtsi" +#include <dt-bindings/gpio/aspeed-gpio.h> / { model = "Palmetto BMC";
@@ -26,6 +27,32 @@ reg = <0x5f000000 0x01000000>; /* 16M */ }; }; + + leds { + compatible = "gpio-leds"; + + heartbeat { + gpios = <&gpio ASPEED_GPIO(R, 4) GPIO_ACTIVE_LOW>; + }; + + power { + gpios = <&gpio ASPEED_GPIO(R, 5) GPIO_ACTIVE_LOW>; + }; + + identify { + gpios = <&gpio ASPEED_GPIO(A, 2) GPIO_ACTIVE_LOW>; + }; + }; + + gpio-keys { + compatible = "gpio-keys"; + + checkstop { + label = "checkstop"; + gpios = <&gpio ASPEED_GPIO(P, 5) GPIO_ACTIVE_LOW>; + linux,code = <ASPEED_GPIO(P, 5)>; + }; + }; }; &fmc {
Signature · 1 line
2.15.1
PATCH 5/6 ARM: dts: palmetto: Add LEDs and GPIO keys
Quoted 5 lines · Joel Stanley
These describe the front panel LEDs that are present on a Palmetto chassis, and the checkstop GPIO that comes from the Power8 CPU to indicate a host error.
Signed-off-by Joel Stanley <[email protected]>
Quoted 39 lines
--- arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+)arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts +20
-0@@ -2,6 +2,7 @@ /dts-v1/; #include "aspeed-g4.dtsi" +#include <dt-bindings/gpio/aspeed-gpio.h> / { model = "Palmetto BMC";@@ -26,6 +27,32 @@ reg = <0x5f000000 0x01000000>; /* 16M */ }; }; + + leds { + compatible = "gpio-leds"; + + heartbeat { + gpios = <&gpio ASPEED_GPIO(R, 4) GPIO_ACTIVE_LOW>; + }; + + power { + gpios = <&gpio ASPEED_GPIO(R, 5) GPIO_ACTIVE_LOW>; + }; + + identify { + gpios = <&gpio ASPEED_GPIO(A, 2) GPIO_ACTIVE_LOW>; + }; + }; + + gpio-keys { + compatible = "gpio-keys";
arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts line 58
Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts +7
-0+ + checkstop { + label = "checkstop"; + gpios = <&gpio ASPEED_GPIO(P, 5) GPIO_ACTIVE_LOW>; + linux,code = <ASPEED_GPIO(P, 5)>; + }; + }; }; &fmc {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180216/065ee769/attachment.sig>
Joel Stanley
maintainerPATCH 6/6 ARM: dts: aspeed: Add Palmetto GPIO hogs
In reply to Joel StanleyThese hogs are for parts of the system that need to be in this state, but do not yet have a driver associated with them but they must be configured in order to successfully boot the host.
There are also some pinmux hogs, where the default mode of the IP block is configured.
--- arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts | 157 ++++++++++++++++++++++++++ 1 file changed, 157 insertions(+)
arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts +157 -0
@@ -74,6 +74,14 @@ }; }; +&pinctrl { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_flbusy_default &pinctrl_flwp_default + + &pinctrl_vgahs_default &pinctrl_vgavs_default + &pinctrl_ddcclk_default &pinctrl_ddcdat_default>; +}; + &uart5 { status = "okay"; };
@@ -142,3 +150,152 @@ &ibt { status = "okay"; }; + +&gpio { + pin_func_mode0 { + gpio-hog; + gpios = <ASPEED_GPIO(C, 4) GPIO_ACTIVE_HIGH>; + output-low; + line-name = "func_mode0"; + }; + + pin_func_mode1 { + gpio-hog; + gpios = <ASPEED_GPIO(C, 5) GPIO_ACTIVE_HIGH>; + output-low; + line-name = "func_mode1"; + }; + + pin_func_mode2 { + gpio-hog; + gpios = <ASPEED_GPIO(C, 6) GPIO_ACTIVE_HIGH>; + output-low; + line-name = "func_mode2"; + }; + + pin_gpio_a0 { + gpio-hog; + gpios = <ASPEED_GPIO(A, 0) GPIO_ACTIVE_HIGH>; + input; + line-name = "BMC_FAN_RESERVED_N"; + }; + + pin_gpio_a1 { + gpio-hog; + gpios = <ASPEED_GPIO(A, 1) GPIO_ACTIVE_HIGH>; + output-high; + line-name = "APSS_WDT_N"; + }; + + pin_gpio_b1 { + gpio-hog; + gpios = <ASPEED_GPIO(B, 1) GPIO_ACTIVE_HIGH>; + output-high; + line-name = "APSS_BOOT_MODE"; + }; + + pin_gpio_b2 { + gpio-hog; + gpios = <ASPEED_GPIO(B, 2) GPIO_ACTIVE_HIGH>; + output-high; + line-name = "APSS_RESET_N"; + }; + + pin_gpio_b7 { + gpio-hog; + gpios = <ASPEED_GPIO(B, 7) GPIO_ACTIVE_HIGH>; + output-high; + line-name = "SPIVID_STBY_RESET_N"; + }; + + pin_gpio_d1 { + gpio-hog; + gpios = <ASPEED_GPIO(D, 1) GPIO_ACTIVE_HIGH>; + output-high; + line-name = "BMC_POWER_UP"; + }; + + pin_gpio_f1 { + gpio-hog; + gpios = <ASPEED_GPIO(F, 1) GPIO_ACTIVE_HIGH>; + input; + line-name = "BMC_BATTERY_TEST"; + }; + + pin_gpio_f4 { + gpio-hog; + gpios = <ASPEED_GPIO(F, 4) GPIO_ACTIVE_HIGH>; + input; + line-name = "AST_HW_FAULT_N"; + }; + + pin_gpio_f5 { + gpio-hog; + gpios = <ASPEED_GPIO(F, 5) GPIO_ACTIVE_HIGH>; + input; + line-name = "AST_SYS_FAULT_N"; + }; + + pin_gpio_f7 { + gpio-hog; + gpios = <ASPEED_GPIO(F, 7) GPIO_ACTIVE_HIGH>; + output-high; + line-name = "BMC_FULL_SPEED_N"; + }; + + pin_gpio_g3 { + gpio-hog; + gpios = <ASPEED_GPIO(G, 3) GPIO_ACTIVE_HIGH>; + output-high; + line-name = "BMC_FAN_ERROR_N"; + }; + + pin_gpio_g4 { + gpio-hog; + gpios = <ASPEED_GPIO(G, 4) GPIO_ACTIVE_HIGH>; + input; + line-name = "BMC_WDT_RST1_P"; + }; + + pin_gpio_g5 { + gpio-hog; + gpios = <ASPEED_GPIO(G, 5) GPIO_ACTIVE_HIGH>; + input; + line-name = "BMC_WDT_RST2_P"; + }; + + pin_gpio_h0 { + gpio-hog; + gpios = <ASPEED_GPIO(H, 0) GPIO_ACTIVE_HIGH>; + input; + line-name = "PE_SLOT_TEST_EN_N"; + }; + + pin_gpio_h1 { + gpio-hog; + gpios = <ASPEED_GPIO(H, 1) GPIO_ACTIVE_HIGH>; + input; + line-name = "BMC_RTCRST_N"; + }; + + pin_gpio_h2 { + gpio-hog; + gpios = <ASPEED_GPIO(H, 2) GPIO_ACTIVE_HIGH>; + output-high; + line-name = "SYS_PWROK_BMC"; + }; + + pin_gpio_h6 { + gpio-hog; + gpios = <ASPEED_GPIO(H, 6) GPIO_ACTIVE_HIGH>; + output-high; + line-name = "SCM1_FSI0_DATA_EN"; + }; + + pin_gpio_h7 { + gpio-hog; + gpios = <ASPEED_GPIO(H, 7) GPIO_ACTIVE_HIGH>; + output-high; + line-name = "BMC_TPM_INT_N"; + }; +};
Signature · 1 line
2.15.1
PATCH 6/6 ARM: dts: aspeed: Add Palmetto GPIO hogs
Quoted 8 lines · Joel Stanley
These hogs are for parts of the system that need to be in this state, but do not yet have a driver associated with them but they must be configured in order to successfully boot the host.
There are also some pinmux hogs, where the default mode of the IP block is configured.
Signed-off-by Joel Stanley <[email protected]>
Quoted 166 lines
--- arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts | 157 ++++++++++++++++++++++++++ 1 file changed, 157 insertions(+)arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts +147
-0@@ -74,6 +74,14 @@ }; }; +&pinctrl { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_flbusy_default &pinctrl_flwp_default + + &pinctrl_vgahs_default &pinctrl_vgavs_default + &pinctrl_ddcclk_default &pinctrl_ddcdat_default>; +}; + &uart5 { status = "okay"; };@@ -142,3 +150,152 @@ &ibt { status = "okay"; }; + +&gpio { + pin_func_mode0 { + gpio-hog; + gpios = <ASPEED_GPIO(C, 4) GPIO_ACTIVE_HIGH>; + output-low; + line-name = "func_mode0"; + }; + + pin_func_mode1 { + gpio-hog; + gpios = <ASPEED_GPIO(C, 5) GPIO_ACTIVE_HIGH>; + output-low; + line-name = "func_mode1"; + }; + + pin_func_mode2 { + gpio-hog; + gpios = <ASPEED_GPIO(C, 6) GPIO_ACTIVE_HIGH>; + output-low; + line-name = "func_mode2"; + }; + + pin_gpio_a0 { + gpio-hog; + gpios = <ASPEED_GPIO(A, 0) GPIO_ACTIVE_HIGH>; + input; + line-name = "BMC_FAN_RESERVED_N"; + }; + + pin_gpio_a1 { + gpio-hog; + gpios = <ASPEED_GPIO(A, 1) GPIO_ACTIVE_HIGH>; + output-high; + line-name = "APSS_WDT_N"; + }; + + pin_gpio_b1 { + gpio-hog; + gpios = <ASPEED_GPIO(B, 1) GPIO_ACTIVE_HIGH>; + output-high; + line-name = "APSS_BOOT_MODE"; + }; + + pin_gpio_b2 { + gpio-hog; + gpios = <ASPEED_GPIO(B, 2) GPIO_ACTIVE_HIGH>; + output-high; + line-name = "APSS_RESET_N"; + }; + + pin_gpio_b7 { + gpio-hog; + gpios = <ASPEED_GPIO(B, 7) GPIO_ACTIVE_HIGH>; + output-high; + line-name = "SPIVID_STBY_RESET_N"; + }; + + pin_gpio_d1 { + gpio-hog; + gpios = <ASPEED_GPIO(D, 1) GPIO_ACTIVE_HIGH>; + output-high; + line-name = "BMC_POWER_UP"; + }; + + pin_gpio_f1 { + gpio-hog; + gpios = <ASPEED_GPIO(F, 1) GPIO_ACTIVE_HIGH>; + input; + line-name = "BMC_BATTERY_TEST"; + }; + + pin_gpio_f4 { + gpio-hog; + gpios = <ASPEED_GPIO(F, 4) GPIO_ACTIVE_HIGH>; + input; + line-name = "AST_HW_FAULT_N"; + }; + + pin_gpio_f5 { + gpio-hog; + gpios = <ASPEED_GPIO(F, 5) GPIO_ACTIVE_HIGH>; + input; + line-name = "AST_SYS_FAULT_N"; + }; + + pin_gpio_f7 { + gpio-hog; + gpios = <ASPEED_GPIO(F, 7) GPIO_ACTIVE_HIGH>; + output-high; + line-name = "BMC_FULL_SPEED_N"; + }; + + pin_gpio_g3 { + gpio-hog; + gpios = <ASPEED_GPIO(G, 3) GPIO_ACTIVE_HIGH>; + output-high; + line-name = "BMC_FAN_ERROR_N"; + }; + + pin_gpio_g4 { + gpio-hog; + gpios = <ASPEED_GPIO(G, 4) GPIO_ACTIVE_HIGH>; + input; + line-name = "BMC_WDT_RST1_P"; + }; + + pin_gpio_g5 { + gpio-hog; + gpios = <ASPEED_GPIO(G, 5) GPIO_ACTIVE_HIGH>; + input; + line-name = "BMC_WDT_RST2_P"; + }; + + pin_gpio_h0 { + gpio-hog; + gpios = <ASPEED_GPIO(H, 0) GPIO_ACTIVE_HIGH>; + input; + line-name = "PE_SLOT_TEST_EN_N"; + }; + + pin_gpio_h1 { + gpio-hog; + gpios = <ASPEED_GPIO(H, 1) GPIO_ACTIVE_HIGH>; + input; + line-name = "BMC_RTCRST_N"; + }; + + pin_gpio_h2 { + gpio-hog; + gpios = <ASPEED_GPIO(H, 2) GPIO_ACTIVE_HIGH>; + output-high; + line-name = "SYS_PWROK_BMC"; + }; + + pin_gpio_h6 { + gpio-hog; + gpios = <ASPEED_GPIO(H, 6) GPIO_ACTIVE_HIGH>; + output-high;
arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts line 301
Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts +10
-0+ line-name = "SCM1_FSI0_DATA_EN"; + }; + + pin_gpio_h7 { + gpio-hog; + gpios = <ASPEED_GPIO(H, 7) GPIO_ACTIVE_HIGH>; + output-high; + line-name = "BMC_TPM_INT_N"; + }; +};
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180216/31d61e47/attachment.sig>
Joel Stanley
maintainercover ARM: dts: aspeed: Enable iBT and LPC, Palmetto fixes
In reply to Joel StanleyQuoted 10 lines · Joel Stanley
Hello,
These changes enable recently (and not-so-recently) upstreamed drivers for the ASPEED BMC device trees.
Palmetto also has some updates that bring it close to being able to boot a host with an upstream kernel.
I will merge them through the ASPEED tree once they have been reviewed.
Quoted 7 lines
Joel Stanley (6):
ARM: dts: aspeed: Add IPMI BT node
ARM: dts: aspeed: Enable IPMI BT node on OpenPower machines
ARM: dts: aspeed-g5: Update LPC node
ARM: dts: aspeed: Add LPC clock phandles
ARM: dts: palmetto: Add LEDs and GPIO keys
ARM: dts: aspeed: Add Palmetto GPIO hogs
Series merged to dt-for-4.17 in the aspeed tree. Thanks for the reviews Andrew.
Cheers,
Joel