Skip to contentSkip to conversation

spi: Moved spi u-bbot headers to Kconfig

PATCH Superseded Vipul Kumar 2 participants 5 messages Feb 16, 2018 – Feb 26, 2018

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover spi: Moved spi u-bbot headers to Kconfig

This seris of patch moved spi headers to Kconfig.
These are the configs:
-CONFIG_SYS_ZYNQ_SPI_WAIT
-CONFIG_XILINX_SPI_IDLE_VAL
-CONFIG_SYS_ZYNQ_QSPI_WAIT

Vipul Kumar (2):
qspi: Added Kconfig support for CONFIG_SYS_ZYNQ_QSPI_WAIT
spi: Added Kconfig support for SYS_ZYNQ_SPI_WAIT and
XILINX_SPI_IDLE_VAL

 drivers/spi/Kconfig      | 18 ++++++++++++++++++
 drivers/spi/xilinx_spi.c |  4 ----
 drivers/spi/zynq_qspi.c  |  3 ---
 drivers/spi/zynq_spi.c   |  3 ---
 4 files changed, 18 insertions(+), 10 deletions(-)

--
2.7.4

This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.

#1 lore raw

PATCH 1/2 qspi: Added Kconfig support for CONFIG_SYS_ZYNQ_QSPI_WAIT

This patch added Kconfig support for CONFIG_SYS_ZYNQ_QSPI_WAIT and set it to default value 10 milliseconds.

---
 drivers/spi/Kconfig     | 6 ++++++
 drivers/spi/zynq_qspi.c | 3 ---
 2 files changed, 6 insertions(+), 3 deletions(-)
drivers/spi/Kconfig +6 -0
index 235a8c7..436e9ad 100644
@@ -204,6 +204,12 @@ config ZYNQ_QSPI
          Zynq QSPI IP core. This IP is used to connect the flash in
          4-bit qspi, 8-bit dual stacked and shared 4-bit dual parallel.
 
+config SYS_ZYNQ_QSPI_WAIT
+       int "Define Zynq QSPI wait time in ms"
+       default 10
+       help
+         Define default Zynq QSPI wait time in milliseconds.
+
 endif # if DM_SPI
 
 config SOFT_SPI
drivers/spi/zynq_qspi.c +0 -3
index 255e02f..c9241aa 100644
@@ -46,9 +46,6 @@ DECLARE_GLOBAL_DATA_PTR;
 #define ZYNQ_QSPI_CR_SS_SHIFT          10      /* Slave select shift */
 
 #define ZYNQ_QSPI_FIFO_DEPTH           63
-#ifndef CONFIG_SYS_ZYNQ_QSPI_WAIT
-#define CONFIG_SYS_ZYNQ_QSPI_WAIT      CONFIG_SYS_HZ/100       /* 10 ms */
-#endif
 
 /* zynq qspi register set */
 struct zynq_qspi_regs {

--
2.7.4

This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.

#2 lore raw

PATCH 1/2 qspi: Added Kconfig support for CONFIG_SYS_ZYNQ_QSPI_WAIT

Quoted 15 lines · Vipul Kumar

This patch added Kconfig support for CONFIG_SYS_ZYNQ_QSPI_WAIT and set it to default value 10 milliseconds.

---
 drivers/spi/Kconfig     | 6 ++++++
 drivers/spi/zynq_qspi.c | 3 ---
 2 files changed, 6 insertions(+), 3 deletions(-)
drivers/spi/Kconfig +0 -0
index 235a8c7..436e9ad 100644

drivers/spi/Kconfig config ZYNQ_QSPI · line 208

Quoted 5 lines
drivers/spi/Kconfig +2 -0
@@ -204,6 +204,12 @@ config ZYNQ_QSPI
 	  Zynq QSPI IP core. This IP is used to connect the flash in
 	  4-bit qspi, 8-bit dual stacked and shared 4-bit dual parallel.
 
+config SYS_ZYNQ_QSPI_WAIT
+	int "Define Zynq QSPI wait time in ms"

here I am missing depends on ZYNQ_QSPI.

M

Quoted 22 lines
drivers/spi/Kconfig +4 -0
+	default 10
+	help
+	  Define default Zynq QSPI wait time in milliseconds.
+
 endif # if DM_SPI
 
 config SOFT_SPI
drivers/spi/zynq_qspi.c +0 -3
index 255e02f..c9241aa 100644
@@ -46,9 +46,6 @@ DECLARE_GLOBAL_DATA_PTR;
 #define ZYNQ_QSPI_CR_SS_SHIFT		10	/* Slave select shift */
 
 #define ZYNQ_QSPI_FIFO_DEPTH		63
-#ifndef CONFIG_SYS_ZYNQ_QSPI_WAIT
-#define CONFIG_SYS_ZYNQ_QSPI_WAIT	CONFIG_SYS_HZ/100	/* 10 ms */
-#endif
 
 /* zynq qspi register set */
 struct zynq_qspi_regs {
#3 lore raw

PATCH 2/2 spi: Added Kconfig support for SYS_ZYNQ_SPI_WAIT and XILINX_SPI_IDLE_VAL

In reply to Vipul Kumar

This patch added Kconfig support for CONFIG_SYS_ZYNQ_SPI_WAIT and CONFIG_XILINX_SPI_IDLE_VAL and set default value.

---
 drivers/spi/Kconfig      | 12 ++++++++++++
 drivers/spi/xilinx_spi.c |  4 ----
 drivers/spi/zynq_spi.c   |  3 ---
 3 files changed, 12 insertions(+), 7 deletions(-)
drivers/spi/Kconfig +12 -0
index 436e9ad..bcb28cf 100644
@@ -210,6 +210,18 @@ config SYS_ZYNQ_QSPI_WAIT
        help
          Define default Zynq QSPI wait time in milliseconds.
 
+config SYS_ZYNQ_SPI_WAIT
+       int "Define Zynq SPI wait time in ms"
+       default 10
+       help
+         Define default Zynq SPI wait time in milliseconds.
+
+config XILINX_SPI_IDLE_VAL
+       hex "Define the default SPI idle value"
+       default 0xFFFFFFFF
+       help
+         Set the default SPI idle value.
+
 endif # if DM_SPI
 
 config SOFT_SPI
drivers/spi/xilinx_spi.c +0 -4
index a951a77..9781ea9 100644
@@ -74,10 +74,6 @@
                                SPICR_SPE)
 #define XILSPI_SPICR_DFLT_OFF  (SPICR_MASTER_INHIBIT | SPICR_MANUAL_SS)
 
-#ifndef CONFIG_XILINX_SPI_IDLE_VAL
-#define CONFIG_XILINX_SPI_IDLE_VAL     GENMASK(7, 0)
-#endif
-
 #ifndef CONFIG_SYS_XILINX_SPI_LIST
 #define CONFIG_SYS_XILINX_SPI_LIST     { CONFIG_SYS_SPI_BASE }
 #endif
drivers/spi/zynq_spi.c +0 -3
index ed2b8cb..be8f525 100644
@@ -33,9 +33,6 @@ DECLARE_GLOBAL_DATA_PTR;
 #define ZYNQ_SPI_CR_SS_SHIFT           10      /* Slave select shift */
 
 #define ZYNQ_SPI_FIFO_DEPTH            128
-#ifndef CONFIG_SYS_ZYNQ_SPI_WAIT
-#define CONFIG_SYS_ZYNQ_SPI_WAIT       (CONFIG_SYS_HZ/100)     /* 10 ms */
-#endif
 
 /* zynq spi register set */
 struct zynq_spi_regs {

--
2.7.4

This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.

#4 lore raw

PATCH 2/2 spi: Added Kconfig support for SYS_ZYNQ_SPI_WAIT and XILINX_SPI_IDLE_VAL

Quoted 16 lines · Vipul Kumar

This patch added Kconfig support for CONFIG_SYS_ZYNQ_SPI_WAIT and CONFIG_XILINX_SPI_IDLE_VAL and set default value.

---
 drivers/spi/Kconfig      | 12 ++++++++++++
 drivers/spi/xilinx_spi.c |  4 ----
 drivers/spi/zynq_spi.c   |  3 ---
 3 files changed, 12 insertions(+), 7 deletions(-)
drivers/spi/Kconfig +0 -0
index 436e9ad..bcb28cf 100644

drivers/spi/Kconfig config SYS_ZYNQ_QSPI_WAIT · line 214

Quoted 5 lines
drivers/spi/Kconfig +2 -0
@@ -210,6 +210,18 @@ config SYS_ZYNQ_QSPI_WAIT
 	help
 	  Define default Zynq QSPI wait time in milliseconds.
 
+config SYS_ZYNQ_SPI_WAIT
+	int "Define Zynq SPI wait time in ms"

The same here - add depends on XILINX_SPI.

M

Quoted 43 lines
drivers/spi/Kconfig +10 -0
+	default 10
+	help
+	  Define default Zynq SPI wait time in milliseconds.
+
+config XILINX_SPI_IDLE_VAL
+	hex "Define the default SPI idle value"
+	default 0xFFFFFFFF
+	help
+	  Set the default SPI idle value.
+
 endif # if DM_SPI
 
 config SOFT_SPI
drivers/spi/xilinx_spi.c +0 -4
index a951a77..9781ea9 100644
@@ -74,10 +74,6 @@
 				SPICR_SPE)
 #define XILSPI_SPICR_DFLT_OFF	(SPICR_MASTER_INHIBIT | SPICR_MANUAL_SS)
 
-#ifndef CONFIG_XILINX_SPI_IDLE_VAL
-#define CONFIG_XILINX_SPI_IDLE_VAL	GENMASK(7, 0)
-#endif
-
 #ifndef CONFIG_SYS_XILINX_SPI_LIST
 #define CONFIG_SYS_XILINX_SPI_LIST	{ CONFIG_SYS_SPI_BASE }
 #endif
drivers/spi/zynq_spi.c +0 -3
index ed2b8cb..be8f525 100644
@@ -33,9 +33,6 @@ DECLARE_GLOBAL_DATA_PTR;
 #define ZYNQ_SPI_CR_SS_SHIFT		10	/* Slave select shift */
 
 #define ZYNQ_SPI_FIFO_DEPTH		128
-#ifndef CONFIG_SYS_ZYNQ_SPI_WAIT
-#define CONFIG_SYS_ZYNQ_SPI_WAIT	(CONFIG_SYS_HZ/100)	/* 10 ms */
-#endif
 
 /* zynq spi register set */
 struct zynq_spi_regs {