Skip to contentSkip to conversation

Replace printk statements with pr_*macros

PATCH In review Shreeya Patel 6 participants 26 messages Feb 16, 2018 – Feb 18, 2018 3 messages not in the archive

Subsystems (3)
Arm i.MX and Layerscape Memory technology devices (MTD) NAND flash
lore
Share & tools
lore

Shreeya Patel

author
#0 lore raw

cover Replace printk statements with pr_*macros

This patchset removes all the log levels i.e. KERN_WARN, KERN_NOTICE, KERN_ERR, KERN_INFO, KERN_DEBUG used in the printk statements and replaces the printk statements with appropriate pr_*macros.
According to the kernel coding style, pr_*macro is the preferred way to print the message.

Shreeya Patel (5):
mtd/nand: Replace printk with pr_warn
mtd/nand: Replace printk with pr_notice
mtd/nand: Replace printk with pr_err
mtd/nand: Replace printk with pr_info
mtd/nand: Replace printk with pr_debug

 drivers/mtd/nand/ams-delta.c     |  4 +--
 drivers/mtd/nand/cafe_nand.c     |  4 +--
 drivers/mtd/nand/cs553x_nand.c   |  8 ++---
 drivers/mtd/nand/diskonchip.c    | 76 +++++++++++++++++++++-------------------
 drivers/mtd/nand/fsl_elbc_nand.c |  4 +--
 drivers/mtd/nand/fsl_ifc_nand.c  |  2 +-
 drivers/mtd/nand/mxc_nand.c      |  2 +-
 drivers/mtd/nand/nand_bch.c      | 12 +++----
 drivers/mtd/nand/nandsim.c       | 10 +++---
 drivers/mtd/nand/r852.c          |  2 +-
 drivers/mtd/nand/r852.h          |  6 ++--
 drivers/mtd/nand/sh_flctl.c      |  2 +-
 drivers/mtd/nand/sm_common.c     |  5 ++-
 13 files changed, 70 insertions(+), 67 deletions(-)
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH 1/5 mtd/nand: Replace printk with pr_warn

pr_*macro is the preferred way to print messages, replace all printk(KERN_WARN, ...) with pr_warn.

Signed-off-by Shreeya Patel <[email protected]>
---
 drivers/mtd/nand/ams-delta.c   |  2 +-
 drivers/mtd/nand/cafe_nand.c   |  4 ++--
 drivers/mtd/nand/cs553x_nand.c |  2 +-
 drivers/mtd/nand/diskonchip.c  |  8 ++++----
 drivers/mtd/nand/mxc_nand.c    |  2 +-
 drivers/mtd/nand/nand_bch.c    | 10 +++++-----
 drivers/mtd/nand/nandsim.c     |  2 +-
 7 files changed, 15 insertions(+), 15 deletions(-)
drivers/mtd/nand/ams-delta.c +1 -1
index dcec9cf..24b1c24 100644
@@ -185,7 +185,7 @@ static int ams_delta_init(struct platform_device *pdev)
 	/* Allocate memory for MTD device structure and private data */
 	this = kzalloc(sizeof(struct nand_chip), GFP_KERNEL);
 	if (!this) {
-		printk (KERN_WARNING "Unable to allocate E3 NAND MTD device structure.\n");
+		pr_warn("Unable to allocate E3 NAND MTD device structure.\n");
 		err = -ENOMEM;
 		goto out;
 	}
drivers/mtd/nand/cafe_nand.c +2 -2
index bc558c4..1e84a6e 100644
@@ -773,8 +773,8 @@ static int cafe_nand_probe(struct pci_dev *pdev,
 		cafe->nand.bbt_td = &cafe_bbt_main_descr_512;
 		cafe->nand.bbt_md = &cafe_bbt_mirror_descr_512;
 	} else {
-		printk(KERN_WARNING "Unexpected NAND flash writesize %d. Aborting\n",
-		       mtd->writesize);
+		pr_warn("Unexpected NAND flash writesize %d. Aborting\n",
+			mtd->writesize);
 		goto out_free_dma;
 	}
 	cafe->nand.ecc.mode = NAND_ECC_HW_SYNDROME;
drivers/mtd/nand/cs553x_nand.c +1 -1
index d488775..d4269a4 100644
@@ -211,7 +211,7 @@ static int __init cs553x_init_one(int cs, int mmio, unsigned long adr)
 	/* map physical address */
 	this->IO_ADDR_R = this->IO_ADDR_W = ioremap(adr, 4096);
 	if (!this->IO_ADDR_R) {
-		printk(KERN_WARNING "ioremap cs553x NAND @0x%08lx failed\n", adr);
+		pr_warn("ioremap cs553x NAND @0x%08lx failed\n", adr);
 		err = -EIO;
 		goto out_mtd;
 	}
drivers/mtd/nand/diskonchip.c +4 -4
index c3aa53c..dac4aec 100644
@@ -1015,7 +1015,7 @@ static int __init find_media_headers(struct mtd_info *mtd, u_char *buf, const ch
 		if (retlen != mtd->writesize)
 			continue;
 		if (ret) {
-			printk(KERN_WARNING "ECC error scanning DOC at 0x%x\n", offs);
+			pr_warn("ECC error scanning DOC at 0x%x\n", offs);
 		}
 		if (memcmp(buf, id, 6))
 			continue;

@@ -1030,7 +1030,7 @@ static int __init find_media_headers(struct mtd_info *mtd, u_char *buf, const ch
 		return 2;
 	}
 	if (doc->mh0_page == -1) {
-		printk(KERN_WARNING "DiskOnChip %s Media Header not found.\n", id);
+		pr_warn("DiskOnChip %s Media Header not found.\n", id);
 		return 0;
 	}
 	/* Only one mediaheader was found.  We want buf to contain a

@@ -1093,7 +1093,7 @@ static inline int __init nftl_partscan(struct mtd_info *mtd, struct mtd_partitio
 			maxblocks = min(32768U, (maxblocks << 1) + psize);
 			mh->UnitSizeFactor--;
 		}
-		printk(KERN_WARNING "UnitSizeFactor=0x00 detected.  Correct value is assumed to be 0x%02x.\n", mh->UnitSizeFactor);
+		pr_warn("UnitSizeFactor=0x00 detected. Correct value is assumed to be 0x%02x.\n", mh->UnitSizeFactor);
 	}
 
 	/* NOTE: The lines below modify internal variables of the NAND and MTD

@@ -1512,7 +1512,7 @@ static int __init doc_probe(unsigned long physadr)
 	tmpb = ReadDOC_(virtadr, reg) & DOC_TOGGLE_BIT;
 	tmpc = ReadDOC_(virtadr, reg) & DOC_TOGGLE_BIT;
 	if ((tmp == tmpb) || (tmp != tmpc)) {
-		printk(KERN_WARNING "Possible DiskOnChip at 0x%lx failed TOGGLE test, dropping.\n", physadr);
+		pr_warn("Possible DiskOnChip at 0x%lx failed TOGGLE test, dropping.\n", physadr);
 		ret = -ENODEV;
 		goto notfound;
 	}
drivers/mtd/nand/mxc_nand.c +1 -1
index 53e5e03..e99c272 100644
@@ -634,7 +634,7 @@ static int mxc_nand_correct_data_v2_v3(struct mtd_info *mtd, u_char *dat,
 	do {
 		err = ecc_stat & ecc_bit_mask;
 		if (err > err_limit) {
-			printk(KERN_WARNING "UnCorrectable RS-ECC Error\n");
+			pr_warn("UnCorrectable RS-ECC Error\n");
 			return -EBADMSG;
 		} else {
 			ret += err;
drivers/mtd/nand/nand_bch.c +5 -5
index 505441c..366c04a 100644
@@ -134,7 +134,7 @@ struct nand_bch_control *nand_bch_init(struct mtd_info *mtd)
 	}
 
 	if (!eccsize || !eccbytes) {
-		printk(KERN_WARNING "ecc parameters not supplied\n");
+		pr_warn("ecc parameters not supplied\n");
 		goto fail;
 	}
 

@@ -151,8 +151,8 @@ struct nand_bch_control *nand_bch_init(struct mtd_info *mtd)
 
 	/* verify that eccbytes has the expected value */
 	if (nbc->bch->ecc_bytes != eccbytes) {
-		printk(KERN_WARNING "invalid eccbytes %u, should be %u\n",
-		       eccbytes, nbc->bch->ecc_bytes);
+		pr_warn("invalid eccbytes %u, should be %u\n",
+			eccbytes, nbc->bch->ecc_bytes);
 		goto fail;
 	}
 

@@ -166,7 +166,7 @@ struct nand_bch_control *nand_bch_init(struct mtd_info *mtd)
 
 	/* sanity checks */
 	if (8*(eccsize+eccbytes) >= (1 << m)) {
-		printk(KERN_WARNING "eccsize %u is too large\n", eccsize);
+		pr_warn("eccsize %u is too large\n", eccsize);
 		goto fail;
 	}
 

@@ -181,7 +181,7 @@ struct nand_bch_control *nand_bch_init(struct mtd_info *mtd)
 	nand->ecc.steps = eccsteps;
 	nand->ecc.total = eccsteps * eccbytes;
 	if (mtd_ooblayout_count_eccbytes(mtd) != (eccsteps*eccbytes)) {
-		printk(KERN_WARNING "invalid ecc layout\n");
+		pr_warn("invalid ecc layout\n");
 		goto fail;
 	}
drivers/mtd/nand/nandsim.c +1 -1
index 246b439..b2436ea 100644
@@ -188,7 +188,7 @@ MODULE_PARM_DESC(bch,		 "Enable BCH ecc and set how many bits should "
 #define NS_DBG(args...) \
 	do { if (dbg) printk(KERN_DEBUG NS_OUTPUT_PREFIX " debug: " args); } while(0)
 #define NS_WARN(args...) \
-	do { printk(KERN_WARNING NS_OUTPUT_PREFIX " warning: " args); } while(0)
+	do { pr_warn(NS_OUTPUT_PREFIX " warning: " args); } while(0)
 #define NS_ERR(args...) \
 	do { printk(KERN_ERR NS_OUTPUT_PREFIX " error: " args); } while(0)
 #define NS_INFO(args...) \
Signature · 1 line
2.7.4
#2 lore raw

Re: [Outreachy kernel] [PATCH NAND 1/5] mtd/nand: Replace printk with pr_warn

Quoted 2 lines · Shreeya Patel

pr_*macro is the preferred way to print messages, replace all printk(KERN_WARN, ...) with pr_warn.

It looks like it should be possible to use dev_warn?

julia

Quoted 172 lines
Signed-off-by Shreeya Patel <[email protected]>
---
 drivers/mtd/nand/ams-delta.c   |  2 +-
 drivers/mtd/nand/cafe_nand.c   |  4 ++--
 drivers/mtd/nand/cs553x_nand.c |  2 +-
 drivers/mtd/nand/diskonchip.c  |  8 ++++----
 drivers/mtd/nand/mxc_nand.c    |  2 +-
 drivers/mtd/nand/nand_bch.c    | 10 +++++-----
 drivers/mtd/nand/nandsim.c     |  2 +-
 7 files changed, 15 insertions(+), 15 deletions(-)
drivers/mtd/nand/ams-delta.c +1 -1
index dcec9cf..24b1c24 100644
@@ -185,7 +185,7 @@ static int ams_delta_init(struct platform_device *pdev)
 	/* Allocate memory for MTD device structure and private data */
 	this = kzalloc(sizeof(struct nand_chip), GFP_KERNEL);
 	if (!this) {
-		printk (KERN_WARNING "Unable to allocate E3 NAND MTD device structure.\n");
+		pr_warn("Unable to allocate E3 NAND MTD device structure.\n");
 		err = -ENOMEM;
 		goto out;
 	}
drivers/mtd/nand/cafe_nand.c +2 -2
index bc558c4..1e84a6e 100644
@@ -773,8 +773,8 @@ static int cafe_nand_probe(struct pci_dev *pdev,
 		cafe->nand.bbt_td = &cafe_bbt_main_descr_512;
 		cafe->nand.bbt_md = &cafe_bbt_mirror_descr_512;
 	} else {
-		printk(KERN_WARNING "Unexpected NAND flash writesize %d. Aborting\n",
-		       mtd->writesize);
+		pr_warn("Unexpected NAND flash writesize %d. Aborting\n",
+			mtd->writesize);
 		goto out_free_dma;
 	}
 	cafe->nand.ecc.mode = NAND_ECC_HW_SYNDROME;
drivers/mtd/nand/cs553x_nand.c +1 -1
index d488775..d4269a4 100644
@@ -211,7 +211,7 @@ static int __init cs553x_init_one(int cs, int mmio, unsigned long adr)
 	/* map physical address */
 	this->IO_ADDR_R = this->IO_ADDR_W = ioremap(adr, 4096);
 	if (!this->IO_ADDR_R) {
-		printk(KERN_WARNING "ioremap cs553x NAND @0x%08lx failed\n", adr);
+		pr_warn("ioremap cs553x NAND @0x%08lx failed\n", adr);
 		err = -EIO;
 		goto out_mtd;
 	}
drivers/mtd/nand/diskonchip.c +4 -4
index c3aa53c..dac4aec 100644
@@ -1015,7 +1015,7 @@ static int __init find_media_headers(struct mtd_info *mtd, u_char *buf, const ch
 		if (retlen != mtd->writesize)
 			continue;
 		if (ret) {
-			printk(KERN_WARNING "ECC error scanning DOC at 0x%x\n", offs);
+			pr_warn("ECC error scanning DOC at 0x%x\n", offs);
 		}
 		if (memcmp(buf, id, 6))
 			continue;

@@ -1030,7 +1030,7 @@ static int __init find_media_headers(struct mtd_info *mtd, u_char *buf, const ch
 		return 2;
 	}
 	if (doc->mh0_page == -1) {
-		printk(KERN_WARNING "DiskOnChip %s Media Header not found.\n", id);
+		pr_warn("DiskOnChip %s Media Header not found.\n", id);
 		return 0;
 	}
 	/* Only one mediaheader was found.  We want buf to contain a

@@ -1093,7 +1093,7 @@ static inline int __init nftl_partscan(struct mtd_info *mtd, struct mtd_partitio
 			maxblocks = min(32768U, (maxblocks << 1) + psize);
 			mh->UnitSizeFactor--;
 		}
-		printk(KERN_WARNING "UnitSizeFactor=0x00 detected.  Correct value is assumed to be 0x%02x.\n", mh->UnitSizeFactor);
+		pr_warn("UnitSizeFactor=0x00 detected. Correct value is assumed to be 0x%02x.\n", mh->UnitSizeFactor);
 	}
 
 	/* NOTE: The lines below modify internal variables of the NAND and MTD

@@ -1512,7 +1512,7 @@ static int __init doc_probe(unsigned long physadr)
 	tmpb = ReadDOC_(virtadr, reg) & DOC_TOGGLE_BIT;
 	tmpc = ReadDOC_(virtadr, reg) & DOC_TOGGLE_BIT;
 	if ((tmp == tmpb) || (tmp != tmpc)) {
-		printk(KERN_WARNING "Possible DiskOnChip at 0x%lx failed TOGGLE test, dropping.\n", physadr);
+		pr_warn("Possible DiskOnChip at 0x%lx failed TOGGLE test, dropping.\n", physadr);
 		ret = -ENODEV;
 		goto notfound;
 	}
drivers/mtd/nand/mxc_nand.c +1 -1
index 53e5e03..e99c272 100644
@@ -634,7 +634,7 @@ static int mxc_nand_correct_data_v2_v3(struct mtd_info *mtd, u_char *dat,
 	do {
 		err = ecc_stat & ecc_bit_mask;
 		if (err > err_limit) {
-			printk(KERN_WARNING "UnCorrectable RS-ECC Error\n");
+			pr_warn("UnCorrectable RS-ECC Error\n");
 			return -EBADMSG;
 		} else {
 			ret += err;
drivers/mtd/nand/nand_bch.c +5 -5
index 505441c..366c04a 100644
@@ -134,7 +134,7 @@ struct nand_bch_control *nand_bch_init(struct mtd_info *mtd)
 	}
 
 	if (!eccsize || !eccbytes) {
-		printk(KERN_WARNING "ecc parameters not supplied\n");
+		pr_warn("ecc parameters not supplied\n");
 		goto fail;
 	}
 

@@ -151,8 +151,8 @@ struct nand_bch_control *nand_bch_init(struct mtd_info *mtd)
 
 	/* verify that eccbytes has the expected value */
 	if (nbc->bch->ecc_bytes != eccbytes) {
-		printk(KERN_WARNING "invalid eccbytes %u, should be %u\n",
-		       eccbytes, nbc->bch->ecc_bytes);
+		pr_warn("invalid eccbytes %u, should be %u\n",
+			eccbytes, nbc->bch->ecc_bytes);
 		goto fail;
 	}
 

@@ -166,7 +166,7 @@ struct nand_bch_control *nand_bch_init(struct mtd_info *mtd)
 
 	/* sanity checks */
 	if (8*(eccsize+eccbytes) >= (1 << m)) {
-		printk(KERN_WARNING "eccsize %u is too large\n", eccsize);
+		pr_warn("eccsize %u is too large\n", eccsize);
 		goto fail;
 	}
 

@@ -181,7 +181,7 @@ struct nand_bch_control *nand_bch_init(struct mtd_info *mtd)
 	nand->ecc.steps = eccsteps;
 	nand->ecc.total = eccsteps * eccbytes;
 	if (mtd_ooblayout_count_eccbytes(mtd) != (eccsteps*eccbytes)) {
-		printk(KERN_WARNING "invalid ecc layout\n");
+		pr_warn("invalid ecc layout\n");
 		goto fail;
 	}
drivers/mtd/nand/nandsim.c +1 -2
index 246b439..b2436ea 100644
@@ -188,7 +188,7 @@ MODULE_PARM_DESC(bch,		 "Enable BCH ecc and set how many bits should "
 #define NS_DBG(args...) \
 	do { if (dbg) printk(KERN_DEBUG NS_OUTPUT_PREFIX " debug: " args); } while(0)
 #define NS_WARN(args...) \
-	do { printk(KERN_WARNING NS_OUTPUT_PREFIX " warning: " args); } while(0)
+	do { pr_warn(NS_OUTPUT_PREFIX " warning: " args); } while(0)
 #define NS_ERR(args...) \
 	do { printk(KERN_ERR NS_OUTPUT_PREFIX " error: " args); } while(0)
 #define NS_INFO(args...) \
--

2.7.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/49b0ddeaf74e473b0a5cd2a9fe2a3d0351349912.1518797480.git.shreeya.patel23498%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

author
#3 lore raw

Re: [Outreachy kernel] [PATCH NAND 1/5] mtd/nand: Replace printk with pr_warn

Quoted 7 lines · Julia Lawall
Quoted 3 lines · Shreeya Patel

pr_*macro is the preferred way to print messages, replace all printk(KERN_WARN, ...) with pr_warn.

It looks like it should be possible to use dev_warn?

Yes, I'll check this out.
Majority of the files in the Nand driver uses dev_warn but also some files have pr_warn.
So I'll see what will be the best use and why to use.

Thanks

Quoted 230 lines

julia

Quoted 227 lines
Signed-off-by Shreeya Patel <[email protected]>

---
 drivers/mtd/nand/ams-delta.c   |  2 +-
 drivers/mtd/nand/cafe_nand.c   |  4 ++--
 drivers/mtd/nand/cs553x_nand.c |  2 +-
 drivers/mtd/nand/diskonchip.c  |  8 ++++----
 drivers/mtd/nand/mxc_nand.c    |  2 +-
 drivers/mtd/nand/nand_bch.c    | 10 +++++-----
 drivers/mtd/nand/nandsim.c     |  2 +-

 7 files changed, 15 insertions(+), 15 deletions(-)
drivers/mtd/nand/ams- renamed from drivers/mtd/nand/ams-delta.c +0 -0

delta.c
index dcec9cf..24b1c24 100644

drivers/mtd/nand/ams-delta.c +0 -0
@@ -185,7 +185,7 @@ static int ams_delta_init(struct
 platform_device *pdev)
  	/* Allocate memory for MTD device structure and private

data */
  this = kzalloc(sizeof(struct nand_chip), GFP_KERNEL); if (!this) {

drivers/mtd/nand/ams-delta.c +0 -1
-		printk (KERN_WARNING "Unable to allocate E3 NAND

MTD device structure.\n");

drivers/mtd/nand/ams-delta.c +1 -0
+		pr_warn("Unable to allocate E3 NAND MTD device

structure.\n");
  err = -ENOMEM;
  goto out;
  }

drivers/mtd/nand/cafe_nand.c +2 -2
index bc558c4..1e84a6e 100644
@@ -773,8 +773,8 @@ static int cafe_nand_probe(struct pci_dev
 *pdev,
  		cafe->nand.bbt_td = &cafe_bbt_main_descr_512;
  		cafe->nand.bbt_md = &cafe_bbt_mirror_descr_512;
  	} else {
-		printk(KERN_WARNING "Unexpected NAND flash
 writesize %d. Aborting\n",
-		       mtd->writesize);
+		pr_warn("Unexpected NAND flash writesize %d.
 Aborting\n",
+			mtd->writesize);

  goto out_free_dma;
  }
  cafe->nand.ecc.mode = NAND_ECC_HW_SYNDROME;

drivers/mtd/nand/cs553x_nand.c +1 -1
index d488775..d4269a4 100644
@@ -211,7 +211,7 @@ static int __init cs553x_init_one(int cs, int
 mmio, unsigned long adr)
  	/* map physical address */
  	this->IO_ADDR_R = this->IO_ADDR_W = ioremap(adr, 4096);
  	if (!this->IO_ADDR_R) {
-		printk(KERN_WARNING "ioremap cs553x NAND @0x%08lx
 failed\n", adr);
+		pr_warn("ioremap cs553x NAND @0x%08lx failed\n",
 adr);

  err = -EIO;
  goto out_mtd;
  }

drivers/mtd/nand/diskonchip.c +0 -0
index c3aa53c..dac4aec 100644
@@ -1015,7 +1015,7 @@ static int __init find_media_headers(struct

mtd_info *mtd, u_char *buf, const ch
  if (retlen != mtd->writesize)
  continue;
  if (ret) {

drivers/mtd/nand/diskonchip.c +0 -1
-			printk(KERN_WARNING "ECC error scanning

DOC at 0x%x\n", offs);

drivers/mtd/nand/diskonchip.c +1 -0
+			pr_warn("ECC error scanning DOC at

0x%x\n", offs);
  }
  if (memcmp(buf, id, 6))
  continue;

drivers/mtd/nand/diskonchip.c +0 -0
@@ -1030,7 +1030,7 @@ static int __init find_media_headers(struct

mtd_info *mtd, u_char *buf, const ch
  return 2;
  }
  if (doc->mh0_page == -1) {

drivers/mtd/nand/diskonchip.c +0 -1
-		printk(KERN_WARNING "DiskOnChip %s Media Header

not found.\n", id);

drivers/mtd/nand/diskonchip.c +1 -0
+		pr_warn("DiskOnChip %s Media Header not found.\n",

id);
  return 0;
  }
  /* Only one mediaheader was found.  We want buf to contain a

drivers/mtd/nand/diskonchip.c +0 -0
@@ -1093,7 +1093,7 @@ static inline int __init nftl_partscan(struct

mtd_info *mtd, struct mtd_partitio
  maxblocks = min(32768U, (maxblocks << 1) + psize);
  mh->UnitSizeFactor--;
  }

drivers/mtd/nand/diskonchip.c +0 -1
-		printk(KERN_WARNING "UnitSizeFactor=0x00

detected.  Correct value is assumed to be 0x%02x.\n", mh-

Quoted 1 line

UnitSizeFactor);

drivers/mtd/nand/diskonchip.c +1 -0
+		pr_warn("UnitSizeFactor=0x00 detected. Correct

value is assumed to be 0x%02x.\n", mh->UnitSizeFactor); }

  /* NOTE: The lines below modify internal variables of the NAND and MTD

drivers/mtd/nand/diskonchip.c +1 -1
@@ -1512,7 +1512,7 @@ static int __init doc_probe(unsigned long
 physadr)
  	tmpb = ReadDOC_(virtadr, reg) & DOC_TOGGLE_BIT;
  	tmpc = ReadDOC_(virtadr, reg) & DOC_TOGGLE_BIT;
  	if ((tmp == tmpb) || (tmp != tmpc)) {
-		printk(KERN_WARNING "Possible DiskOnChip at 0x%lx
 failed TOGGLE test, dropping.\n", physadr);
+		pr_warn("Possible DiskOnChip at 0x%lx failed
 TOGGLE test, dropping.\n", physadr);

  ret = -ENODEV;
  goto notfound;
  }

drivers/mtd/nand/mxc_nand.c +1 -1
index 53e5e03..e99c272 100644
@@ -634,7 +634,7 @@ static int mxc_nand_correct_data_v2_v3(struct
 mtd_info *mtd, u_char *dat,
  	do {
  		err = ecc_stat & ecc_bit_mask;
  		if (err > err_limit) {
-			printk(KERN_WARNING "UnCorrectable RS-ECC
 Error\n");
+			pr_warn("UnCorrectable RS-ECC Error\n");
  			return -EBADMSG;

  } else {
  ret += err;

drivers/mtd/nand/nand_bch.c +1 -1
index 505441c..366c04a 100644
@@ -134,7 +134,7 @@ struct nand_bch_control *nand_bch_init(struct
 mtd_info *mtd)
  	}
 
  	if (!eccsize || !eccbytes) {
-		printk(KERN_WARNING "ecc parameters not
 supplied\n");
+		pr_warn("ecc parameters not supplied\n");
  		goto fail;

  }

drivers/mtd/nand/nand_bch.c +2 -2
@@ -151,8 +151,8 @@ struct nand_bch_control *nand_bch_init(struct
 mtd_info *mtd)
 
  	/* verify that eccbytes has the expected value */
  	if (nbc->bch->ecc_bytes != eccbytes) {
-		printk(KERN_WARNING "invalid eccbytes %u, should
 be %u\n",
-		       eccbytes, nbc->bch->ecc_bytes);
+		pr_warn("invalid eccbytes %u, should be %u\n",
+			eccbytes, nbc->bch->ecc_bytes);
  		goto fail;

  }

drivers/mtd/nand/nand_bch.c +1 -1
@@ -166,7 +166,7 @@ struct nand_bch_control *nand_bch_init(struct
 mtd_info *mtd)
 
  	/* sanity checks */
  	if (8*(eccsize+eccbytes) >= (1 << m)) {
-		printk(KERN_WARNING "eccsize %u is too large\n",
 eccsize);
+		pr_warn("eccsize %u is too large\n", eccsize);
  		goto fail;

  }

drivers/mtd/nand/nand_bch.c +0 -0
@@ -181,7 +181,7 @@ struct nand_bch_control *nand_bch_init(struct
 mtd_info *mtd)
  	nand->ecc.steps = eccsteps;
  	nand->ecc.total = eccsteps * eccbytes;

  if (mtd_ooblayout_count_eccbytes(mtd) !=
(eccsteps*eccbytes)) {

drivers/mtd/nand/nand_bch.c +1 -1
-		printk(KERN_WARNING "invalid ecc layout\n");
+		pr_warn("invalid ecc layout\n");

  goto fail;
  }

drivers/mtd/nand/nandsim.c +0 -0
index 246b439..b2436ea 100644
@@ -188,7 +188,7 @@ MODULE_PARM_DESC(bch,		 "Enable

BCH ecc and set how many bits should "
 #define NS_DBG(args...) \
  do { if (dbg) printk(KERN_DEBUG NS_OUTPUT_PREFIX " debug:
" args); } while(0)
 #define NS_WARN(args...) \

drivers/mtd/nand/nandsim.c +0 -1
-	do { printk(KERN_WARNING NS_OUTPUT_PREFIX " warning: "

args); } while(0)

drivers/mtd/nand/nandsim.c +1 -0
+	do { pr_warn(NS_OUTPUT_PREFIX " warning: " args); }

while(0)
 #define NS_ERR(args...) \
  do { printk(KERN_ERR NS_OUTPUT_PREFIX " error: " args); } while(0)
 #define NS_INFO(args...) \
--
2.7.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to outreachy-kernel@googlegroups. com.
To view this discussion on the web visit https://groups.google.com/
d/msgid/outreachy- kernel/49b0ddeaf74e473b0a5cd2a9fe2a3d0351349912.1518797480.git.shre eya.patel23498%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

author
#4 lore raw

PATCH 2/5 mtd/nand: Replace printk with pr_notice

In reply to Shreeya Patel

pr_*macro is the preferred way to print messages, replace all printk(KERN_NOTICE, ...) with pr_notice.

Signed-off-by Shreeya Patel <[email protected]>
---
 drivers/mtd/nand/ams-delta.c   | 2 +-
 drivers/mtd/nand/cs553x_nand.c | 4 ++--
 drivers/mtd/nand/diskonchip.c  | 2 +-
 drivers/mtd/nand/r852.c        | 2 +-
 drivers/mtd/nand/sm_common.c   | 5 ++---
 5 files changed, 7 insertions(+), 8 deletions(-)
drivers/mtd/nand/ams-delta.c +1 -1
index 24b1c24..e120ce9 100644
@@ -219,7 +219,7 @@ static int ams_delta_init(struct platform_device *pdev)
 		this->dev_ready = ams_delta_nand_ready;
 	} else {
 		this->dev_ready = NULL;
-		printk(KERN_NOTICE "Couldn't request gpio for Delta NAND ready.\n");
+		pr_notice("Couldn't request gpio for Delta NAND ready.\n");
 	}
 	/* 25 us command delay time */
 	this->chip_delay = 30;
drivers/mtd/nand/cs553x_nand.c +2 -2
index d4269a4..ec54f81 100644
@@ -189,10 +189,10 @@ static int __init cs553x_init_one(int cs, int mmio, unsigned long adr)
 	struct nand_chip *this;
 	struct mtd_info *new_mtd;
 
-	printk(KERN_NOTICE "Probing CS553x NAND controller CS#%d at %sIO 0x%08lx\n", cs, mmio?"MM":"P", adr);
+	pr_notice("Probing CS553x NAND controller CS#%d at %sIO 0x%08lx\n", cs, mmio?"MM":"P", adr);
 
 	if (!mmio) {
-		printk(KERN_NOTICE "PIO mode not yet implemented for CS553X NAND controller\n");
+		pr_notice("PIO mode not yet implemented for CS553X NAND controller\n");
 		return -ENXIO;
 	}
drivers/mtd/nand/diskonchip.c +1 -1
index dac4aec..ae2452d 100644
@@ -1551,7 +1551,7 @@ static int __init doc_probe(unsigned long physadr)
 		}
 	}
 
-	printk(KERN_NOTICE "DiskOnChip found at 0x%lx\n", physadr);
+	pr_notice("DiskOnChip found at 0x%lx\n", physadr);
 
 	len = sizeof(struct nand_chip) + sizeof(struct doc_priv) +
 	      (2 * sizeof(struct nand_bbt_descr));
drivers/mtd/nand/r852.c +1 -1
index fc9287a..3d54c6a 100644
@@ -935,7 +935,7 @@ static int  r852_probe(struct pci_dev *pci_dev, const struct pci_device_id *id)
 		&dev->card_detect_work, 0);
 
 
-	printk(KERN_NOTICE DRV_NAME ": driver loaded successfully\n");
+	pr_notice(DRV_NAME ": driver loaded successfully\n");
 	return 0;
 
 error10:
drivers/mtd/nand/sm_common.c +2 -3
index c378705..7f5044a 100644
@@ -119,9 +119,8 @@ static int sm_block_markbad(struct mtd_info *mtd, loff_t ofs)
 
 	ret = mtd_write_oob(mtd, ofs, &ops);
 	if (ret < 0 || ops.oobretlen != SM_OOB_SIZE) {
-		printk(KERN_NOTICE
-			"sm_common: can't mark sector at %i as bad\n",
-								(int)ofs);
+		pr_notice("sm_common: can't mark sector at %i as bad\n",
+			  (int)ofs);
 		return -EIO;
 	}
Signature · 1 line
2.7.4
author
#5 lore raw

PATCH 3/5 mtd/nand: Replace printk with pr_err

In reply to Shreeya Patel

pr_*macro is the preferred way to print messages, replace all printk(KERN_ERR, ...) with pr_err.

Signed-off-by Shreeya Patel <[email protected]>
---
 drivers/mtd/nand/diskonchip.c   | 22 ++++++++++++----------
 drivers/mtd/nand/fsl_ifc_nand.c |  2 +-
 drivers/mtd/nand/nand_bch.c     |  2 +-
 drivers/mtd/nand/nandsim.c      |  2 +-
 drivers/mtd/nand/sh_flctl.c     |  2 +-
 5 files changed, 16 insertions(+), 14 deletions(-)
drivers/mtd/nand/diskonchip.c +12 -10
index ae2452d..93d23d1d 100644
@@ -935,14 +935,15 @@ static int doc200x_correct_data(struct mtd_info *mtd, u_char *dat,
 
 		ret = doc_ecc_decode(rs_decoder, dat, calc_ecc);
 		if (ret > 0)
-			printk(KERN_ERR "doc200x_correct_data corrected %d errors\n", ret);
+			pr_err("doc200x_correct_data corrected %d errors\n",
+			       ret);
 	}
 	if (DoC_is_MillenniumPlus(doc))
 		WriteDOC(DOC_ECC_DIS, docptr, Mplus_ECCConf);
 	else
 		WriteDOC(DOC_ECC_DIS, docptr, ECCConf);
 	if (no_ecc_failures && mtd_is_eccerr(ret)) {
-		printk(KERN_ERR "suppressing ECC failure\n");
+		pr_err("suppressing ECC failure\n");
 		ret = 0;
 	}
 	return ret;

@@ -1039,7 +1040,7 @@ static int __init find_media_headers(struct mtd_info *mtd, u_char *buf, const ch
 	ret = mtd_read(mtd, offs, mtd->writesize, &retlen, buf);
 	if (retlen != mtd->writesize) {
 		/* Insanity.  Give up. */
-		printk(KERN_ERR "Read DiskOnChip Media Header once, but can't reread it???\n");
+		pr_err("Read DiskOnChip Media Header once, but can't reread it???\n");
 		return 0;
 	}
 	return 1;

@@ -1110,7 +1111,7 @@ static inline int __init nftl_partscan(struct mtd_info *mtd, struct mtd_partitio
 	}
 
 	if (blocks > maxblocks) {
-		printk(KERN_ERR "UnitSizeFactor of 0x%02x is inconsistent with device size.  Aborting.\n", mh->UnitSizeFactor);
+		pr_err("UnitSizeFactor of 0x%02x is inconsistent with device size.  Aborting.\n", mh->UnitSizeFactor);
 		goto out;
 	}
 

@@ -1203,13 +1204,13 @@ static inline int __init inftl_partscan(struct mtd_info *mtd, struct mtd_partiti
 
 	blocks = mtd->size >> vshift;
 	if (blocks > 32768) {
-		printk(KERN_ERR "BlockMultiplierBits=%d is inconsistent with device size.  Aborting.\n", mh->BlockMultiplierBits);
+		pr_err("BlockMultiplierBits=%d is inconsistent with device size. Aborting.\n", mh->BlockMultiplierBits);
 		goto out;
 	}
 
 	blocks = doc->chips_per_floor << (this->chip_shift - this->phys_erase_shift);
 	if (inftl_bbt_write && (blocks > mtd->erasesize)) {
-		printk(KERN_ERR "Writeable BBTs spanning more than one erase block are not yet supported.  FIX ME!\n");
+		pr_err("Writeable BBTs spanning more than one erase block are not yet supported.  FIX ME!\n");
 		goto out;
 	}
 

@@ -1309,7 +1310,7 @@ static int __init inftl_scan_bbt(struct mtd_info *mtd)
 	struct mtd_partition parts[5];
 
 	if (this->numchips > doc->chips_per_floor) {
-		printk(KERN_ERR "Multi-floor INFTL devices not yet supported.\n");
+		pr_err("Multi-floor INFTL devices not yet supported.\n");
 		return -EIO;
 	}
 

@@ -1437,7 +1438,8 @@ static int __init doc_probe(unsigned long physadr)
 		return -EBUSY;
 	virtadr = ioremap(physadr, DOC_IOREMAP_LEN);
 	if (!virtadr) {
-		printk(KERN_ERR "Diskonchip ioremap failed: 0x%x bytes at 0x%lx\n", DOC_IOREMAP_LEN, physadr);
+		pr_err("Diskonchip ioremap failed: 0x%x bytes at 0x%lx\n",
+		       DOC_IOREMAP_LEN, physadr);
 		ret = -EIO;
 		goto error_ioremap;
 	}

@@ -1496,7 +1498,7 @@ static int __init doc_probe(unsigned long physadr)
 			reg = DoC_Mplus_Toggle;
 			break;
 		case DOC_ChipID_DocMilPlus32:
-			printk(KERN_ERR "DiskOnChip Millennium Plus 32MB is not supported, ignoring.\n");
+			pr_err("DiskOnChip Millennium Plus 32MB is not supported, ignoring.\n");
 		default:
 			ret = -ENODEV;
 			goto notfound;

@@ -1666,7 +1668,7 @@ static int __init init_nanddoc(void)
 	 */
 	rs_decoder = init_rs(10, 0x409, FCR, 1, NROOTS);
 	if (!rs_decoder) {
-		printk(KERN_ERR "DiskOnChip: Could not create a RS decoder\n");
+		pr_err("DiskOnChip: Could not create a RS decoder\n");
 		return -ENOMEM;
 	}
drivers/mtd/nand/fsl_ifc_nand.c +1 -1
index 9e03bac..f88a493 100644
@@ -805,7 +805,7 @@ static void fsl_ifc_sram_init(struct fsl_ifc_mtd *priv)
 			   msecs_to_jiffies(IFC_TIMEOUT_MSECS));
 
 	if (ctrl->nand_stat != IFC_NAND_EVTER_STAT_OPC)
-		printk(KERN_ERR "fsl-ifc: Failed to Initialise SRAM\n");
+		pr_err("fsl-ifc: Failed to Initialise SRAM\n");
 
 	/* Restore CSOR and CSOR_ext */
 	ifc_out32(csor, &ifc_global->csor_cs[cs].csor);
drivers/mtd/nand/nand_bch.c +1 -1
index 366c04a..7f11b68 100644
@@ -95,7 +95,7 @@ int nand_bch_correct_data(struct mtd_info *mtd, unsigned char *buf,
 					errloc[i]);
 		}
 	} else if (count < 0) {
-		printk(KERN_ERR "ecc unrecoverable error\n");
+		pr_err("ecc unrecoverable error\n");
 		count = -EBADMSG;
 	}
 	return count;
drivers/mtd/nand/nandsim.c +1 -1
index b2436ea..96df1c5 100644
@@ -190,7 +190,7 @@ MODULE_PARM_DESC(bch,		 "Enable BCH ecc and set how many bits should "
 #define NS_WARN(args...) \
 	do { pr_warn(NS_OUTPUT_PREFIX " warning: " args); } while(0)
 #define NS_ERR(args...) \
-	do { printk(KERN_ERR NS_OUTPUT_PREFIX " error: " args); } while(0)
+	do { pr_err(NS_OUTPUT_PREFIX " error: " args); } while(0)
 #define NS_INFO(args...) \
 	do { printk(KERN_INFO NS_OUTPUT_PREFIX " " args); } while(0)
drivers/mtd/nand/sh_flctl.c +1 -1
index e7f3c98..493f6b2 100644
@@ -877,7 +877,7 @@ static void flctl_cmdfunc(struct mtd_info *mtd, unsigned int command,
 			else if (!flctl->seqin_column)
 				execmd_write_page_sector(mtd);
 			else
-				printk(KERN_ERR "Invalid address !?\n");
+				pr_err("Invalid address !?\n");
 			break;
 		}
 		set_cmd_regs(mtd, command, (command << 8) | NAND_CMD_SEQIN);
Signature · 1 line
2.7.4
author
#6 lore raw

PATCH 4/5 mtd/nand: Replace printk with pr_info

In reply to Shreeya Patel

pr_*macro is the preferred way to print messages, replace all printk(KERN_INFO, ...) with pr_info.

Signed-off-by Shreeya Patel <[email protected]>
---
 drivers/mtd/nand/cs553x_nand.c   |  2 +-
 drivers/mtd/nand/diskonchip.c    | 39 ++++++++++++++++++++-------------------
 drivers/mtd/nand/fsl_elbc_nand.c |  4 ++--
 drivers/mtd/nand/nandsim.c       |  2 +-
 drivers/mtd/nand/r852.h          |  2 +-
 5 files changed, 25 insertions(+), 24 deletions(-)
drivers/mtd/nand/cs553x_nand.c +1 -1
index ec54f81..e690ddc 100644
@@ -295,7 +295,7 @@ static int __init cs553x_init(void)
 	/* If it doesn't have the NAND controller enabled, abort */
 	rdmsrl(MSR_DIVIL_BALL_OPTS, val);
 	if (val & PIN_OPT_IDE) {
-		printk(KERN_INFO "CS553x NAND controller: Flash I/O not enabled in MSR_DIVIL_BALL_OPTS.\n");
+		pr_info("CS553x NAND controller: Flash I/O not enabled in MSR_DIVIL_BALL_OPTS.\n");
 		return -ENXIO;
 	}
drivers/mtd/nand/diskonchip.c +20 -19
index 93d23d1d..d921b9a 100644
@@ -411,7 +411,7 @@ static uint16_t __init doc200x_ident_chip(struct mtd_info *mtd, int nr)
 
 		ident.dword = readl(docptr + DoC_2k_CDSN_IO);
 		if (((ident.byte[0] << 8) | ident.byte[1]) == ret) {
-			printk(KERN_INFO "DiskOnChip 2000 responds to DWORD access\n");
+			pr_info("DiskOnChip 2000 responds to DWORD access\n");
 			this->read_buf = &doc2000_readbuf_dword;
 		}
 	}

@@ -1020,7 +1020,7 @@ static int __init find_media_headers(struct mtd_info *mtd, u_char *buf, const ch
 		}
 		if (memcmp(buf, id, 6))
 			continue;
-		printk(KERN_INFO "Found DiskOnChip %s Media Header at 0x%x\n", id, offs);
+		pr_info("Found DiskOnChip %s Media Header at 0x%x\n", id, offs);
 		if (doc->mh0_page == -1) {
 			doc->mh0_page = offs >> this->page_shift;
 			if (!findmirror)

@@ -1070,11 +1070,11 @@ static inline int __init nftl_partscan(struct mtd_info *mtd, struct mtd_partitio
 	le16_to_cpus(&mh->FirstPhysicalEUN);
 	le32_to_cpus(&mh->FormattedSize);
 
-	printk(KERN_INFO "    DataOrgID        = %s\n"
-			 "    NumEraseUnits    = %d\n"
-			 "    FirstPhysicalEUN = %d\n"
-			 "    FormattedSize    = %d\n"
-			 "    UnitSizeFactor   = %d\n",
+	pr_info("    DataOrgID        = %s\n"
+		"    NumEraseUnits    = %d\n"
+		"    FirstPhysicalEUN = %d\n"
+		"    FormattedSize    = %d\n"
+		"    UnitSizeFactor   = %d\n",
 		mh->DataOrgID, mh->NumEraseUnits,
 		mh->FirstPhysicalEUN, mh->FormattedSize,
 		mh->UnitSizeFactor);

@@ -1105,7 +1105,7 @@ static inline int __init nftl_partscan(struct mtd_info *mtd, struct mtd_partitio
 	if (mh->UnitSizeFactor != 0xff) {
 		this->bbt_erase_shift += (0xff - mh->UnitSizeFactor);
 		mtd->erasesize <<= (0xff - mh->UnitSizeFactor);
-		printk(KERN_INFO "Setting virtual erase size to %d\n", mtd->erasesize);
+		pr_info("Setting virtual erase size to %d\n", mtd->erasesize);
 		blocks = mtd->size >> this->bbt_erase_shift;
 		maxblocks = min(32768U, mtd->erasesize - psize);
 	}

@@ -1182,14 +1182,14 @@ static inline int __init inftl_partscan(struct mtd_info *mtd, struct mtd_partiti
 	le32_to_cpus(&mh->FormatFlags);
 	le32_to_cpus(&mh->PercentUsed);
 
-	printk(KERN_INFO "    bootRecordID          = %s\n"
-			 "    NoOfBootImageBlocks   = %d\n"
-			 "    NoOfBinaryPartitions  = %d\n"
-			 "    NoOfBDTLPartitions    = %d\n"
-			 "    BlockMultiplerBits    = %d\n"
-			 "    FormatFlgs            = %d\n"
-			 "    OsakVersion           = %d.%d.%d.%d\n"
-			 "    PercentUsed           = %d\n",
+	pr_info("    bootRecordID          = %s\n"
+		"    NoOfBootImageBlocks   = %d\n"
+		"    NoOfBinaryPartitions  = %d\n"
+		"    NoOfBDTLPartitions    = %d\n"
+		"    BlockMultiplerBits    = %d\n"
+		"    FormatFlgs            = %d\n"
+		"    OsakVersion           = %d.%d.%d.%d\n"
+		"    PercentUsed           = %d\n",
 		mh->bootRecordID, mh->NoOfBootImageBlocks,
 		mh->NoOfBinaryPartitions,
 		mh->NoOfBDTLPartitions,

@@ -1224,7 +1224,7 @@ static inline int __init inftl_partscan(struct mtd_info *mtd, struct mtd_partiti
 		le32_to_cpus(&ip->spareUnits);
 		le32_to_cpus(&ip->Reserved0);
 
-		printk(KERN_INFO	"    PARTITION[%d] ->\n"
+		pr_info("    PARTITION[%d] ->\n"
 			"        virtualUnits    = %d\n"
 			"        firstUnit       = %d\n"
 			"        lastUnit        = %d\n"

@@ -1673,7 +1673,8 @@ static int __init init_nanddoc(void)
 	}
 
 	if (doc_config_location) {
-		printk(KERN_INFO "Using configured DiskOnChip probe address 0x%lx\n", doc_config_location);
+		pr_info("Using configured DiskOnChip probe address 0x%lx\n",
+			doc_config_location);
 		ret = doc_probe(doc_config_location);
 		if (ret < 0)
 			goto outerr;

@@ -1685,7 +1686,7 @@ static int __init init_nanddoc(void)
 	/* No banner message any more. Print a message if no DiskOnChip
 	   found, so the user knows we at least tried. */
 	if (!doclist) {
-		printk(KERN_INFO "No valid DiskOnChip devices found\n");
+		pr_info("No valid DiskOnChip devices found\n");
 		ret = -ENODEV;
 		goto outerr;
 	}
drivers/mtd/nand/fsl_elbc_nand.c +2 -2
index 17db2f9..396216c2 100644
@@ -929,8 +929,8 @@ static int fsl_elbc_nand_probe(struct platform_device *pdev)
 	mtd_device_parse_register(mtd, part_probe_types, NULL,
 				  NULL, 0);
 
-	printk(KERN_INFO "eLBC NAND device at 0x%llx, bank %d\n",
-	       (unsigned long long)res.start, priv->bank);
+	pr_info("eLBC NAND device at 0x%llx, bank %d\n",
+		(unsigned long long)res.start, priv->bank);
 	return 0;
 
 err:
drivers/mtd/nand/nandsim.c +1 -1
index 96df1c5..cfcc907 100644
@@ -192,7 +192,7 @@ MODULE_PARM_DESC(bch,		 "Enable BCH ecc and set how many bits should "
 #define NS_ERR(args...) \
 	do { pr_err(NS_OUTPUT_PREFIX " error: " args); } while(0)
 #define NS_INFO(args...) \
-	do { printk(KERN_INFO NS_OUTPUT_PREFIX " " args); } while(0)
+	do { pr_info(NS_OUTPUT_PREFIX " " args); } while(0)
 
 /* Busy-wait delay macros (microseconds, milliseconds) */
 #define NS_UDELAY(us) \
drivers/mtd/nand/r852.h +1 -1
index 8713c57..c59ca11 100644
@@ -157,4 +157,4 @@ struct r852_device {
 
 
 #define message(format, ...) \
-	printk(KERN_INFO DRV_NAME ": " format "\n", ## __VA_ARGS__)
+	pr_info(DRV_NAME ": " format "\n", ## __VA_ARGS__)
Signature · 1 line
2.7.4
author
#7 lore raw

PATCH 5/5 mtd/nand: Replace printk with pr_debug

In reply to Shreeya Patel

pr_*macro is the preferred way to print messages, replace all printk(KERN_DEBUG, ...) with pr_debug.

Signed-off-by Shreeya Patel <[email protected]>
---
 drivers/mtd/nand/diskonchip.c | 5 +++--
 drivers/mtd/nand/nandsim.c    | 4 ++--
 drivers/mtd/nand/r852.h       | 4 ++--
 3 files changed, 7 insertions(+), 6 deletions(-)
drivers/mtd/nand/diskonchip.c +3 -2
index d921b9a..4821ecc 100644
@@ -438,7 +438,7 @@ static void __init doc2000_count_chips(struct mtd_info *mtd)
 			break;
 	}
 	doc->chips_per_floor = i;
-	printk(KERN_DEBUG "Detected %d chips per floor.\n", i);
+	pr_debug("Detected %d chips per floor.\n", i);
 }
 
 static int doc200x_wait(struct mtd_info *mtd, struct nand_chip *this)

@@ -1548,7 +1548,8 @@ static int __init doc_probe(unsigned long physadr)
 		}
 		newval = ~newval;
 		if (oldval == newval) {
-			printk(KERN_DEBUG "Found alias of DOC at 0x%lx to 0x%lx\n", doc->physadr, physadr);
+			pr_debug("Found alias of DOC at 0x%lx to 0x%lx\n",
+				 doc->physadr, physadr);
 			goto notfound;
 		}
 	}
drivers/mtd/nand/nandsim.c +2 -2
index cfcc907..4e5f817 100644
@@ -184,9 +184,9 @@ MODULE_PARM_DESC(bch,		 "Enable BCH ecc and set how many bits should "
 
 /* Simulator's output macros (logging, debugging, warning, error) */
 #define NS_LOG(args...) \
-	do { if (log) printk(KERN_DEBUG NS_OUTPUT_PREFIX " log: " args); } while(0)
+	do { if (log) pr_debug(NS_OUTPUT_PREFIX " log: " args); } while(0)
 #define NS_DBG(args...) \
-	do { if (dbg) printk(KERN_DEBUG NS_OUTPUT_PREFIX " debug: " args); } while(0)
+	do { if (dbg) pr_debug(NS_OUTPUT_PREFIX " debug: " args); } while(0)
 #define NS_WARN(args...) \
 	do { pr_warn(NS_OUTPUT_PREFIX " warning: " args); } while(0)
 #define NS_ERR(args...) \
drivers/mtd/nand/r852.h +2 -2
index c59ca11..63de9b6 100644
@@ -149,11 +149,11 @@ struct r852_device {
 
 #define dbg(format, ...) \
 	if (debug) \
-		printk(KERN_DEBUG DRV_NAME ": " format "\n", ## __VA_ARGS__)
+		pr_debug(DRV_NAME ": " format "\n", ## __VA_ARGS__)
 
 #define dbg_verbose(format, ...) \
 	if (debug > 1) \
-		printk(KERN_DEBUG DRV_NAME ": " format "\n", ## __VA_ARGS__)
+		pr_debug(DRV_NAME ": " format "\n", ## __VA_ARGS__)
 
 
 #define message(format, ...) \
Signature · 1 line
2.7.4
#8 lore raw
In reply to Shreeya Patel

Hi Shreeya,

Thanks for the contribution.

Quoted 7 lines · Shreeya Patel

This patchset removes all the log levels i.e. KERN_WARN, KERN_NOTICE, KERN_ERR, KERN_INFO, KERN_DEBUG used in the printk statements and replaces the printk statements with appropriate pr_*macros.
According to the kernel coding style, pr_*macro is the preferred way to print the message.

So, two things to begin with.

First of all, despite this contribution being part of outreachy, I believe you can include mailing lists in your case.

In other words, don't use the "nol" option in get_maintainer script and Cc the MTD mailing list: linux-mtd at lists.infradead.org.

Quoted 8 lines

Shreeya Patel (5):
mtd/nand: Replace printk with pr_warn
mtd/nand: Replace printk with pr_notice
mtd/nand: Replace printk with pr_err
mtd/nand: Replace printk with pr_info
mtd/nand: Replace printk with pr_debug

This is a non-usual split. We usually split patches per-driver, instead of grouping all the pr_{} of a given type together.

Can you re-do the series? Grouping the changes per-driver, i.e. all the pr_{} changes in cafe_nand.c together, and so on.

Quoted 18 lines
 drivers/mtd/nand/ams-delta.c     |  4 +--
 drivers/mtd/nand/cafe_nand.c     |  4 +--
 drivers/mtd/nand/cs553x_nand.c   |  8 ++---
 drivers/mtd/nand/diskonchip.c    | 76 +++++++++++++++++++++-------------------
 drivers/mtd/nand/fsl_elbc_nand.c |  4 +--
 drivers/mtd/nand/fsl_ifc_nand.c  |  2 +-
 drivers/mtd/nand/mxc_nand.c      |  2 +-
 drivers/mtd/nand/nand_bch.c      | 12 +++----
 drivers/mtd/nand/nandsim.c       | 10 +++---
 drivers/mtd/nand/r852.c          |  2 +-
 drivers/mtd/nand/r852.h          |  6 ++--
 drivers/mtd/nand/sh_flctl.c      |  2 +-
 drivers/mtd/nand/sm_common.c     |  5 ++-
 13 files changed, 70 insertions(+), 67 deletions(-)

--
2.7.4

Signature · 2 lines
Ezequiel García, VanguardiaSur
www.vanguardiasur.com.ar
#9 lore raw
Quoted 14 lines · Ezequiel Garcia

Hi Shreeya,

Thanks for the contribution.

Quoted 7 lines · Shreeya Patel

This patchset removes all the log levels i.e. KERN_WARN, KERN_NOTICE, KERN_ERR, KERN_INFO, KERN_DEBUG used in the printk statements and replaces the printk statements with appropriate pr_*macros.
According to the kernel coding style, pr_*macro is the preferred way to print the message.

Quoted 7 lines

So, two things to begin with.

First of all, despite this contribution being part of outreachy, I believe you can include mailing lists in your case.

In other words, don't use the "nol" option in get_maintainer script and Cc the MTD mailing list: linux-mtd at lists.infradead.org.

Shouldn't the dev_* functions also be usable?

julia

Quoted 48 lines
Quoted 9 lines

Shreeya Patel (5):
mtd/nand: Replace printk with pr_warn
mtd/nand: Replace printk with pr_notice
mtd/nand: Replace printk with pr_err
mtd/nand: Replace printk with pr_info
mtd/nand: Replace printk with pr_debug

This is a non-usual split. We usually split patches per-driver, instead of grouping all the pr_{} of a given type together.

Can you re-do the series? Grouping the changes per-driver, i.e. all the pr_{} changes in cafe_nand.c together, and so on.

Quoted 15 lines
 drivers/mtd/nand/ams-delta.c     |  4 +--
 drivers/mtd/nand/cafe_nand.c     |  4 +--
 drivers/mtd/nand/cs553x_nand.c   |  8 ++---
 drivers/mtd/nand/diskonchip.c    | 76 +++++++++++++++++++++-------------------
 drivers/mtd/nand/fsl_elbc_nand.c |  4 +--
 drivers/mtd/nand/fsl_ifc_nand.c  |  2 +-
 drivers/mtd/nand/mxc_nand.c      |  2 +-
 drivers/mtd/nand/nand_bch.c      | 12 +++----
 drivers/mtd/nand/nandsim.c       | 10 +++---
 drivers/mtd/nand/r852.c          |  2 +-
 drivers/mtd/nand/r852.h          |  6 ++--
 drivers/mtd/nand/sh_flctl.c      |  2 +-
 drivers/mtd/nand/sm_common.c     |  5 ++-
 13 files changed, 70 insertions(+), 67 deletions(-)
Quoted 3 lines

--
2.7.4

--
Ezequiel García, VanguardiaSur
www.vanguardiasur.com.ar

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAAEAJfAg_hei2PF37_oX2tf%2BMv43ye-nEOt%2BKRVFerp1Jfzn2Q%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

#10 lore raw
Quoted 20 lines · Julia Lawall
Quoted 16 lines · Ezequiel Garcia

Hi Shreeya,

Thanks for the contribution.

Quoted 7 lines · Shreeya Patel

This patchset removes all the log levels i.e. KERN_WARN, KERN_NOTICE, KERN_ERR, KERN_INFO, KERN_DEBUG used in the printk statements and replaces the printk statements with appropriate pr_*macros.
According to the kernel coding style, pr_*macro is the preferred way to print the message.

So, two things to begin with.

Quoted 8 lines
Quoted 5 lines

First of all, despite this contribution being part of outreachy, I believe you can include mailing lists in your case.

In other words, don't use the "nol" option in get_maintainer script and Cc the MTD mailing list: linux-mtd at lists.infradead.org.

Shouldn't the dev_* functions also be usable?

Provided that:
1. it's applicable, i.e. if in the context of a device.
2. Richard is not too opposed to the idea.

Then, yes.

Signature · 2 lines
Ezequiel García, VanguardiaSur
www.vanguardiasur.com.ar
#11 lore raw
Quoted 24 lines · On Fri, 16 Feb 2018 14:26:56 -0300 Ezequiel Garcia…
Quoted 23 lines · Julia Lawall
Quoted 19 lines · Ezequiel Garcia

Hi Shreeya,

Thanks for the contribution.

Quoted 7 lines · Shreeya Patel

This patchset removes all the log levels i.e. KERN_WARN, KERN_NOTICE, KERN_ERR, KERN_INFO, KERN_DEBUG used in the printk statements and replaces the printk statements with appropriate pr_*macros.
According to the kernel coding style, pr_*macro is the preferred way to print the message.

So, two things to begin with.

First of all, despite this contribution being part of outreachy, I believe you can include mailing lists in your case.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

In other words, don't use the "nol" option in get_maintainer script and Cc the MTD mailing list: linux-mtd at lists.infradead.org.

Shouldn't the dev_* functions also be usable?

Provided that:
1. it's applicable, i.e. if in the context of a device.

Yep, be careful with that. The MTD/NAND subsystem initializes mtd->dev.name quite late, so it's not safe to use &mtd->dev with dev_<loglevel>(). Note that you can use the NAND controller pdev->dev if available.

Quoted 3 lines

2. Richard is not too opposed to the idea.

Then, yes.

Signature · 3 lines
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
author
#12 lore raw
Quoted 40 lines · Boris Brezillon
Quoted 37 lines · On Fri, 16 Feb 2018 14:26:56 -0300 Ezequiel Garcia…
Quoted 34 lines · Julia Lawall

On Fri, 16 Feb 2018, Ezequiel Garcia wrote:

Quoted 20 lines

Hi Shreeya,

Thanks for the contribution.

Quoted 11 lines · Shreeya Patel

This patchset removes all the log levels i.e. KERN_WARN, KERN_NOTICE, KERN_ERR, KERN_INFO, KERN_DEBUG used in the printk
statements and replaces the printk statements with appropriate
pr_*macros.
According to the kernel coding style, pr_*macro is the preferred
way to print the message.

So, two things to begin with.

Quoted 7 lines

First of all, despite this contribution being part of outreachy,
I believe you can include mailing lists in your case.

In other words, don't use the "nol" option in get_maintainer script and Cc the MTD mailing list: linux-mtd at lists.infradead.org.

Shouldn't the dev_* functions also be usable?

Quoted 7 lines
Quoted 2 lines

Provided that:
1. it's applicable, i.e. if in the context of a device.

Yep, be careful with that. The MTD/NAND subsystem initializes mtd->dev.name quite late, so it's not safe to use &mtd->dev with dev_<loglevel>(). Note that you can use the NAND controller pdev->dev if
available.

This information is quite useful, thanks. I'll see that what will be the best thing to use here.

Quoted 7 lines
Quoted 5 lines

2. Richard is not too opposed to the idea.

Then, yes.

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): 20180218191347.76f4a287@bbrezillon

A message that is not in the archive (sent off-list or not yet received): [email protected]

#16 lore raw

Hi Shreeya,

Please try to keep everyone in the loop when you reply to an email. All discussions should happen publicly to keep everyone aware of the progress and let other developers/maintainers take part to the discussion if they have something to add.

Quoted 79 lines · On Sun, 18 Feb 2018 23:56:05 +0530 Shreeya Patel…
Quoted 67 lines · Boris Brezillon
Quoted 57 lines · On Sun, 18 Feb 2018 23:31:10 +0530 Shreeya Patel…

On Fri, 2018-02-16 at 18:48 +0100, Boris Brezillon wrote:

Hello Sir,

Quoted 52 lines

On Fri, 16 Feb 2018 14:26:56 -0300
Ezequiel Garcia <[email protected]> wrote:

Quoted 37 lines
Quoted 32 lines · Julia Lawall

On Fri, 16 Feb 2018, Ezequiel Garcia wrote:

Quoted 26 lines

Hi Shreeya,

Thanks for the contribution.

Quoted 12 lines · Shreeya Patel

This patchset removes all the log levels i.e. KERN_WARN, KERN_NOTICE, KERN_ERR, KERN_INFO, KERN_DEBUG used in the printk
statements and replaces the printk statements with appropriate
pr_*macros.
According to the kernel coding style, pr_*macro is the preferred
way to print the message.

So, two things to begin with.

First of all, despite this contribution being part of outreachy,
I believe you can include mailing lists in your case.

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

In other words, don't use the "nol" option in
get_maintainer
script and Cc the MTD mailing list: linux-mtd at
lists.infradead.org.

Shouldn't the dev_* functions also be usable?

Provided that:
1. it's applicable, i.e. if in the context of a device.

Yep, be careful with that. The MTD/NAND subsystem initializes mtd->dev.name quite late, so it's not safe to use &mtd->dev with dev_<loglevel>(). Note that you can use the NAND controller pdev-

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

dev

if
available.

I would like to ask here that what will be the benefit or good cause if
I use pdev->dev?
How is it different from others?

Quoted 9 lines

Well, pdev->dev is guaranteed to be properly initialized when you pass
it to dev_<loglevel>(). This is not the case with mtd->dev which is initialized in mtd_device_register(), but the NAND controller driver usually does some operations on the NAND device before reaching this point (reading the ID, reading the bad block markers to determine which
blocks are bad, ...).

Thanks for making me understand.

Quoted 7 lines
Quoted 4 lines

Anyway, I think it's better if you first do the s/printk(KERN_<LOGLEVEL>(/pr_<loglevel>(/ replacement. Replacing pr_xxx
by dev_xxx is something we can do afterwards.

I've created one patch where I have replaced printk with dev_* and used pdev->dev.

Okay. pdev->dev is not always directly accessible so doing s/printk(KERN_<LOGLEVEL>/dev_<loglevel>(&pdev->dev, / is likely to cause build failures. But I guess you compile-tested the changes you're about to submit.

Regards,

Boris

Signature · 3 lines
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
author
#17 lore raw
Quoted 7 lines · Boris Brezillon

Hi Shreeya,

Please try to keep everyone in the loop when you reply to an email. All
discussions should happen publicly to keep everyone aware of the progress and let other developers/maintainers take part to the discussion if they have something to add.

I'll keep this in mind.

Quoted 107 lines
Quoted 102 lines · On Sun, 18 Feb 2018 23:56:05 +0530 Shreeya Patel…
Quoted 81 lines · Boris Brezillon

On Sun, 18 Feb 2018 23:31:10 +0530
Shreeya Patel <[email protected]> wrote:

Quoted 70 lines · Boris Brezillon

Hello Sir,

Quoted 64 lines

On Fri, 16 Feb 2018 14:26:56 -0300
Ezequiel Garcia <[email protected]> wrote:

Quoted 45 lines

On 16 February 2018 at 14:23, Julia Lawall <julia.lawall@li p6.f
r>

Quoted 38 lines · wrote:

On Fri, 16 Feb 2018, Ezequiel Garcia wrote:

Quoted 31 lines

Hi Shreeya,

Thanks for the contribution.

Quoted 16 lines · Shreeya Patel

This patchset removes all the log levels i.e. KERN_WARN,
KERN_NOTICE, KERN_ERR, KERN_INFO, KERN_DEBUG used in the
printk
statements and replaces the printk statements with appropriate
pr_*macros.
According to the kernel coding style, pr_*macro is the
preferred
way to print the message.

So, two things to begin with.

First of all, despite this contribution being part of outreachy,
I believe you can include mailing lists in your case.

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

In other words, don't use the "nol" option in
get_maintainer
script and Cc the MTD mailing list: linux-mtd at
lists.infradead.org.

Shouldn't the dev_* functions also be usable?

Provided that:
1. it's applicable, i.e. if in the context of a device.

Yep, be careful with that. The MTD/NAND subsystem initializes mtd->dev.name quite late, so it's not safe to use &mtd->dev with
dev_<loglevel>(). Note that you can use the NAND controller pdev-

Quoted 1 line
Quoted 7 lines
Quoted 3 lines
Quoted 1 line

dev

if
available.

I would like to ask here that what will be the benefit or good cause if
I use pdev->dev?
How is it different from others?

Quoted 12 lines

Well, pdev->dev is guaranteed to be properly initialized when you pass
it to dev_<loglevel>(). This is not the case with mtd->dev which is
initialized in mtd_device_register(), but the NAND controller driver
usually does some operations on the NAND device before reaching this
point (reading the ID, reading the bad block markers to determine which
blocks are bad, ...).

Thanks for making me understand.

Quoted 5 lines

Anyway, I think it's better if you first do the s/printk(KERN_<LOGLEVEL>(/pr_<loglevel>(/ replacement. Replacing pr_xxx
by dev_xxx is something we can do afterwards.

Quoted 7 lines
Quoted 2 lines

I've created one patch where I have replaced printk with dev_* and used pdev->dev.

Okay. pdev->dev is not always directly accessible so doing s/printk(KERN_<LOGLEVEL>/dev_<loglevel>(&pdev->dev, / is likely to cause build failures. But I guess you compile-tested the changes you're
about to submit.

Yes, it wasn't directly accessible at some places.
Also, I was unable to compile ams-delta.c file.
I am working on it right now as I will have to cross compile for arm.

Thanks

Quoted 6 lines

Regards,

Boris

author
#18 lore raw
In reply to Boris Brezillon
Quoted 7 lines · Boris Brezillon

Hi Shreeya,

Please try to keep everyone in the loop when you reply to an email. All
discussions should happen publicly to keep everyone aware of the progress and let other developers/maintainers take part to the discussion if they have something to add.

I'll keep this in mind.

Quoted 107 lines
Quoted 102 lines · On Sun, 18 Feb 2018 23:56:05 +0530 Shreeya Patel…
Quoted 81 lines · Boris Brezillon

On Sun, 18 Feb 2018 23:31:10 +0530
Shreeya Patel <[email protected]> wrote:

Quoted 70 lines · Boris Brezillon

Hello Sir,

Quoted 64 lines

On Fri, 16 Feb 2018 14:26:56 -0300
Ezequiel Garcia <[email protected]> wrote:

Quoted 45 lines

On 16 February 2018 at 14:23, Julia Lawall <julia.lawall@li p6.f
r>

Quoted 38 lines · wrote:

On Fri, 16 Feb 2018, Ezequiel Garcia wrote:

Quoted 31 lines

Hi Shreeya,

Thanks for the contribution.

Quoted 16 lines · Shreeya Patel

This patchset removes all the log levels i.e. KERN_WARN,
KERN_NOTICE, KERN_ERR, KERN_INFO, KERN_DEBUG used in the
printk
statements and replaces the printk statements with appropriate
pr_*macros.
According to the kernel coding style, pr_*macro is the
preferred
way to print the message.

So, two things to begin with.

First of all, despite this contribution being part of outreachy,
I believe you can include mailing lists in your case.

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

In other words, don't use the "nol" option in
get_maintainer
script and Cc the MTD mailing list: linux-mtd at
lists.infradead.org.

Shouldn't the dev_* functions also be usable?

Provided that:
1. it's applicable, i.e. if in the context of a device.

Yep, be careful with that. The MTD/NAND subsystem initializes mtd->dev.name quite late, so it's not safe to use &mtd->dev with
dev_<loglevel>(). Note that you can use the NAND controller pdev-

Quoted 1 line
Quoted 7 lines
Quoted 3 lines
Quoted 1 line

dev

if
available.

I would like to ask here that what will be the benefit or good cause if
I use pdev->dev?
How is it different from others?

Quoted 12 lines

Well, pdev->dev is guaranteed to be properly initialized when you pass
it to dev_<loglevel>(). This is not the case with mtd->dev which is
initialized in mtd_device_register(), but the NAND controller driver
usually does some operations on the NAND device before reaching this
point (reading the ID, reading the bad block markers to determine which
blocks are bad, ...).

Thanks for making me understand.

Quoted 5 lines

Anyway, I think it's better if you first do the s/printk(KERN_<LOGLEVEL>(/pr_<loglevel>(/ replacement. Replacing pr_xxx
by dev_xxx is something we can do afterwards.

Quoted 7 lines
Quoted 2 lines

I've created one patch where I have replaced printk with dev_* and used pdev->dev.

Okay. pdev->dev is not always directly accessible so doing s/printk(KERN_<LOGLEVEL>/dev_<loglevel>(&pdev->dev, / is likely to cause build failures. But I guess you compile-tested the changes you're
about to submit.

Yes, it wasn't directly accessible at some places.
Also, I was unable to compile ams-delta.c file.
I am working on it right now as I will have to cross compile for arm.

Thanks

Quoted 6 lines

Regards,

Boris

author
#19 lore raw
In reply to Ezequiel Garcia
Quoted 14 lines · Ezequiel Garcia

Hi Shreeya,

Thanks for the contribution.

Quoted 8 lines · Shreeya Patel

This patchset removes all the log levels i.e. KERN_WARN, KERN_NOTICE, KERN_ERR, KERN_INFO, KERN_DEBUG used in the printk statements and replaces the printk statements with appropriate pr_*macros.
According to the kernel coding style, pr_*macro is the preferred way to print the message.

Quoted 7 lines

So, two things to begin with.

First of all, despite this contribution being part of outreachy, I believe you can include mailing lists in your case.

In other words, don't use the "nol" option in get_maintainer script and Cc the MTD mailing list: linux-mtd at lists.infradead.org.

Ok. I'll take care of this.

Quoted 10 lines
Quoted 10 lines

Shreeya Patel (5):
  mtd/nand: Replace printk with pr_warn
  mtd/nand: Replace printk with pr_notice
  mtd/nand: Replace printk with pr_err
  mtd/nand: Replace printk with pr_info
  mtd/nand: Replace printk with pr_debug

Quoted 5 lines

This is a non-usual split. We usually split patches per-driver, instead of grouping all the pr_{} of a given type together.

Can you re-do the series? Grouping the changes per-driver, i.e. all the pr_{} changes in cafe_nand.c together, and so on.

Yes, I'll do it again. :)

Also, I wanted to ask you that there are still printk statements present in the driver which are just printing the message i.e. they don't include any log levels.
So should I leave them as it is?

Thanks for your reviews

Quoted 23 lines
Quoted 21 lines

 drivers/mtd/nand/ams-delta.c     |  4 +-- drivers/mtd/nand/cafe_nand.c     |  4 +-- drivers/mtd/nand/cs553x_nand.c   |  8 ++--- drivers/mtd/nand/diskonchip.c    | 76 +++++++++++++++++++++-------
------------
 drivers/mtd/nand/fsl_elbc_nand.c |  4 +-- drivers/mtd/nand/fsl_ifc_nand.c  |  2 +- drivers/mtd/nand/mxc_nand.c      |  2 +- drivers/mtd/nand/nand_bch.c      | 12 +++---- drivers/mtd/nand/nandsim.c       | 10 +++--- drivers/mtd/nand/r852.c          |  2 +- drivers/mtd/nand/r852.h          |  6 ++-- drivers/mtd/nand/sh_flctl.c      |  2 +- drivers/mtd/nand/sm_common.c     |  5 ++-

 13 files changed, 70 insertions(+), 67 deletions(-)

--
2.7.4

#20 lore raw
In reply to Ezequiel Garcia
Quoted 14 lines · On Fri, 16 Feb 2018 14:19:41 -0300 Ezequiel Garcia…

Hi Shreeya,

Thanks for the contribution.

Quoted 7 lines · Shreeya Patel

This patchset removes all the log levels i.e. KERN_WARN, KERN_NOTICE, KERN_ERR, KERN_INFO, KERN_DEBUG used in the printk statements and replaces the printk statements with appropriate pr_*macros.
According to the kernel coding style, pr_*macro is the preferred way to print the message.

Quoted 15 lines

So, two things to begin with.

First of all, despite this contribution being part of outreachy, I believe you can include mailing lists in your case.

In other words, don't use the "nol" option in get_maintainer script and Cc the MTD mailing list: linux-mtd at lists.infradead.org.

Quoted 7 lines

Shreeya Patel (5):
mtd/nand: Replace printk with pr_warn
mtd/nand: Replace printk with pr_notice
mtd/nand: Replace printk with pr_err
mtd/nand: Replace printk with pr_info
mtd/nand: Replace printk with pr_debug

Nitpick: prefix should be "mtd: nand: ".

Quoted 4 lines
Quoted 1 line

This is a non-usual split. We usually split patches per-driver, instead of grouping all the pr_{} of a given type together.

I agree.

Quoted 3 lines

Can you re-do the series? Grouping the changes per-driver, i.e. all the pr_{} changes in cafe_nand.c together, and so on.

Actually, for such simple/automatic changes you can even group things in a single patch. I'm fine either way.

Quoted 22 lines
Quoted 19 lines
 drivers/mtd/nand/ams-delta.c     |  4 +--
 drivers/mtd/nand/cafe_nand.c     |  4 +--
 drivers/mtd/nand/cs553x_nand.c   |  8 ++---
 drivers/mtd/nand/diskonchip.c    | 76 +++++++++++++++++++++-------------------
 drivers/mtd/nand/fsl_elbc_nand.c |  4 +--
 drivers/mtd/nand/fsl_ifc_nand.c  |  2 +-
 drivers/mtd/nand/mxc_nand.c      |  2 +-
 drivers/mtd/nand/nand_bch.c      | 12 +++----
 drivers/mtd/nand/nandsim.c       | 10 +++---
 drivers/mtd/nand/r852.c          |  2 +-
 drivers/mtd/nand/r852.h          |  6 ++--
 drivers/mtd/nand/sh_flctl.c      |  2 +-
 drivers/mtd/nand/sm_common.c     |  5 ++-
 13 files changed, 70 insertions(+), 67 deletions(-)

--
2.7.4

Signature · 3 lines
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
maintainer
#21 lore raw
In reply to Shreeya Patel

Am Freitag, 16. Februar 2018, 17:50:09 CET schrieb Shreeya Patel:

Quoted 6 lines

This patchset removes all the log levels i.e. KERN_WARN, KERN_NOTICE, KERN_ERR, KERN_INFO, KERN_DEBUG used in the printk statements and replaces the printk statements with appropriate pr_*macros.
According to the kernel coding style, pr_*macro is the preferred way to print the message.

Beside of that, how does it improve the code?
Don't get me wrong, pr_* is the way to go for new code, but I don't think it is worth "fixing" in existing code and make working with git blame more painful.

Thanks,
//richard

#22 lore raw

Hey Richard,

Quoted 8 lines · Richard Weinberger

Am Freitag, 16. Februar 2018, 17:50:09 CET schrieb Shreeya Patel:

Quoted 6 lines

This patchset removes all the log levels i.e. KERN_WARN, KERN_NOTICE, KERN_ERR, KERN_INFO, KERN_DEBUG used in the printk statements and replaces the printk statements with appropriate pr_*macros.
According to the kernel coding style, pr_*macro is the preferred way to print the message.

Quoted 5 lines

Beside of that, how does it improve the code?
Don't get me wrong, pr_* is the way to go for new code, but I don't think it is worth "fixing" in existing code and make working with git blame more painful.

Shreeya's intention is to work on [1], migrating drivers to exec_op. As a first task, before being accepted, she is required to submit cleanup patches (or small tasks).

Since I couldn't come up with small tasks for MTD, I suggested starting with printk cleaning. So this was my idea.

Printk to pr_{} or dev_{} is not only aesthetical, it's also a consolidation change. Centralizing prints allows for other improvements.

See for instance Wolfram's work [2, 3].

In any case, does it hurt git-blame so much? It only affects the lines where the print is performed.

BTW, should you have ideas for small cleanup tasks in MTD, let us know.

[1] https://www.outreachy.org/communities/cfp/linux-kernel/project/migrate-nand-driver-to-new-exec_op-framework/
[2] https://elinux.org/Refactor_kernel_strings
[3] https://elinux.org/Refactor_kernel_strings

Thanks,

Signature · 2 lines
Ezequiel García, VanguardiaSur
www.vanguardiasur.com.ar
#23 lore raw

(Ccing MTD)

Quoted 43 lines · Ezequiel Garcia

Hey Richard,

Quoted 8 lines · Richard Weinberger

Am Freitag, 16. Februar 2018, 17:50:09 CET schrieb Shreeya Patel:

Quoted 6 lines

This patchset removes all the log levels i.e. KERN_WARN, KERN_NOTICE, KERN_ERR, KERN_INFO, KERN_DEBUG used in the printk statements and replaces the printk statements with appropriate pr_*macros.
According to the kernel coding style, pr_*macro is the preferred way to print the message.

Quoted 5 lines

Beside of that, how does it improve the code?
Don't get me wrong, pr_* is the way to go for new code, but I don't think it is worth "fixing" in existing code and make working with git blame more painful.

Shreeya's intention is to work on [1], migrating drivers to exec_op. As a first task, before being accepted, she is required to submit cleanup patches (or small tasks).

Since I couldn't come up with small tasks for MTD, I suggested starting with printk cleaning. So this was my idea.

Printk to pr_{} or dev_{} is not only aesthetical, it's also a consolidation change. Centralizing prints allows for other improvements.

See for instance Wolfram's work [2, 3].

In any case, does it hurt git-blame so much? It only affects the lines where the print is performed.

BTW, should you have ideas for small cleanup tasks in MTD, let us know.

[1] https://www.outreachy.org/communities/cfp/linux-kernel/project/migrate-nand-driver-to-new-exec_op-framework/
[2] https://elinux.org/Refactor_kernel_strings
[3] https://elinux.org/Refactor_kernel_strings

Thanks,
--
Ezequiel García, VanguardiaSur
www.vanguardiasur.com.ar

Signature · 2 lines
Ezequiel García, VanguardiaSur
www.vanguardiasur.com.ar
maintainer
#24 lore raw
In reply to Ezequiel Garcia

Ezequiel,

Am Freitag, 16. Februar 2018, 18:24:46 CET schrieb Ezequiel Garcia:

Quoted 11 lines

Hey Richard,

Quoted 8 lines · Richard Weinberger

Am Freitag, 16. Februar 2018, 17:50:09 CET schrieb Shreeya Patel:

Quoted 6 lines

This patchset removes all the log levels i.e. KERN_WARN, KERN_NOTICE, KERN_ERR, KERN_INFO, KERN_DEBUG used in the printk statements and replaces the printk statements with appropriate pr_*macros.
According to the kernel coding style, pr_*macro is the preferred way to print the message.

Quoted 8 lines
Quoted 4 lines

Beside of that, how does it improve the code?
Don't get me wrong, pr_* is the way to go for new code, but I don't think it is worth "fixing" in existing code and make working with git blame more painful.

Shreeya's intention is to work on [1], migrating drivers to exec_op. As a first task, before being accepted, she is required to submit cleanup patches (or small tasks).

Working on exec_op would be great! This is highly appreciated.

Quoted 10 lines

Since I couldn't come up with small tasks for MTD, I suggested starting with printk cleaning. So this was my idea.

Printk to pr_{} or dev_{} is not only aesthetical, it's also a consolidation change. Centralizing prints allows for other improvements.

See for instance Wolfram's work [2, 3].

In any case, does it hurt git-blame so much? It only affects the lines where the print is performed.

...and it pollutes patch context. So, from now on back/forward porting patches will cause much more rejects and need manual interaction.
In UBI we did a similar change a few years ago.

So, I'm not rejecting this patches but:

Told-you-so: Richard Weinberger <[email protected]>

Thanks,
//richard

#25 lore raw
Quoted 19 lines · On Fri, 16 Feb 2018 18:58:35 +0100 Richard Weinberger <[email protected]> wrote:

Ezequiel,

Am Freitag, 16. Februar 2018, 18:24:46 CET schrieb Ezequiel Garcia:

Quoted 16 lines

Hey Richard,

Quoted 12 lines · Richard Weinberger

Am Freitag, 16. Februar 2018, 17:50:09 CET schrieb Shreeya Patel:

Quoted 6 lines

This patchset removes all the log levels i.e. KERN_WARN, KERN_NOTICE, KERN_ERR, KERN_INFO, KERN_DEBUG used in the printk statements and replaces the printk statements with appropriate pr_*macros.
According to the kernel coding style, pr_*macro is the preferred way to print the message.

Beside of that, how does it improve the code?
Don't get me wrong, pr_* is the way to go for new code, but I don't think it is worth "fixing" in existing code and make working with git blame more painful.

Quoted 5 lines
Quoted 3 lines

Shreeya's intention is to work on [1], migrating drivers to exec_op. As a first task, before being accepted, she is required to submit cleanup patches (or small tasks).

Working on exec_op would be great! This is highly appreciated.

Indeed.

Quoted 7 lines
Quoted 7 lines

Since I couldn't come up with small tasks for MTD, I suggested starting with printk cleaning. So this was my idea.

Printk to pr_{} or dev_{} is not only aesthetical, it's also a consolidation change. Centralizing prints allows for other improvements.

Quoted 8 lines
Quoted 4 lines

See for instance Wolfram's work [2, 3].

In any case, does it hurt git-blame so much? It only affects the lines where the print is performed.

...and it pollutes patch context. So, from now on back/forward porting patches will cause much more rejects and need manual interaction.
In UBI we did a similar change a few years ago.

Oh, I didn't thought about this side-effect. Still, we're talking about really old drivers that are most of the time not maintained or poorly maintained.

Quoted 5 lines

So, I'm not rejecting this patches but:

Told-you-so: Richard Weinberger <[email protected]>

If I can get interesting contributions (like conversion of one or several drivers to ->exec_op()) I'm okay to pay the price and manually backport the potential fixes that do not apply cleanly because of these cosmetic changes ;-).

Signature · 3 lines
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
#26 lore raw
In reply to Ezequiel Garcia
Quoted 17 lines · Ezequiel Garcia

Hey Richard,

Quoted 8 lines · Richard Weinberger

Am Freitag, 16. Februar 2018, 17:50:09 CET schrieb Shreeya Patel:

Quoted 6 lines

This patchset removes all the log levels i.e. KERN_WARN, KERN_NOTICE, KERN_ERR, KERN_INFO, KERN_DEBUG used in the printk statements and replaces the printk statements with appropriate pr_*macros.
According to the kernel coding style, pr_*macro is the preferred way to print the message.

Quoted 5 lines

Beside of that, how does it improve the code?
Don't get me wrong, pr_* is the way to go for new code, but I don't think it is worth "fixing" in existing code and make working with git blame more painful.

Quoted 3 lines

Shreeya's intention is to work on [1], migrating drivers to exec_op. As a first task, before being accepted, she is required to submit cleanup patches (or small tasks).

"cleanup patches" should always start in the drivers/staging/ tree, to avoid bothering other subsytem maintainers. Please start there before moving on to the "tasks" as mentioned on the site that are picked by the mentors.

Don't skip the cleanup patches for no good reason please.

thanks,

greg k-h

#27 lore raw
Quoted 22 lines · Greg KH
Quoted 17 lines · Ezequiel Garcia

Hey Richard,

Quoted 8 lines · Richard Weinberger

Am Freitag, 16. Februar 2018, 17:50:09 CET schrieb Shreeya Patel:

Quoted 6 lines

This patchset removes all the log levels i.e. KERN_WARN, KERN_NOTICE, KERN_ERR, KERN_INFO, KERN_DEBUG used in the printk statements and replaces the printk statements with appropriate pr_*macros.
According to the kernel coding style, pr_*macro is the preferred way to print the message.

Quoted 5 lines

Beside of that, how does it improve the code?
Don't get me wrong, pr_* is the way to go for new code, but I don't think it is worth "fixing" in existing code and make working with git blame more painful.

Quoted 3 lines

Shreeya's intention is to work on [1], migrating drivers to exec_op. As a first task, before being accepted, she is required to submit cleanup patches (or small tasks).

Quoted 6 lines

"cleanup patches" should always start in the drivers/staging/ tree, to avoid bothering other subsytem maintainers. Please start there before moving on to the "tasks" as mentioned on the site that are picked by the mentors.

Don't skip the cleanup patches for no good reason please.

Actually, I told Shreeya that she could skip the initial phase because she has been doing some other work on kernel code off and on over the last few months. On the other hand, a generic change such as printk -> pr* or dev* could indeed have just been experimented with on staging drivers.

julia

Quoted 12 lines

thanks,

greg k-h

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20180216184832.GA9616%40kroah.com.
For more options, visit https://groups.google.com/d/optout.

#28 lore raw
In reply to Richard Weinberger

Hi Richard,

Quoted 8 lines · On Fri, 16 Feb 2018 18:19:40 +0100 Richard Weinberger <[email protected]> wrote:

Am Freitag, 16. Februar 2018, 17:50:09 CET schrieb Shreeya Patel:

Quoted 6 lines

This patchset removes all the log levels i.e. KERN_WARN, KERN_NOTICE, KERN_ERR, KERN_INFO, KERN_DEBUG used in the printk statements and replaces the printk statements with appropriate pr_*macros.
According to the kernel coding style, pr_*macro is the preferred way to print the message.

Quoted 4 lines

Beside of that, how does it improve the code?
Don't get me wrong, pr_* is the way to go for new code, but I don't think it is worth "fixing" in existing code and make working with git blame more painful.

That's true about git blame, though I doubt we'll find a bug in the printk message, and IIRC, there's an option to find the original offender even when cosmetic changes have happened in between.

Now, I'd like to explain a bit why I sometimes accept cosmetic/coding style patches and why I sometimes don't. When this is a first contribution, I consider this as a way for new comers to learn the patch submission/review process. But as soon as I start receiving a lot of cosmetic changes from the same contributor and I see the person does not move to more useful contributions I stop accepting her/his patches. I also tend to take patches from people who write coccinelle scripts, because they try to make things consistent across the whole source tree and most importantly, they know what they're doing :-).

Maybe I'm wrong in my reasoning, but I thought it was worth explaining the decision process ;-).

Regards,

Boris

Signature · 3 lines
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com