Skip to contentSkip to conversation

waf-samba: use new oe.utils.parallel_make_argument function instead of removed get_waf_parallel_make

PATCH In review Martin Jansa 4 participants 6 messages Feb 16, 2018 – Feb 17, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 waf-samba: use new oe.utils.parallel_make_argument function instead of removed get_waf_parallel_make

---
 meta-networking/classes/waf-samba.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-networking/classes/waf-samba.bbclass +1 -1
index e490176241..a63842cadc 100644
@@ -87,7 +87,7 @@ do_configure() {
 }
 
 do_compile () {
-    python ./buildtools/bin/waf ${@get_waf_parallel_make(d)}
+    python ./buildtools/bin/waf ${@oe.utils.parallel_make_argument(d, '-j%d', limit=64)}
 }
 
 do_install() {
Signature · 1 line
2.15.1
#1 lore raw
Quoted 11 lines · Martin Jansa
---
 meta-networking/classes/waf-samba.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta- renamed from meta-networking/classes/waf-samba.bbclass +0 -0

networking/classes/waf-samba.bbclass
index e490176241..a63842cadc 100644

meta-networking/classes/waf-samba.bbclass do_configure() { · line 91

Quoted 6 lines
meta-networking/classes/waf-samba.bbclass +1 -1
@@ -87,7 +87,7 @@ do_configure() {
 }
 
 do_compile () {
-    python ./buildtools/bin/waf ${@get_waf_parallel_make(d)}
+    python ./buildtools/bin/waf ${@oe.utils.parallel_make_argument(d
 , '-j%d', limit=64)}

Ah, beat me to it. Either way, I approve FWIW.

Quoted 6 lines
meta-networking/classes/waf-samba.bbclass +0 -0
 }
 

do_install() {

Signature · 1 line
2.15.1
#2 lore raw

This is just to fix the parsing ASAP, you can still send your updated change which removes the waf inherit completely.

Quoted 28 lines · Joshua Watt
Quoted 11 lines · Martin Jansa
---
 meta-networking/classes/waf-samba.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta- renamed from meta-networking/classes/waf-samba.bbclass +0 -0

networking/classes/waf-samba.bbclass
index e490176241..a63842cadc 100644

meta-networking/classes/waf-samba.bbclass do_configure() { · line 91

Quoted 6 lines
meta-networking/classes/waf-samba.bbclass +1 -1
@@ -87,7 +87,7 @@ do_configure() {
 }
 
 do_compile () {
-    python ./buildtools/bin/waf ${@get_waf_parallel_make(d)}
+    python ./buildtools/bin/waf ${@oe.utils.parallel_make_argument(d
 , '-j%d', limit=64)}

Ah, beat me to it. Either way, I approve FWIW.

Quoted 6 lines
meta-networking/classes/waf-samba.bbclass +0 -0
 }
 

do_install() {
--
2.15.1

#3 lore raw

Now libevent fails:

08:35:10
ERROR: ExpansionError during parsing /workdir/openembedded-core/../meta-openembedded/meta-networking/recipes-support/libtevent/libtevent_0.9.33.bb

08:35:10
Traceback (most recent call last):

08:35:10
bb.data_smart.ExpansionError: Failure expanding variable do_compile, expression was python ./buildtools/bin/waf ${@oe.utils.parallel_make_argument(d, '-j%d', limit=64)}

08:35:10 which triggered exception AttributeError: module 'oe.utils' has no attribute ‘parallel_make_argument'

Quoted 40 lines · Martin Jansa

This is just to fix the parsing ASAP, you can still send your updated change which removes the waf inherit completely.

Quoted 28 lines · Joshua Watt
Quoted 11 lines · Martin Jansa

---
meta-networking/classes/waf-samba.bbclass | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
meta- renamed from meta-networking/classes/waf-samba.bbclass +0 -0

networking/classes/waf-samba.bbclass
index e490176241..a63842cadc 100644

meta-networking/classes/waf-samba.bbclass do_configure() { · line 91

Quoted 6 lines
meta-networking/classes/waf-samba.bbclass +1 -1
@@ -87,7 +87,7 @@ do_configure() {
 }
 
 do_compile () {
-    python ./buildtools/bin/waf ${@get_waf_parallel_make(d)}
+    python ./buildtools/bin/waf ${@oe.utils.parallel_make_argument(d
 , '-j%d', limit=64)}

Ah, beat me to it. Either way, I approve FWIW.

Quoted 6 lines
meta-networking/classes/waf-samba.bbclass +0 -0
 }
 

do_install() {
--
2.15.1

Signature · 4 lines
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
#4 lore raw

On Feb 17, 2018 10:39, "Tim Orling" <[email protected]> wrote:

Now libevent fails:

08:35:10
ERROR: ExpansionError during parsing /workdir/openembedded-core/../ meta-openembedded/meta-networking/recipes-support/libtevent/ libtevent_0.9.33.bb

08:35:10
Traceback (most recent call last):

08:35:10
bb.data_smart.ExpansionError: Failure expanding variable do_compile,
expression was python ./buildtools/bin/waf
${@oe.utils.parallel_make_argument(d,
'-j%d', limit=64)}

08:35:10 which triggered exception AttributeError: module 'oe.utils' has no attribute ‘parallel_make_argument'

Make sure you have the latest oe-core

Quoted 6 lines · Martin Jansa

This is just to fix the parsing ASAP, you can still send your updated change which removes the waf inherit completely.

On Fri, Feb 16, 2018 at 11:22 PM, Joshua Watt <[email protected]>

Quoted 34 lines · wrote:
Quoted 15 lines · Martin Jansa
Quoted 13 lines

---
meta-networking/classes/waf-samba.bbclass | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
meta- renamed from meta-networking/classes/waf-samba.bbclass +0 -0

networking/classes/waf-samba.bbclass
index e490176241..a63842cadc 100644

meta-networking/classes/waf-samba.bbclass +0 -0
@@ -87,7 +87,7 @@ do_configure() {
 }
 
Quoted 14 lines

meta-networking/classes/waf-samba.bbclass do_configure() {

Quoted 4 lines
meta-networking/classes/waf-samba.bbclass +1 -1
 do_compile () {
-    python ./buildtools/bin/waf ${@get_waf_parallel_make(d)}
+    python ./buildtools/bin/waf ${@oe.utils.parallel_make_argument(d
 , '-j%d', limit=64)}

Ah, beat me to it. Either way, I approve FWIW.

Quoted 6 lines
meta-networking/classes/waf-samba.bbclass +0 -0
 }
 

do_install() {
--
2.15.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#5 lore raw

Right. I had backed out for meta-virtualization linux-yocto bbappends failures.

Quoted 74 lines · Joshua Watt

On Feb 17, 2018 10:39, "Tim Orling" <[email protected]> wrote:

Now libevent fails:

08:35:10
ERROR: ExpansionError during parsing /workdir/openembedded-core/../ meta-openembedded/meta-networking/recipes-support/libtevent/ libtevent_0.9.33.bb

08:35:10
Traceback (most recent call last):

08:35:10
bb.data_smart.ExpansionError: Failure expanding variable do_compile,
expression was python ./buildtools/bin/waf
${@oe.utils.parallel_make_argument(d,
'-j%d', limit=64)}

08:35:10 which triggered exception AttributeError: module 'oe.utils' has no attribute ‘parallel_make_argument'

Make sure you have the latest oe-core

Quoted 1 line

On Feb 16, 2018, at 3:10 PM, Martin Jansa <[email protected]>

Quoted 5 lines · wrote:

This is just to fix the parsing ASAP, you can still send your updated change which removes the waf inherit completely.

On Fri, Feb 16, 2018 at 11:22 PM, Joshua Watt <[email protected]>

Quoted 29 lines · wrote:
Quoted 15 lines · Martin Jansa
Quoted 13 lines

---
meta-networking/classes/waf-samba.bbclass | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
meta- renamed from meta-networking/classes/waf-samba.bbclass +0 -0

networking/classes/waf-samba.bbclass
index e490176241..a63842cadc 100644

meta-networking/classes/waf-samba.bbclass +0 -0
@@ -87,7 +87,7 @@ do_configure() {
 }
 
Quoted 14 lines

meta-networking/classes/waf-samba.bbclass do_configure() {

Quoted 4 lines
meta-networking/classes/waf-samba.bbclass +1 -1
 do_compile () {
-    python ./buildtools/bin/waf ${@get_waf_parallel_make(d)}
+    python ./buildtools/bin/waf ${@oe.utils.parallel_make_argument(d
 , '-j%d', limit=64)}

Ah, beat me to it. Either way, I approve FWIW.

Quoted 6 lines
meta-networking/classes/waf-samba.bbclass +0 -0
 }
 

do_install() {
--
2.15.1

Quoted 5 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel