Skip to contentSkip to conversation

i6300esb: fix build failure

PATCH In review Matteo Croce 3 participants 3 messages Feb 19, 2018 Watchdog device drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i6300esb: fix build failure

i6300esb uses fuctions defined in watchdog_core.c, and when CONFIG_WATCHDOG_CORE is not set we have this build error:

drivers/watchdog/i6300esb.o: In function `esb_remove':
i6300esb.c:(.text+0xcc): undefined reference to watchdog_unregister_device' drivers/watchdog/i6300esb.o: In function esb_probe':
i6300esb.c:(.text+0x2a1): undefined reference to watchdog_init_timeout' i6300esb.c:(.text+0x388): undefined reference to watchdog_register_device'
make: *** [Makefile:1029: vmlinux] Error 1

Fix this by selecting CONFIG_WATCHDOG_CORE when I6300ESB_WDT is set.

Fixes 7af4ac8772a8f ("watchdog: i6300esb: use the watchdog subsystem")
---
 drivers/watchdog/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/watchdog/Kconfig +1 -0
index aff773bcebdb..5e2fa5abe5ff 100644
@@ -1008,6 +1008,7 @@ config WAFER_WDT
 config I6300ESB_WDT
 	tristate "Intel 6300ESB Timer/Watchdog"
 	depends on PCI
+	select WATCHDOG_CORE
 	---help---
 	  Hardware driver for the watchdog timer built into the Intel
 	  6300ESB controller hub.
Signature · 1 line
2.14.3
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Matteo Croce

i6300esb uses fuctions defined in watchdog_core.c, and when CONFIG_WATCHDOG_CORE is not set we have this build error:

drivers/watchdog/i6300esb.o: In function `esb_remove':
i6300esb.c:(.text+0xcc): undefined reference to watchdog_unregister_device' drivers/watchdog/i6300esb.o: In function esb_probe':
i6300esb.c:(.text+0x2a1): undefined reference to watchdog_init_timeout' i6300esb.c:(.text+0x388): undefined reference to watchdog_register_device'
make: *** [Makefile:1029: vmlinux] Error 1

Quoted 4 lines

Fix this by selecting CONFIG_WATCHDOG_CORE when I6300ESB_WDT is set.

Fixes 7af4ac8772a8f ("watchdog: i6300esb: use the watchdog subsystem")
Quoted 17 lines
---
  drivers/watchdog/Kconfig | 1 +
  1 file changed, 1 insertion(+)
drivers/watchdog/Kconfig +1 -0
index aff773bcebdb..5e2fa5abe5ff 100644
@@ -1008,6 +1008,7 @@ config WAFER_WDT
  config I6300ESB_WDT
  	tristate "Intel 6300ESB Timer/Watchdog"
  	depends on PCI
+	select WATCHDOG_CORE
  	---help---
  	  Hardware driver for the watchdog timer built into the Intel
  	  6300ESB controller hub.
#2 lore raw
In reply to Matteo Croce
Quoted 2 lines · Matteo Croce

i6300esb uses fuctions defined in watchdog_core.c, and when CONFIG_WATCHDOG_CORE is not set we have this build error:

Hi Matteo,

Thanks for fixing this. FYI, the xen_wdt driver has a similar problem and I just sent a patch to linux-watchdog.

Best regards,
Radu Rendec