drm: drm_memory: fix compiler warning on 32-bit targets
Subsystems (2)
PATCH v2 1/1 drm: drm_memory: fix compiler warning on 32-bit targets
The end field of struct resource is resource_size_t, so on 32-bit targets, this is a 32-bit value. This results in a compiler warning of "warning: comparison of distinct pointer types lacks a cast". Fix it by making max_iomem resource_size_t to match the end field.
--- drivers/gpu/drm/drm_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/drm_memory.c +1 -1
@@ -153,7 +153,7 @@ EXPORT_SYMBOL(drm_legacy_ioremapfree);u64 drm_get_max_iomem (void ) {struct resource *tmp; -u64 max_iomem =0 ; +resource_size_t max_iomem =0 ;for (tmp = iomem_resource.child; tmp; tmp = tmp->sibling) { max_iomem =max (max_iomem, tmp->end);
Signature · 6 lines
2.7.4 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 2 lines · David Lechner
The end field of struct resource is
resource_size_t, so on 32-bit targets, this is a 32-bit value.
That's not quite correct. resource_size_t is a phys_addr_t, which can be 64-bit also on 32-bit targets (if they've got CONFIG_PHYS_ADDR_T_64BIT enabled, which is used for example with PAE).
With that fixed:
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel