smsc75xx: fix smsc75xx_set_features()
PATCH 1/1 smsc75xx: fix smsc75xx_set_features()
From: Eric Dumazet <[email protected]>
If an attempt is made to disable RX checksums, USB adapter is changed but netdev->features is not, because smsc75xx_set_features() returns a non zero value.
This throws errors from netdev_rx_csum_fault() :
<devname>: hw csum failure
Signed-off-by Eric Dumazet <[email protected]>
Cc Steve Glendinning <[email protected]>
---
drivers/net/usb/smsc75xx.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
drivers/net/usb/smsc75xx.c +4 -3
@@ -954,10 +954,11 @@ static int smsc75xx_set_features(struct net_device *netdev,/* it's racing here! */ ret =smsc75xx_write_reg (dev,RFE_CTL , pdata->rfe_ctl); -if (ret <0 ) +if (ret <0 ) {netdev_warn (dev->net,"Error writing RFE_CTL\n" ); - -return ret; +return ret; + } +return 0 ; }static int smsc75xx_wait_ready (struct usbnet *dev,int in_pm)
From: Eric Dumazet <[email protected]>
Date: Tue, 20 Feb 2018 21:42:26 -0800
Quoted 11 lines
From: Eric Dumazet <[email protected]>
If an attempt is made to disable RX checksums, USB adapter is changed but
netdev->featuresis not, becausesmsc75xx_set_features()returns a non zero value.This throws errors from
netdev_rx_csum_fault():
<devname>: hw csum failureSigned-off-by Eric Dumazet <[email protected]>Cc Steve Glendinning <[email protected]>
Applied, thanks Eric.