patch to fs/proc/base.c

PATCH Nikita Danilov 2 participants 2 messages Jul 20, 2001 Proc filesystem

lore

Share & tools

lore

Nikita Danilov

author

2001-07-20 14:00 UTC #0 lore raw

Hello,

following patch cures oopses in 2.4.7-pre9 when proc_pid_make_inode() is called on task with task->mm == NULL.

Linus, please apply, if you haven't got a bunch of equivalent patches already, which is doubtful.

Nikita.
------------------------------------------------------------

fs/proc/base.c Fri Jul 20 17:03:23 2001 renamed from fs/proc/base.c Fri Jul 20 14:57:55 2001 +1 -1

@@ -670,7 +670,7 @@ static struct inode *proc_pid_make_inode
        inode->u.proc_i.task = task;
        inode->i_uid = 0;
        inode->i_gid = 0;
-       if (ino == PROC_PID_INO || task->mm->dumpable) {
+       if (ino == PROC_PID_INO || (task->mm && task->mm->dumpable)) {
                inode->i_uid = task->euid;
                inode->i_gid = task->egid;
        }

------------------------------------------------------------

Matti Aarnio

2001-07-20 14:06 UTC #1 lore raw

Quoted 5 lines · Nikita Danilov

Date: Fri, 20 Jul 2001 17:59:51 +0400
From: Nikita Danilov <[email protected]>
To: [email protected]
Subject: patch to fs/proc/base.c

Quoted 7 lines

Hello,
following patch cures oopses in 2.4.7-pre9 when proc_pid_make_inode() is called on task with task->mm == NULL.
Linus, please apply, if you haven't got a bunch of equivalent patches already, which is doubtful.

He won't. For two reasons:
- There is better fix which Linus himself posted some hours ago
- Linus does not read (directly) linux-kernel list.

Quoted 1 line

Nikita.

/Matti Aarnio