clocksource: arc_timer: update some comments
Subsystems (2)
PATCH 1/1 clocksource: arc_timer: update some comments
TIMER0 interrupt ACK is different for ARC700 and HS3x cores.
This came to light in some internal discussions and it is nice to have this documented rather than digging up the PRM (Prog Ref Manual) again
Signed-off-by Vineet Gupta <vgupta at synopsys.com>
--- drivers/clocksource/arc_timer.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)
drivers/clocksource/arc_timer.c +8 -3
@@ -251,9 +251,14 @@ static irqreturn_t timer_irq_handler(int irq, void *dev_id)int irq_reenable =clockevent_state_periodic (evt);/* -* Any write to CTRL reg ACks the interrupt, we rewrite the -* Count when [N]ot [H]alted bit. -* And re-arm it if perioid by [I]nterrupt [E]nable bit +* 1. ACK the interrupt +* - For ARC700, any write to CTRL reg ACKs it, so just rewrite +* Count when [N]ot [H]alted bit. +* - For HS3x, it is a bit subtle. On taken count-down interrupt, +* IP bit [3] is set, which needs to be cleared for ACK'ing. +* The write below can only update the other two bits, hence +* explicitly clears IP bit +* 2. Re-arm interrupt if periodic by writing to IE bit [0] */ write_aux_reg (ARC_REG_TIMER0_CTRL , irq_reenable |TIMER_CTRL_NH );
Signature · 1 line
2.7.4
tip-bot for Vineet Gupta
merge bot[tip:timers/urgent] clocksource/drivers/arc_timer: Update some comments
clocksource/drivers/arc_timer: Update some comments
Commit-ID: a4f538573cd72e7961f4ec5eb13c171f5add58ec Gitweb: https://git.kernel.org/tip/a4f538573cd72e7961f4ec5eb13c171f5add58ec Author: Vineet Gupta <[email protected]> AuthorDate: Wed, 21 Feb 2018 11:31:31 -0800 Committer: Thomas Gleixner <[email protected]> CommitDate: Wed, 28 Feb 2018 13:55:14 +0100
clocksource/drivers/arc_timer: Update some comments
TIMER0 interrupt ACK is different for ARC700 and HS3x cores.
This came to light in some internal discussions and it is nice to have this documented rather than digging up the PRM (Programmers Reference Manual).
Signed-off-by Vineet Gupta <[email protected]>
Signed-off-by Thomas Gleixner <[email protected]>
Cc Daniel Lezcano <[email protected]>
Cc Vineet Gupta <[email protected]>
--- drivers/clocksource/arc_timer.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)
drivers/clocksource/arc_timer.c +8 -3
@@ -251,9 +251,14 @@ static irqreturn_t timer_irq_handler(int irq, void *dev_id)int irq_reenable =clockevent_state_periodic (evt);/* -* Any write to CTRL reg ACks the interrupt, we rewrite the -* Count when [N]ot [H]alted bit. -* And re-arm it if perioid by [I]nterrupt [E]nable bit +* 1. ACK the interrupt +* - For ARC700, any write to CTRL reg ACKs it, so just rewrite +* Count when [N]ot [H]alted bit. +* - For HS3x, it is a bit subtle. On taken count-down interrupt, +* IP bit [3] is set, which needs to be cleared for ACK'ing. +* The write below can only update the other two bits, hence +* explicitly clears IP bit +* 2. Re-arm interrupt if periodic by writing to IE bit [0] */ write_aux_reg (ARC_REG_TIMER0_CTRL , irq_reenable |TIMER_CTRL_NH );