hw/net: Remove unnecessary header includes
PATCH 1/1 hw/net: Remove unnecessary header includes
Headers like "hw/loader.h" and "qemu/sockets.h" are not needed in the hw/net/*.c files. And Some other headers are included via other headers already, so we can drop them, too.
Signed-off-by Thomas Huth <[email protected]>
--- hw/net/e1000.c | 1 - hw/net/lance.c | 3 --- hw/net/ne2000.c | 2 -- hw/net/pcnet-pci.c | 1 - hw/net/pcnet.c | 1 - hw/net/rtl8139.c | 2 -- hw/net/xgmac.c | 1 - 7 files changed, 11 deletions(-)
hw/net/e1000.c +0 -1
@@ -30,7 +30,6 @@#include "hw/pci/pci.h" #include "net/net.h" #include "net/checksum.h" -#include "hw/loader.h" #include "sysemu/sysemu.h" #include "sysemu/dma.h" #include "qemu/iov.h"
hw/net/lance.c +0 -3
@@ -36,10 +36,7 @@*/ #include "qemu/osdep.h" -#include "hw/sysbus.h" -#include "net/net.h" #include "qemu/timer.h" -#include "qemu/sockets.h" #include "hw/sparc/sparc32_dma.h" #include "hw/net/lance.h" #include "trace.h"
hw/net/ne2000.c +0 -2
@@ -23,10 +23,8 @@*/ #include "qemu/osdep.h" #include "hw/pci/pci.h" -#include "net/net.h" #include "net/eth.h" #include "ne2000.h" -#include "hw/loader.h" #include "sysemu/sysemu.h" /* debug NE2000 card */
hw/net/pcnet-pci.c +0 -1
@@ -30,7 +30,6 @@#include "qemu/osdep.h" #include "hw/pci/pci.h" #include "net/net.h" -#include "hw/loader.h" #include "qemu/timer.h" #include "sysemu/dma.h" #include "sysemu/sysemu.h"
hw/net/pcnet.c +0 -1
@@ -40,7 +40,6 @@#include "net/net.h" #include "net/eth.h" #include "qemu/timer.h" -#include "qemu/sockets.h" #include "sysemu/sysemu.h" #include "trace.h"
hw/net/rtl8139.c +0 -2
@@ -58,9 +58,7 @@#include "qemu/timer.h" #include "net/net.h" #include "net/eth.h" -#include "hw/loader.h" #include "sysemu/sysemu.h" -#include "qemu/iov.h" /* debug RTL8139 card */ //#define DEBUG_RTL8139 1
hw/net/xgmac.c +0 -1
@@ -28,7 +28,6 @@#include "hw/sysbus.h" #include "qemu/log.h" #include "net/net.h" -#include "net/checksum.h" #ifdef DEBUG_XGMAC #define DEBUGF_BRK(message, args...) do { \
Signature · 1 line
1.8.3.1
Jason Wang
AppliedQuoted 100 lines · Thomas Huth
Headers like "
hw/loader.h" and "qemu/sockets.h" are not needed in the hw/net/*.c files. And Some other headers are included via other headers already, so we can drop them, too.Signed-off-by Thomas Huth <[email protected]>--- hw/net/e1000.c | 1 - hw/net/lance.c | 3 --- hw/net/ne2000.c | 2 -- hw/net/pcnet-pci.c | 1 - hw/net/pcnet.c | 1 - hw/net/rtl8139.c | 2 -- hw/net/xgmac.c | 1 - 7 files changed, 11 deletions(-)hw/net/e1000.c +0
-1@@ -30,7 +30,6 @@#include "hw/pci/pci.h" #include "net/net.h" #include "net/checksum.h" -#include "hw/loader.h" #include "sysemu/sysemu.h" #include "sysemu/dma.h" #include "qemu/iov.h" hw/net/lance.c +0
-3@@ -36,10 +36,7 @@*/ #include "qemu/osdep.h" -#include "hw/sysbus.h" -#include "net/net.h" #include "qemu/timer.h" -#include "qemu/sockets.h" #include "hw/sparc/sparc32_dma.h" #include "hw/net/lance.h" #include "trace.h" hw/net/ne2000.c +0
-2@@ -23,10 +23,8 @@*/ #include "qemu/osdep.h" #include "hw/pci/pci.h" -#include "net/net.h" #include "net/eth.h" #include "ne2000.h" -#include "hw/loader.h" #include "sysemu/sysemu.h" /* debug NE2000 card */ hw/net/pcnet-pci.c +0
-1@@ -30,7 +30,6 @@#include "qemu/osdep.h" #include "hw/pci/pci.h" #include "net/net.h" -#include "hw/loader.h" #include "qemu/timer.h" #include "sysemu/dma.h" #include "sysemu/sysemu.h" hw/net/pcnet.c +0
-1@@ -40,7 +40,6 @@#include "net/net.h" #include "net/eth.h" #include "qemu/timer.h" -#include "qemu/sockets.h" #include "sysemu/sysemu.h" #include "trace.h" hw/net/rtl8139.c +0
-2@@ -58,9 +58,7 @@#include "qemu/timer.h" #include "net/net.h" #include "net/eth.h" -#include "hw/loader.h" #include "sysemu/sysemu.h" -#include "qemu/iov.h" /* debug RTL8139 card */ //#define DEBUG_RTL8139 1 hw/net/xgmac.c +0
-0
hw/net/xgmac.c line 33
Quoted 7 lines
hw/net/xgmac.c +0
-1@@ -28,7 +28,6 @@#include "hw/sysbus.h" #include "qemu/log.h" #include "net/net.h" -#include "net/checksum.h" #ifdef DEBUG_XGMAC #define DEBUGF_BRK(message, args...) do { \
Applied.
Thanks