Skip to contentSkip to conversation

clk: imx6sl: Include "common.h" header file

PATCH In review Fabio Estevam 1 participant 2 messages Feb 22, 2018

Subsystems (3)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 clk: imx6sl: Include "common.h" header file

From: Fabio Estevam <[email protected]>

The prototype for the imx6sl_set_wait_clk() function is provided by the "common.h" header file, so include it to avoid the following sparse warning:

drivers/clk/imx/clk-imx6sl.c:163:6: warning: symbol 'imx6sl_set_wait_clk' was not declared. Should it be static?

---
 drivers/clk/imx/clk-imx6sl.c | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/imx/clk-imx6sl.c +1 -0
index 9642cdf..bdda77b 100644
@@ -16,6 +16,7 @@
 #include <dt-bindings/clock/imx6sl-clock.h>
 
 #include "clk.h"
+#include "common.h"
 
 #define CCSR			0xc
 #define BM_CCSR_PLL1_SW_CLK_SEL	(1 << 2)
Signature · 1 line
2.7.4
author reviewer
#1 lore raw
Quoted 18 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The prototype for the imx6sl_set_wait_clk() function is provided by the "common.h" header file, so include it to avoid the following sparse warning:

drivers/clk/imx/clk-imx6sl.c:163:6: warning: symbol 'imx6sl_set_wait_clk' was not declared. Should it be static?

---
 drivers/clk/imx/clk-imx6sl.c | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/imx/clk-imx6sl.c +0 -0
index 9642cdf..bdda77b 100644

drivers/clk/imx/clk-imx6sl.c line 19

Quoted 4 lines
drivers/clk/imx/clk-imx6sl.c +1 -0
@@ -16,6 +16,7 @@
 #include <dt-bindings/clock/imx6sl-clock.h>
 
 #include "clk.h"
+#include "common.h"

Ops, this causes issues. Please ignore this one.