Skip to contentSkip to conversation

Patch "IB/hfi1: Initialize bth1 in 16B rc ack builder" has been added to the 4.14-stable tree

PATCH [email protected] 1 participant 1 message Feb 23, 2018

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

IB/hfi1: Initialize bth1 in 16B rc ack builder

to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:

     ib-hfi1-initialize-bth1-in-16b-rc-ack-builder.patch

and it can be found in the queue-4.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Fri Feb 23 11:45:09 CET 2018

From: Dennis Dalessandro <[email protected]>
Date: Tue, 14 Nov 2017 04:34:23 -0800
Subject: IB/hfi1: Initialize bth1 in 16B rc ack builder

From: Dennis Dalessandro <[email protected]>

[ Upstream commit 8935780b9f7bbad0f2eb5dd43f61ba7b509a1575 ]

It is possible the bth1 variable could be used uninitialized so going ahead and giving it a default value.

Otherwise we leak stack memory to the network.

Fixes 5b6cabb0db77 ("IB/hfi1: Add 16B RC/UC support")
---
 drivers/infiniband/hw/hfi1/rc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/hfi1/rc.c +1 -1
@@ -815,7 +815,7 @@ static inline void hfi1_make_rc_ack_16B(
 	struct hfi1_pportdata *ppd = ppd_from_ibp(ibp);
 	struct hfi1_16b_header *hdr = &opa_hdr->opah;
 	struct ib_other_headers *ohdr;
-	u32 bth0, bth1;
+	u32 bth0, bth1 = 0;
 	u16 len, pkey;
 	u8 becn = !!is_fecn;
 	u8 l4 = OPA_16B_L4_IB_LOCAL;

Patches currently in stable-queue which might be from [email protected] are

queue-4.14/ib-hfi1-initialize-bth1-in-16b-rc-ack-builder.patch