Skip to contentSkip to conversation

Patch "usb: musb: fix compilation warning on unused function" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Feb 23, 2018

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

usb: musb: fix compilation warning on unused function

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
usb-musb-fix-compilation-warning-on-unused-function.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From c8bd2ac3b4c6c84c4a7cdceaed626247db698ab2 Mon Sep 17 00:00:00 2001

From: =?UTF-8?q?J=C3=A9r=C3=A9my=20Lefaure?= <[email protected]>
Date: Tue, 3 Jan 2017 18:13:49 -0600
Subject: usb: musb: fix compilation warning on unused function
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Jérémy Lefaure <[email protected]>

commit c8bd2ac3b4c6c84c4a7cdceaed626247db698ab2 upstream.

The function musb_run_resume_work is called only when CONFIG_PM is enabled. So this function should not be defined when CONFIG_PM is disabled. Otherwise the compiler issues a warning:

drivers/usb/musb/musb_core.c:2057:12: error: ‘musb_run_resume_work’ defined but not used [-Werror=unused-function]
static int musb_run_resume_work(struct musb *musb)

            ^~~~~~~~~~~~~~~~~~~~
---
 drivers/usb/musb/musb_core.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/usb/musb/musb_core.c +2 -0
@@ -2043,6 +2043,7 @@ struct musb_pending_work {
 	struct list_head node;
 };
 
+#ifdef CONFIG_PM
 /*
  * Called from musb_runtime_resume(), musb_resume(), and
  * musb_queue_resume_work(). Callers must take musb->lock.
@@ -2070,6 +2071,7 @@ static int musb_run_resume_work(struct m
 
 	return error;
 }
+#endif
 
 /*
  * Called to run work if device is active or else queue the work to happen

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/x86-vm86-fix-unused-variable-warning-if-thp-is-disabled.patch queue-4.9/shmem-fix-compilation-warnings-on-unused-functions.patch queue-4.9/usb-musb-fix-compilation-warning-on-unused-function.patch