Skip to contentSkip to conversation

drm/amd/pp: Print more info when smu message failed on Vega10

PATCH In review Rex Zhu 2 participants 2 messages Feb 24, 2018 – Feb 26, 2018 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

Rex Zhu

author
#0 lore raw

PATCH 1/1 drm/amd/pp: Print more info when smu message failed on Vega10

Change-Id Ifaa7058a4682bafeeef68e78bfcff26012ba71c1
---
 drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c +1 -1
index 70dd5f8..1bdeeeb 100644
@@ -168,7 +168,7 @@ int vega10_send_msg_to_smc_with_parameter(struct pp_hwmgr *hwmgr,
 
 	ret = vega10_wait_for_response(hwmgr);
 	if (ret != 1)
-		pr_err("Failed to send message: 0x%x, ret value: 0x%x\n", msg, ret);
+		pr_err("Failed message: 0x%x, input parameter is %x, error code: 0x%x\n", msg, parameter, ret);
 
 	return 0;
 }
Signature · 6 lines
1.9.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1519473709-7196-1-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org

Reviewed-by
#2 lore raw
Quoted 2 lines · Rex Zhu
Change-Id Ifaa7058a4682bafeeef68e78bfcff26012ba71c1
Quoted 20 lines
---
 drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c +1 -2
index 70dd5f8..1bdeeeb 100644
@@ -168,7 +168,7 @@ int vega10_send_msg_to_smc_with_parameter(struct pp_hwmgr *hwmgr,
 
        ret = vega10_wait_for_response(hwmgr);
        if (ret != 1)
-               pr_err("Failed to send message: 0x%x, ret value: 0x%x\n", msg, ret);
+               pr_err("Failed message: 0x%x, input parameter is %x, error code: 0x%x\n", msg, parameter, ret);
 
        return 0;
 }
--

1.9.1

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx