Skip to contentSkip to conversation

Patch "extcon: int3496: process id-pin first so that we start with the right status" has been added to the 4.15-stable tree

PATCH [email protected] 1 participant 1 message Feb 26, 2018

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

extcon: int3496: process id-pin first so that we start with the right status

to the 4.15-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
extcon-int3496-process-id-pin-first-so-that-we-start-with-the-right-status.patch
and it can be found in the queue-4.15 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 0434352d3d2e950cf5e743f6062abd87de22f960 Mon Sep 17 00:00:00 2001

From: Hans de Goede <[email protected]>
Date: Tue, 13 Feb 2018 20:25:50 +0100
Subject: extcon: int3496: process id-pin first so that we start with the right status

From: Hans de Goede <[email protected]>

commit 0434352d3d2e950cf5e743f6062abd87de22f960 upstream.

Some other drivers may be waiting for our extcon to show-up, exiting their probe methods with -EPROBE_DEFER until we show up.

These drivers will typically get the cable state directly after getting the extcon, this commit changes the int3496 code to wait for the initial processing of the id-pin to complete before exiting probe() with 0, which will cause devices waiting on the defered probe to get reprobed.

This fixes a race where the initial work might still be running while other drivers were already calling extcon_get_state().

Fixes 2f556bdb9f2e ("extcon: int3496: Add Intel INT3496 ACPI ... driver")
---
 drivers/extcon/extcon-intel-int3496.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/extcon/extcon-intel-int3496.c +2 -1
@@ -153,8 +153,9 @@ static int int3496_probe(struct platform
 		return ret;
 	}
 
-	/* queue initial processing of id-pin */
+	/* process id-pin so that we start with the right status */
 	queue_delayed_work(system_wq, &data->work, 0);
+	flush_delayed_work(&data->work);
 
 	platform_set_drvdata(pdev, data);
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.15/extcon-int3496-process-id-pin-first-so-that-we-start-with-the-right-status.patch