Patch "usb: phy: mxs: Fix NULL pointer dereference on i.MX23/28" has been added to the 4.15-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
usb: phy: mxs: Fix NULL pointer dereference on i.MX23/28
to the 4.15-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
usb-phy-mxs-fix-null-pointer-dereference-on-i.mx23-28.patch
and it can be found in the queue-4.15 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
499350865387f8b8c40a9e9453a9a7eb3cec5dc4Mon Sep 17 00:00:00 2001
From: Fabio Estevam <[email protected]>
Date: Thu, 18 Jan 2018 00:22:45 -0200
Subject: usb: phy: mxs: Fix NULL pointer dereference on i.MX23/28
From: Fabio Estevam <[email protected]>
commit 499350865387f8b8c40a9e9453a9a7eb3cec5dc4 upstream.
Commit e93650994a95 ("usb: phy: mxs: add usb charger type detection") causes the following kernel hang on i.MX28:
[ 2.207973] usbcore: registered new interface driver usb-storage [ 2.235659] Unable to handle kernel NULL pointer dereference at virtual address 00000188 [ 2.244195] pgd = (ptrval) [ 2.246994] [00000188] *pgd=00000000 [ 2.250676] Internal error: Oops: 5 [#1] ARM [ 2.254979] Modules linked in: [ 2.258089] CPU: 0 PID: 1 Comm: swapper Not tainted 4.15.0-rc8-next-20180117-00002-g75d5f21 #7 [ 2.266724] Hardware name: Freescale MXS (Device Tree) [ 2.271921] PC is at regmap_read+0x0/0x5c [ 2.275977] LR is at mxs_phy_charger_detect+0x34/0x1dc
mxs_phy_charger_detect() makes accesses to the anatop registers via regmap, however i.MX23/28 do not have such registers, which causes a NULL pointer dereference.
Fix the issue by doing a NULL check on the 'regmap' pointer.
--- drivers/usb/phy/phy-mxs-usb.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/usb/phy/phy-mxs-usb.c +3 -0
@@ -602,6 +602,9 @@ static enum usb_charger_type mxs_phy_chavoid __iomem *base = phy->io_priv;enum usb_charger_type chgr_type =UNKNOWN_TYPE ; +if (!regmap) +return UNKNOWN_TYPE ; +if (mxs_charger_data_contact_detect (mxs_phy))return chgr_type;
Patches currently in stable-queue which might be from [email protected] are
queue-4.15/usb-phy-mxs-fix-null-pointer-dereference-on-i.mx23-28.patch