Skip to contentSkip to conversation

mm: Provide consistent declaration for num_poisoned_pages

PATCH In review Guenter Roeck 2 participants 3 messages Feb 26, 2018 – Feb 27, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm: Provide consistent declaration for num_poisoned_pages

clang reports the following compile warning.

In file included from mm/vmscan.c:56:
./include/linux/swapops.h:327:22: warning:
section attribute is specified on redeclared variable [-Wsection]

extern atomic_long_t num_poisoned_pages __read_mostly;
                     ^
./include/linux/mm.h:2585:22: note: previous declaration is here
extern atomic_long_t num_poisoned_pages;
                     ^

Let's use __read_mostly everywhere.

Cc Matthias Kaehlcke <[email protected]>
---
 include/linux/mm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/mm.h +1 -1
index ad06d42adb1a..bd4bd59f02c1 100644
@@ -2582,7 +2582,7 @@ extern int get_hwpoison_page(struct page *page);
 extern int sysctl_memory_failure_early_kill;
 extern int sysctl_memory_failure_recovery;
 extern void shake_page(struct page *p, int access);
-extern atomic_long_t num_poisoned_pages;
+extern atomic_long_t num_poisoned_pages __read_mostly;
 extern int soft_offline_page(struct page *page, int flags);
 
 
Signature · 7 lines
2.7.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
#1 lore raw
Quoted 24 lines · Guenter Roeck

clang reports the following compile warning.

In file included from mm/vmscan.c:56:
./include/linux/swapops.h:327:22: warning:
section attribute is specified on redeclared variable [-Wsection]

extern atomic_long_t num_poisoned_pages __read_mostly;
                     ^
./include/linux/mm.h:2585:22: note: previous declaration is here
extern atomic_long_t num_poisoned_pages;
                     ^

Let's use __read_mostly everywhere.

Cc Matthias Kaehlcke <[email protected]>
---
 include/linux/mm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/mm.h +0 -0
index ad06d42adb1a..bd4bd59f02c1 100644

include/linux/mm.h extern int get_hwpoison_page(struct page *page); · line 2588

Quoted 8 lines
include/linux/mm.h +1 -1
@@ -2582,7 +2582,7 @@ extern int get_hwpoison_page(struct page *page);
 extern int sysctl_memory_failure_early_kill;
 extern int sysctl_memory_failure_recovery;
 extern void shake_page(struct page *p, int access);
-extern atomic_long_t num_poisoned_pages;
+extern atomic_long_t num_poisoned_pages __read_mostly;
 extern int soft_offline_page(struct page *page, int flags);
 
 

No objection to the patch, of course, but I'm wondering if it's (1) the only such clang compile warning for mm/, and (2) if the re-declaration in mm.h could be avoided by including swapops.h?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

#2 lore raw
Quoted 21 lines · David Rientjes
Quoted 19 lines · Guenter Roeck

clang reports the following compile warning.

In file included from mm/vmscan.c:56:
./include/linux/swapops.h:327:22: warning:
section attribute is specified on redeclared variable [-Wsection]

extern atomic_long_t num_poisoned_pages __read_mostly;
                      ^
./include/linux/mm.h:2585:22: note: previous declaration is here
extern atomic_long_t num_poisoned_pages;
                      ^

Let's use __read_mostly everywhere.

Cc Matthias Kaehlcke <[email protected]>
---
  include/linux/mm.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 16 lines

include/linux/mm.h extern int get_hwpoison_page(struct page *page); · line 2588

Quoted 13 lines
include/linux/mm.h +1 -1
index ad06d42adb1a..bd4bd59f02c1 100644
@@ -2582,7 +2582,7 @@ extern int get_hwpoison_page(struct page *page);
  extern int sysctl_memory_failure_early_kill;
  extern int sysctl_memory_failure_recovery;
  extern void shake_page(struct page *p, int access);
-extern atomic_long_t num_poisoned_pages;
+extern atomic_long_t num_poisoned_pages __read_mostly;
  extern int soft_offline_page(struct page *page, int flags);
 
 

No objection to the patch, of course, but I'm wondering if it's (1) the only such clang compile warning for mm/, and (2) if the re-declaration in

It is the only one I recall seeing in mm/ while testing the clang/retpoline changes with ToT clang 7.0.0, but then I didn't pay too close attention.

Quoted 2 lines

mm.h could be avoided by including swapops.h?

Another alternative would be to remove the extern fom swapops.h and have swapops.h include mm.h instead. I chose the least invasive change since I didn't want to risk breaking some other build (after all, maybe there was a reason for declaring num_poisoned_pages in two include files).

Guenter

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>