tests/libqos: Check for valid dev pointer when looking for PCI devices
PATCH 1/1 tests/libqos: Check for valid dev pointer when looking for PCI devices
dev could be NULL if the PCI device can not be found due to some reasons, so we must not dereference the pointer in this case.
Signed-off-by Thomas Huth <[email protected]>
--- tests/libqos/virtio-pci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
tests/libqos/virtio-pci.c +3 -1
@@ -315,7 +315,9 @@ QVirtioPCIDevice *qvirtio_pci_device_find(QPCIBus *bus, uint16_t device_type)qvirtio_pci_foreach (bus, device_type, false,0 , qvirtio_pci_assign_device, &dev); - dev->vdev.bus = &qvirtio_pci; +if (dev) { + dev->vdev.bus = &qvirtio_pci; + }return dev; }
Signature · 1 line
1.8.3.1
Stefan Hajnoczi
AppliedQuoted 7 lines · Thomas Huth
dev could be NULL if the PCI device can not be found due to some reasons, so we must not dereference the pointer in this case.
Signed-off-by Thomas Huth <[email protected]>--- tests/libqos/virtio-pci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
There is no maintainer for tests/libqos/virtio-pci.c in MAINTAINERS so I'll take this patch.
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan