Skip to contentSkip to conversation

Documentation: Update ncurses package names for menuconfig

PATCH Superseded Arvind Prasanna 3 participants 15 messages Feb 28, 2018 – Mar 1, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Documentation: Update ncurses package names for menuconfig

The package name is ncurses-devel for Redhat based distros and libncurses-devel for Debian based distros.

---
 scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
scripts/kconfig/lxdialog/check-lxdialog.sh +2 -1
index a10bd9d..4353e40 100755
@@ -55,7 +55,8 @@ EOF
 	    echo " *** required header files."                            1>&2
 	    echo " *** 'make menuconfig' requires the ncurses libraries." 1>&2
 	    echo " *** "                                                  1>&2
-	    echo " *** Install ncurses (ncurses-devel) and try again."    1>&2
+	    echo " *** Install ncurses (ncurses-devel or libncurses-dev   1>&2
+	           *** depending on your distribution) and try again."    1>&2
 	    echo " *** "                                                  1>&2
 	    exit 1
 	fi
Signature · 1 line
2.7.4
#1 lore raw

2018-02-28 15:59 GMT+09:00 Arvind Prasanna <[email protected]>:

Quoted 23 lines

The package name is ncurses-devel for Redhat based distros and libncurses-devel for Debian based distros.

---
 scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
scripts/kconfig/lxdialog/check-lxdialog.sh +2 -2
index a10bd9d..4353e40 100755
@@ -55,7 +55,8 @@ EOF
            echo " *** required header files."                            1>&2
            echo " *** 'make menuconfig' requires the ncurses libraries." 1>&2
            echo " *** "                                                  1>&2
-           echo " *** Install ncurses (ncurses-devel) and try again."    1>&2
+           echo " *** Install ncurses (ncurses-devel or libncurses-dev   1>&2
+                  *** depending on your distribution) and try again."    1>&2
            echo " *** "                                                  1>&2
            exit 1
        fi
--
Quoted 1 line

2.7.4

'echo' is missing in the line you added.
So, the error message will be displayed like follows:

*** Unable to find the ncurses libraries or the *** required header files.
*** 'make menuconfig' requires the ncurses libraries.
***
*** Install ncurses (ncurses-devel or libncurses-dev 1>&2
*** depending on your distribution) and try again.
***

I fixed it up locally, and applied to linux-kbuild/kconfig. Thanks!

Quoted 4 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 2 lines
Best Regards
Masahiro Yamada
#2 lore raw

PATCH v2 1/1 Documentation: Update ncurses package names for menuconfig

The package name is ncurses-devel for Redhat based distros and libncurses-devel for Debian based distros.

---

Changes in v2:
- Add a missing echo as pointed out by one of the reviewers.

 scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
scripts/kconfig/lxdialog/check-lxdialog.sh +2 -1
index a10bd9d..6c0bcd9 100755
@@ -55,7 +55,8 @@ EOF
 	    echo " *** required header files."                            1>&2
 	    echo " *** 'make menuconfig' requires the ncurses libraries." 1>&2
 	    echo " *** "                                                  1>&2
-	    echo " *** Install ncurses (ncurses-devel) and try again."    1>&2
+	    echo " *** Install ncurses (ncurses-devel or libncurses-dev " 1>&2
+	    echo " *** depending on your distribution) and try again."    1>&2
 	    echo " *** "                                                  1>&2
 	    exit 1
 	fi
Signature · 1 line
2.7.4
#3 lore raw

Hi Masahiro Yamada:

I appreciate you having a look at my patch. I am still learning the ropes contributing to open source. I have sent out version 2 of the patch with the fix.

Thanks,

Arvind.

Quoted 38 lines · Arvind Prasanna

The package name is ncurses-devel for Redhat based distros and libncurses-devel for Debian based distros.

---

Changes in v2:
- Add a missing echo as pointed out by one of the reviewers.

 scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
scripts/kconfig/lxdialog/check-lxdialog.sh +0 -0
index a10bd9d..6c0bcd9 100755
@@ -55,7 +55,8 @@ EOF
            echo " *** required header files."

1>&2
echo " *** 'make menuconfig' requires the ncurses libraries."
1>&2

            echo " *** "

1>&2
- echo " *** Install ncurses (ncurses-devel) and try again."
1>&2
+ echo " *** Install ncurses (ncurses-devel or libncurses-dev "
1>&2
+ echo " *** depending on your distribution) and try again."
1>&2

            echo " *** "

1>&2
exit 1
fi
--
2.7.4

#4 lore raw
In reply to Arvind Prasanna
Quoted 2 lines · Arvind Prasanna

The package name is ncurses-devel for Redhat based distros and libncurses-devel for Debian based distros.

      ^^^^^^^^^^^^^^^^ That's not what the patch says. Please clarify.
Quoted 12 lines
---
 scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
scripts/kconfig/lxdialog/check-lxdialog.sh +0 -0
index a10bd9d..4353e40 100755

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 62

Quoted 9 lines
scripts/kconfig/lxdialog/check-lxdialog.sh +2 -1
@@ -55,7 +55,8 @@ EOF
 	    echo " *** required header files."                            1>&2
 	    echo " *** 'make menuconfig' requires the ncurses libraries." 1>&2
 	    echo " *** "                                                  1>&2
-	    echo " *** Install ncurses (ncurses-devel) and try again."    1>&2
+	    echo " *** Install ncurses (ncurses-devel or libncurses-dev   1>&2
+	           *** depending on your distribution) and try again."    1>&2
 	    echo " *** "                                                  1>&2
 	    exit 1
 	fi

thanks,

Signature · 1 line
~Randy
#5 lore raw

Hi Randy:

Quoted 2 lines · Arvind Prasanna

The package name is ncurses-devel for Redhat based distros and libncurses-devel for Debian based distros.

The above lines are part of the commit message and the patch says to install either ncurses-devel or libncurses-dev based on the user's Linux distribution. Would you prefer I add my commit message lines to the patch as well?

Thanks,

Arvind.

Quoted 40 lines · Randy Dunlap
Quoted 2 lines · Arvind Prasanna

The package name is ncurses-devel for Redhat based distros and libncurses-devel for Debian based distros.

      ^^^^^^^^^^^^^^^^ That's not what the patch says. Please clarify.

Review

Quoted 7 lines
---
 scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
(quoted diff) +0 -0

b/scripts/kconfig/lxdialog/check-lxdialog.sh

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 55

Quoted 5 lines

index a10bd9d..4353e40 100755

scripts/kconfig/lxdialog/check-lxdialog.sh +0 -0
@@ -55,7 +55,8 @@ EOF
          echo " *** required header files."

1>&2

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 56

Quoted 1 line
scripts/kconfig/lxdialog/check-lxdialog.sh +0 -0
          echo " *** 'make menuconfig' requires the ncurses libraries."

1>&2

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 57

Quoted 1 line
scripts/kconfig/lxdialog/check-lxdialog.sh +0 -0
          echo " *** "

1>&2

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 58

Quoted 1 line
scripts/kconfig/lxdialog/check-lxdialog.sh +0 -1
-         echo " *** Install ncurses (ncurses-devel) and try again."

1>&2

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 58

Quoted 1 line
scripts/kconfig/lxdialog/check-lxdialog.sh +1 -0
+         echo " *** Install ncurses (ncurses-devel or libncurses-dev

1>&2

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 59

Quoted 1 line
scripts/kconfig/lxdialog/check-lxdialog.sh +1 -0
+                *** depending on your distribution) and try again."

1>&2

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 60

Quoted 1 line
scripts/kconfig/lxdialog/check-lxdialog.sh +0 -0
          echo " *** "

1>&2

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 62

Quoted 3 lines
scripts/kconfig/lxdialog/check-lxdialog.sh +0 -0
          exit 1
      fi

thanks,
--
~Randy

#6 lore raw
Quoted 13 lines · Arvind Prasanna

Hi Randy:

Quoted 2 lines · Arvind Prasanna

The package name is ncurses-devel for Redhat based distros and libncurses-devel for Debian based distros.

The above lines are part of the commit message and the patch says to install either ncurses-devel or libncurses-dev based on the user's Linux distribution. Would you prefer I add my commit message lines to the patch as well?

Thanks,

Arvind.

Quoted 7 lines

On Wed, Feb 28, 2018 at 12:31 PM, Randy Dunlap <[email protected] <mailto:[email protected]>> wrote:

On 02/27/2018 10:59 PM, Arvind Prasanna wrote:
> The package name is ncurses-devel for Redhat based distros > and libncurses-devel for Debian based distros.

      ^^^^^^^^^^^^^^^^ That's not what the patch says. Please clarify.

For Debian-based distros, is it libncurses-devel (above) or is it libncurses-dev (as below)? [latter is without the ending "el"]

And what about the other few hundred distros? (rhetorical)

Quoted 20 lines
Quoted 20 lines
Signed-off-by Arvind Prasanna <[email protected] <mailto:[email protected]>>

---
  scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-

  1 file changed, 2 insertions(+), 1 deletion(-)
scripts/kconfig/lxdialog/check-lxdialog.sh +0 -0
index a10bd9d..4353e40 100755
@@ -55,7 +55,8 @@ EOF

           echo " *** required header files."                            1>&2 echo " *** 'make menuconfig' requires the ncurses libraries." 1>&2 echo " *** "                                                  1>&2 -         echo " *** Install ncurses (ncurses-devel) and try again."    1>&2 +         echo " *** Install ncurses (ncurses-devel or libncurses-dev   1>&2 +                *** depending on your distribution) and try again."    1>&2 echo " *** "                                                  1>&2 exit 1
       fi

Signature · 1 line
~Randy
#7 lore raw

If a Linux distribution is RPM based, the package name is libncurses-dev and if it is Debian based, it is ncurses-devel. Here are some examples:

# cat /etc/os-release | grep "PRETTY_NAME"
PRETTY_NAME="Debian GNU/Linux 9 (stretch)"
# apt-cache search libncurses-dev
libncurses5-dev - developer's libraries for ncurses
# cat /etc/os-release | grep "PRETTY_NAME"
PRETTY_NAME="Ubuntu 16.04.3 LTS"
# apt-cache search libncurses-dev
libncurses5-dev - developer's libraries for ncurses
# cat /etc/os-release | grep "PRETTY_NAME"
PRETTY_NAME="CentOS Linux 7 (Core)"
# yum search ncurses-devel
====================================================================== N/S
matched: ncurses-devel
=======================================================================
ncurses-devel.i686 : Development files for the ncurses library
ncurses-devel.x86_64 : Development files for the ncurses library
# cat /etc/os-release | grep "PRETTY_NAME"
PRETTY_NAME="Fedora 27 (Twenty Seven)"
# yum search ncurses-devel
Last metadata expiration check: 0:05:07 ago on Wed Feb 28 19:20:24 2018.
================================================================== Name
Exactly Matched: ncurses-devel
==================================================================
ncurses-devel.i686 : Development files for the ncurses library
ncurses-devel.x86_64 : Development files for the ncurses library

I have tried RPM based and Debian based linux distros as they are extensively used and widely distributed. For other (independent) Linux distributions, it is possible they have their own names for the ncurses development package.

Thanks,

- Arvind.

Quoted 68 lines · Randy Dunlap
Quoted 7 lines · Arvind Prasanna

Hi Randy:

Quoted 2 lines · Arvind Prasanna

The package name is ncurses-devel for Redhat based distros and libncurses-devel for Debian based distros.

The above lines are part of the commit message and the patch says to

install either ncurses-devel or libncurses-dev based on the user's Linux distribution. Would you prefer I add my commit message lines to the patch as well?

Quoted 7 lines

Thanks,

Arvind.

On Wed, Feb 28, 2018 at 12:31 PM, Randy Dunlap <[email protected]

Quoted 6 lines · <mailto:[email protected]>> wrote:

On 02/27/2018 10:59 PM, Arvind Prasanna wrote:
> The package name is ncurses-devel for Redhat based distros > and libncurses-devel for Debian based distros.

^^^^^^^^^^^^^^^^ That's not what the patch says. Please

clarify.

For Debian-based distros, is it libncurses-devel (above) or is it libncurses-dev (as below)? [latter is without the ending "el"]

And what about the other few hundred distros? (rhetorical)

Quoted 2 lines
Quoted 2 lines

[email protected]>>

Quoted 5 lines

Review

Quoted 5 lines
---
 scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
(quoted diff) +0 -0

b/scripts/kconfig/lxdialog/check-lxdialog.sh

Quoted 5 lines

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 55

Quoted 5 lines

index a10bd9d..4353e40 100755

scripts/kconfig/lxdialog/check-lxdialog.sh +0 -0
@@ -55,7 +55,8 @@ EOF
          echo " *** required header files."
      1>&2
Quoted 1 line

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 56

Quoted 1 line
scripts/kconfig/lxdialog/check-lxdialog.sh +0 -0
          echo " *** 'make menuconfig' requires the ncurses

libraries." 1>&2

Quoted 1 line

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 57

Quoted 1 line
scripts/kconfig/lxdialog/check-lxdialog.sh +0 -0
          echo " *** "
      1>&2
Quoted 1 line

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 58

Quoted 1 line
scripts/kconfig/lxdialog/check-lxdialog.sh +0 -1
-         echo " *** Install ncurses (ncurses-devel) and try

again." 1>&2

Quoted 1 line

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 58

Quoted 1 line
scripts/kconfig/lxdialog/check-lxdialog.sh +1 -0
+         echo " *** Install ncurses (ncurses-devel or

libncurses-dev 1>&2

Quoted 1 line

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 59

Quoted 1 line
scripts/kconfig/lxdialog/check-lxdialog.sh +1 -0
+                *** depending on your distribution) and try

again." 1>&2

Quoted 1 line

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 60

Quoted 1 line
scripts/kconfig/lxdialog/check-lxdialog.sh +0 -0
          echo " *** "
      1>&2
Quoted 2 lines

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 62

Quoted 2 lines
scripts/kconfig/lxdialog/check-lxdialog.sh +0 -0
          exit 1
      fi

--
~Randy

#8 lore raw

If it is not possible or difficult to identify the ncurses development package name for all existing and future Linux distributions, one possibility is that we can change the message to say "Please install the ncurses library development package and try again". This way we don't have to specify a package name.

Quoted 116 lines · Arvind Prasanna

If a Linux distribution is RPM based, the package name is libncurses-dev and if it is Debian based, it is ncurses-devel. Here are some examples:

# cat /etc/os-release | grep "PRETTY_NAME"
PRETTY_NAME="Debian GNU/Linux 9 (stretch)"
# apt-cache search libncurses-dev
libncurses5-dev - developer's libraries for ncurses
# cat /etc/os-release | grep "PRETTY_NAME"
PRETTY_NAME="Ubuntu 16.04.3 LTS"
# apt-cache search libncurses-dev
libncurses5-dev - developer's libraries for ncurses
# cat /etc/os-release | grep "PRETTY_NAME"
PRETTY_NAME="CentOS Linux 7 (Core)"
# yum search ncurses-devel
======================================================================
N/S matched: ncurses-devel ==============================
=========================================
ncurses-devel.i686 : Development files for the ncurses library
ncurses-devel.x86_64 : Development files for the ncurses library
# cat /etc/os-release | grep "PRETTY_NAME"
PRETTY_NAME="Fedora 27 (Twenty Seven)"
# yum search ncurses-devel
Last metadata expiration check: 0:05:07 ago on Wed Feb 28 19:20:24 2018.
================================================================== Name
Exactly Matched: ncurses-devel ==============================
====================================
ncurses-devel.i686 : Development files for the ncurses library
ncurses-devel.x86_64 : Development files for the ncurses library

I have tried RPM based and Debian based linux distros as they are extensively used and widely distributed. For other (independent) Linux distributions, it is possible they have their own names for the ncurses development package.

Thanks,

- Arvind.

Quoted 68 lines · Randy Dunlap
Quoted 7 lines · Arvind Prasanna

Hi Randy:

Quoted 2 lines · Arvind Prasanna

The package name is ncurses-devel for Redhat based distros and libncurses-devel for Debian based distros.

The above lines are part of the commit message and the patch says to

install either ncurses-devel or libncurses-dev based on the user's Linux distribution. Would you prefer I add my commit message lines to the patch as well?

Quoted 7 lines

Thanks,

Arvind.

On Wed, Feb 28, 2018 at 12:31 PM, Randy Dunlap <[email protected]

Quoted 6 lines · <mailto:[email protected]>> wrote:

On 02/27/2018 10:59 PM, Arvind Prasanna wrote:
> The package name is ncurses-devel for Redhat based distros > and libncurses-devel for Debian based distros.

^^^^^^^^^^^^^^^^ That's not what the patch says. Please

clarify.

For Debian-based distros, is it libncurses-devel (above) or is it libncurses-dev (as below)? [latter is without the ending "el"]

And what about the other few hundred distros? (rhetorical)

Quoted 2 lines
Quoted 2 lines

[email protected]>>

Quoted 5 lines

Review

Quoted 5 lines
---
 scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
(quoted diff) +0 -0

b/scripts/kconfig/lxdialog/check-lxdialog.sh

Quoted 5 lines

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 55

Quoted 5 lines

index a10bd9d..4353e40 100755

scripts/kconfig/lxdialog/check-lxdialog.sh +0 -0
@@ -55,7 +55,8 @@ EOF
          echo " *** required header files."
      1>&2
Quoted 1 line

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 56

Quoted 1 line
scripts/kconfig/lxdialog/check-lxdialog.sh +0 -0
          echo " *** 'make menuconfig' requires the ncurses

libraries." 1>&2

Quoted 1 line

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 57

Quoted 1 line
scripts/kconfig/lxdialog/check-lxdialog.sh +0 -0
          echo " *** "
      1>&2
Quoted 1 line

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 58

Quoted 1 line
scripts/kconfig/lxdialog/check-lxdialog.sh +0 -1
-         echo " *** Install ncurses (ncurses-devel) and try

again." 1>&2

Quoted 1 line

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 58

Quoted 1 line
scripts/kconfig/lxdialog/check-lxdialog.sh +1 -0
+         echo " *** Install ncurses (ncurses-devel or

libncurses-dev 1>&2

Quoted 1 line

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 59

Quoted 1 line
scripts/kconfig/lxdialog/check-lxdialog.sh +1 -0
+                *** depending on your distribution) and try

again." 1>&2

Quoted 1 line

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 60

Quoted 1 line
scripts/kconfig/lxdialog/check-lxdialog.sh +0 -0
          echo " *** "
      1>&2
Quoted 2 lines

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 62

Quoted 2 lines
scripts/kconfig/lxdialog/check-lxdialog.sh +0 -0
          exit 1
      fi

--
~Randy

#9 lore raw

Hi,

I think that you are missing my point, so let me start over and try to clarify it.

In the patch description, it says "libncurses-devel" (not libncurses-dev).

In the patch itself, it says libncurses-dev (not libncurses-devel).

I suspect that one of these is incorrect. Which one is it?

Thanks.
~~~~~~~~~~~~~~

The package name is ncurses-devel for Redhat based distros and libncurses-devel for Debian based distros.

---
 scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
scripts/kconfig/lxdialog/check-lxdialog.sh +2 -1
index a10bd9d..4353e40 100755
@@ -55,7 +55,8 @@ EOF
 	    echo " *** required header files."                            1>&2
 	    echo " *** 'make menuconfig' requires the ncurses libraries." 1>&2
 	    echo " *** "                                                  1>&2
-	    echo " *** Install ncurses (ncurses-devel) and try again."    1>&2
+	    echo " *** Install ncurses (ncurses-devel or libncurses-dev   1>&2
+	           *** depending on your distribution) and try again."    1>&2
 	    echo " *** "                                                  1>&2
 	    exit 1
 	fi
Signature · 1 line
~Randy
#10 lore raw

Hi Randy:

Apologies. I now understand what you are referring to. My commit message is incorrect. The correct package names are ncurses-devel and libncurses-dev. Thank you for pointing this out. I will send a patch for this.

Thanks,

Arvind.

Quoted 49 lines · Randy Dunlap

Hi,

I think that you are missing my point, so let me start over and try to clarify it.

In the patch description, it says "libncurses-devel" (not libncurses-dev).

In the patch itself, it says libncurses-dev (not libncurses-devel).

I suspect that one of these is incorrect. Which one is it?

Thanks.
~~~~~~~~~~~~~~

The package name is ncurses-devel for Redhat based distros and libncurses-devel for Debian based distros.

---
 scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
scripts/kconfig/lxdialog/check-lxdialog.sh +0 -0
index a10bd9d..4353e40 100755
@@ -55,7 +55,8 @@ EOF
            echo " *** required header files."

1>&2
echo " *** 'make menuconfig' requires the ncurses libraries."
1>&2

            echo " *** "

1>&2
- echo " *** Install ncurses (ncurses-devel) and try again."
1>&2

scripts/kconfig/lxdialog/check-lxdialog.sh +2 -0
+           echo " *** Install ncurses (ncurses-devel or libncurses-dev
 1>&2
+                  *** depending on your distribution) and try again."

1>&2

            echo " *** "

1>&2
exit 1
fi

--
~Randy

#11 lore raw

PATCH v3 1/1 Documentation: Update ncurses package names for menuconfig

The package name is ncurses-devel for Redhat based distros and libncurses-dev for Debian based distros.

---

Changes in v3:
- Fix a package name in the commit message.

Changes in v2:
- Add a missing echo as pointed out by one of the reviewers.

 scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
 scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
scripts/kconfig/lxdialog/check-lxdialog.sh +2 -1
index a10bd9d..6c0bcd9 100755
@@ -55,7 +55,8 @@ EOF
 	    echo " *** required header files."                            1>&2
 	    echo " *** 'make menuconfig' requires the ncurses libraries." 1>&2
 	    echo " *** "                                                  1>&2
-	    echo " *** Install ncurses (ncurses-devel) and try again."    1>&2
+	    echo " *** Install ncurses (ncurses-devel or libncurses-dev " 1>&2
+	    echo " *** depending on your distribution) and try again."    1>&2
 	    echo " *** "                                                  1>&2
 	    exit 1
 	fi
Signature · 1 line
2.7.4
Acked-by on v3 1/1
#12 lore raw
Quoted 4 lines · Arvind Prasanna

The package name is ncurses-devel for Redhat based distros and libncurses-dev for Debian based distros.

Thanks. Looks good to me.

Quoted 29 lines

---

Changes in v3:
- Fix a package name in the commit message.

Changes in v2:
- Add a missing echo as pointed out by one of the reviewers.

 scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
 scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
scripts/kconfig/lxdialog/check-lxdialog.sh +2 -1
index a10bd9d..6c0bcd9 100755
@@ -55,7 +55,8 @@ EOF
 	    echo " *** required header files."                            1>&2
 	    echo " *** 'make menuconfig' requires the ncurses libraries." 1>&2
 	    echo " *** "                                                  1>&2
-	    echo " *** Install ncurses (ncurses-devel) and try again."    1>&2
+	    echo " *** Install ncurses (ncurses-devel or libncurses-dev " 1>&2
+	    echo " *** depending on your distribution) and try again."    1>&2
 	    echo " *** "                                                  1>&2
 	    exit 1
 	fi
Signature · 1 line
~Randy
#13 lore raw

Thank you very much!

Regards,

Arvind.

Quoted 53 lines · Randy Dunlap
Quoted 4 lines · Arvind Prasanna

The package name is ncurses-devel for Redhat based distros and libncurses-dev for Debian based distros.

Thanks. Looks good to me.

Quoted 8 lines

---

Changes in v3:
- Fix a package name in the commit message.

Changes in v2:
- Add a missing echo as pointed out by one of the reviewers.

Review

Quoted 7 lines
 scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
 scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
(quoted diff) +0 -0

b/scripts/kconfig/lxdialog/check-lxdialog.sh

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 55

Quoted 5 lines

index a10bd9d..6c0bcd9 100755

scripts/kconfig/lxdialog/check-lxdialog.sh +0 -0
@@ -55,7 +55,8 @@ EOF
          echo " *** required header files."

1>&2

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 56

Quoted 1 line
scripts/kconfig/lxdialog/check-lxdialog.sh +0 -0
          echo " *** 'make menuconfig' requires the ncurses libraries."

1>&2

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 57

Quoted 1 line
scripts/kconfig/lxdialog/check-lxdialog.sh +0 -0
          echo " *** "

1>&2

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 58

Quoted 1 line
scripts/kconfig/lxdialog/check-lxdialog.sh +0 -1
-         echo " *** Install ncurses (ncurses-devel) and try again."

1>&2

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 58

Quoted 1 line
scripts/kconfig/lxdialog/check-lxdialog.sh +1 -0
+         echo " *** Install ncurses (ncurses-devel or libncurses-dev "

1>&2

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 59

Quoted 1 line
scripts/kconfig/lxdialog/check-lxdialog.sh +1 -0
+         echo " *** depending on your distribution) and try again."

1>&2

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 60

Quoted 1 line
scripts/kconfig/lxdialog/check-lxdialog.sh +0 -0
          echo " *** "

1>&2

scripts/kconfig/lxdialog/check-lxdialog.sh EOF · line 62

Quoted 3 lines
scripts/kconfig/lxdialog/check-lxdialog.sh +0 -0
          exit 1
      fi

--
~Randy

#14 lore raw
In reply to Randy Dunlap

2018-03-01 6:47 GMT+09:00 Randy Dunlap <[email protected]>:

Quoted 10 lines · Arvind Prasanna
Quoted 4 lines

The package name is ncurses-devel for Redhat based distros and libncurses-dev for Debian based distros.

Thanks. Looks good to me.

Randy, thanks! Eagle eyes!

I will replace it with v3.

Signature · 2 lines
Best Regards
Masahiro Yamada