Patch "nvme: check hw sectors before setting chunk sectors" has been added to the 4.14-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
nvme: check hw sectors before setting chunk sectors
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
nvme-check-hw-sectors-before-setting-chunk-sectors.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Wed Feb 28 16:23:28 CET 2018
From: Keith Busch <[email protected]>
Date: Thu, 14 Dec 2017 11:20:14 -0700
Subject: nvme: check hw sectors before setting chunk sectors
From: Keith Busch <[email protected]>
[ Upstream commit 249159c5f15812140fa216f9997d799ac0023a1f ]
Some devices with IDs matching the "stripe" quirk don't actually have this quirk, and don't have an MDTS value. When MDTS is not set, the driver sets the max sectors to UINT_MAX, which is not a power of 2, hitting a BUG_ON from blk_queue_chunk_sectors. This patch skips setting chunk sectors for such devices.
--- drivers/nvme/host/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/nvme/host/core.c +2 -1
@@ -1515,7 +1515,8 @@ static void nvme_set_queue_limits(structblk_queue_max_hw_sectors (q, ctrl->max_hw_sectors);blk_queue_max_segments (q,min_t (u32, max_segments,USHRT_MAX )); } -if (ctrl->quirks &NVME_QUIRK_STRIPE_SIZE ) +if ((ctrl->quirks &NVME_QUIRK_STRIPE_SIZE ) && +is_power_of_2 (ctrl->max_hw_sectors))blk_queue_chunk_sectors (q, ctrl->max_hw_sectors);blk_queue_virt_boundary (q, ctrl->page_size -1 );if (ctrl->vwc &NVME_CTRL_VWC_PRESENT )
Patches currently in stable-queue which might be from [email protected] are
queue-4.14/nvme-check-hw-sectors-before-setting-chunk-sectors.patch