Skip to contentSkip to conversation

Patch "nvme-fc: remove double put reference if admin connect fails" has been added to the 4.14-stable tree

PATCH [email protected] 1 participant 1 message Feb 28, 2018

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

nvme-fc: remove double put reference if admin connect fails

to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
nvme-fc-remove-double-put-reference-if-admin-connect-fails.patch
and it can be found in the queue-4.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Wed Feb 28 16:23:28 CET 2018

From: James Smart <[email protected]>
Date: Wed, 29 Nov 2017 15:11:37 -0800
Subject: nvme-fc: remove double put reference if admin connect fails

From: James Smart <[email protected]>

[ Upstream commit 4596e752db02d47038cd7c965419789ab15d1985 ]

There are two put references in the failure case of initial create_association. The first put actually frees the controller, thus the second put references freed memory.

Remove the unnecessary 2nd put.

---
 drivers/nvme/host/fc.c |    1 -
 1 file changed, 1 deletion(-)
drivers/nvme/host/fc.c +0 -1
@@ -2876,7 +2876,6 @@ nvme_fc_init_ctrl(struct device *dev, st
 
 		/* initiate nvme ctrl ref counting teardown */
 		nvme_uninit_ctrl(&ctrl->ctrl);
-		nvme_put_ctrl(&ctrl->ctrl);
 
 		/* Remove core ctrl ref. */
 		nvme_put_ctrl(&ctrl->ctrl);

Patches currently in stable-queue which might be from [email protected] are

queue-4.14/nvme-fc-remove-double-put-reference-if-admin-connect-fails.patch