Patch "RDMA/netlink: Fix locking around __ib_get_device_by_index" has been added to the 4.14-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
RDMA/netlink: Fix locking around __ib_get_device_by_index
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
rdma-netlink-fix-locking-around-__ib_get_device_by_index.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Wed Feb 28 16:23:28 CET 2018
From: Leon Romanovsky <[email protected]>
Date: Mon, 1 Jan 2018 13:07:15 +0200
Subject: RDMA/netlink: Fix locking around __ib_get_device_by_index
From: Leon Romanovsky <[email protected]>
[ Upstream commit f8978bd95cf92f869f3d9b34c1b699f49253b8c6 ]
Holding locks is mandatory when calling __ib_device_get_by_index, otherwise there are races during the list iteration with device removal.
Since the locks are static to device.c, __ib_device_get_by_index can never be called correctly by any user out side the file.
Make the function static and provide a safe function that gets the correct locks and returns a kref'd pointer. Fix all callers.
--- drivers/infiniband/core/core_priv.h | 2 - drivers/infiniband/core/device.c | 18 +++++++++++- drivers/infiniband/core/nldev.c | 54 ++++++++++++++++++++++++------------ 3 files changed, 54 insertions(+), 20 deletions(-)
drivers/infiniband/core/core_priv.h +1 -1
@@ -314,7 +314,7 @@ static inline int ib_mad_enforce_securit }#endif -struct ib_device *__ib_device_get_by_index (u32 ifindex); +struct ib_device *ib_device_get_by_index (u32 ifindex);/* RDMA device netlink */ void nldev_init (void );void nldev_exit (void );
drivers/infiniband/core/device.c +17 -1
@@ -134,7 +134,7 @@ static int ib_device_check_mandatory(strreturn 0 ; } -struct ib_device *__ib_device_get_by_index (u32 index) +static struct ib_device *__ib_device_get_by_index (u32 index) {struct ib_device *device;
@@ -145,6 +145,22 @@ struct ib_device *__ib_device_get_by_indreturn NULL ; } +/* +* Caller is responsible to return refrerence count by calling put_device() +*/ +struct ib_device *ib_device_get_by_index (u32 index) +{ +struct ib_device *device; + +down_read (&lists_rwsem); + device =__ib_device_get_by_index (index); +if (device) +get_device (&device->dev); + +up_read (&lists_rwsem); +return device; +} +static struct ib_device *__ib_device_get_by_name (const char *name) {struct ib_device *device;
drivers/infiniband/core/nldev.c +36 -18
108 lines not on this page · raw message
Patches currently in stable-queue which might be from [email protected] are
queue-4.14/ib-mlx4-fix-mlx4_ib_alloc_mr-error-flow.patch queue-4.14/rdma-netlink-fix-locking-around-__ib_get_device_by_index.patch