ixgbe: Add receive length error counter.
Subsystems (2)
PATCH 1/1 ixgbe: Add receive length error counter.
ixgbe enabled rlec counter and the rx_error used it. We can export the counter directly via ethtool -S ethX.
--- drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c +1 -0
@@ -97,6 +97,7 @@ struct ixgbe_stats { {"tx_heartbeat_errors", IXGBE_NETDEV_STAT(tx_heartbeat_errors)}, {"tx_timeout_count", IXGBE_STAT(tx_timeout_count)}, {"tx_restart_queue", IXGBE_STAT(restart_queue)}, + {"rx_length_errors", IXGBE_STAT(stats.rlec)}, {"rx_long_length_errors", IXGBE_STAT(stats.roc)}, {"rx_short_length_errors", IXGBE_STAT(stats.ruc)}, {"tx_flow_control_xon", IXGBE_STAT(stats.lxontxc)},
Signature · 1 line
1.8.3.1
PATCH 1/1 ixgbe: Add receive length error counter.
Quoted 7 lines · Tonghao Zhang
ixgbe enabled rlec counter and the
rx_errorused it. We can export the counter directly via ethtool -S ethX.Signed-off-by Tonghao Zhang <[email protected]>--- drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 1 + 1 file changed, 1 insertion(+)
A minor nitpick, your patch title/subject ending in a period which is
not needed or wanted. Patch titles/subjects should not be complete
sentences, so they do not need punctuation at the end.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20180228/2b61432d/attachment.asc>
PATCH 1/1 ixgbe: Add receive length error counter.
Quoted 4 lines · Jeff Kirsher
Quoted 3 lines · Tonghao Zhang
ixgbe enabled rlec counter and the
rx_errorused it. We can export the counter directly via ethtool -S ethX.
Quoted 8 lines
Quoted 4 lines
Signed-off-by Tonghao Zhang <[email protected]>--- drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 1 + 1 file changed, 1 insertion(+)A minor nitpick, your patch title/subject ending in a period which is not needed or wanted. Patch titles/subjects should not be complete sentences, so they do not need punctuation at the end.
Jeff, thanks for your tips.
Bowers
PATCH 1/1 ixgbe: Add receive length error counter.
In reply to Tonghao ZhangQuoted 7 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Tonghao Zhang
Sent: Wednesday, February 28, 2018 3:59 AM
To: intel-wired-lan at osuosl.org
Subject: [Intel-wired-lan] [PATCH] ixgbe: Add receive length error counter.
Quoted 7 lines
ixgbe enabled rlec counter and the
rx_errorused it. We can export the counter directly via ethtool -S ethX.Signed-off-by Tonghao Zhang <[email protected]>--- drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 1 + 1 file changed, 1 insertion(+)