Skip to contentSkip to conversation

Management: warn about password only when the option is in use

PATCH In review [email protected]... 2 participants 2 messages Mar 5, 2018

lore
Share & tools
lore

[email protected]...

author
#0 lore raw

PATCH 1/1 Management: warn about password only when the option is in use

From: Selva Nair <[email protected]...>

Signed-off-by Selva Nair <[email protected]...>
---
 src/openvpn/options.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
src/openvpn/options.c +2 -1
index f7995c6..c5bce9f 100644
@@ -2171,7 +2171,8 @@ options_postprocess_verify_ce(const struct options *options, const struct connec
         msg(M_USAGE, "--management-client-(user|group) can only be used on unix domain sockets");
     }
 
-    if (!(options->management_flags & MF_UNIX_SOCK)
+    if (options->management_addr
+        && !(options->management_flags & MF_UNIX_SOCK)
         && (!options->management_user_pass))
     {
         msg(M_WARN, "WARNING: Using --management on a TCP port WITHOUT "
Signature · 1 line
2.1.4
Acked-by on v1 1/1
#1 lore raw

"Oops, stupid us..." - how fortunate that Jonathan stopped us before integrating this into 2.4.5 :-)

Acked-by Gert Doering <[email protected]...>

(Stared at code, and actually tested all cases)

Your patch has been applied to the master branch.

commit 5961250e776194a411a8dfc1670c5c0c73107bf8 (master) commit 0533bd715bc3865019a718fbe512f86e0a907103 (release/2.4)

Author: Selva Nair
Date:   Mon Mar 5 10:28:00 2018 -0500
     Management: warn about password only when the option is in use

     Signed-off-by: Selva Nair <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg16631.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering