regmap: debugfs: Disambiguate dummy debugfs file name
Subsystems (2)
PATCH v2 1/1 regmap: debugfs: Disambiguate dummy debugfs file name
From: Fabio Estevam <[email protected]>
Since commit 9b947a13e7f6 ("regmap: use debugfs even when no device") allows the usage of regmap debugfs even when there is no device associated, which causes several warnings like this:
(NULL device *): Failed to create debugfs directory
This happens when the debugfs file name is 'dummy'.
The first dummy debugfs creation works fine, but subsequent creations fail as they have all the same name.
Disambiguate the 'dummy' debugfs file name by adding a suffix entry, so that the names become dummy0, dummy1, dummy2, etc.
---
Changes since v1:
- Add a suffix entry to the dummy name
drivers/base/regmap/regmap-debugfs.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/base/regmap/regmap-debugfs.c +6 -0
@@ -25,6 +25,7 @@ struct regmap_debugfs_node {struct list_head link; }; +static unsigned int dummy_index;static struct dentry *regmap_debugfs_root;static LIST_HEAD (regmap_debugfs_early_list);static DEFINE_MUTEX (regmap_debugfs_early_lock);
@@ -573,6 +574,11 @@ void regmap_debugfs_init(struct regmap *map, const char *name) name = devname; } +if (!strcmp (name,"dummy" )) { + name =kasprintf (GFP_KERNEL ,"dummy%d" , dummy_index); + dummy_index++; + } + map->debugfs =debugfs_create_dir (name, regmap_debugfs_root);if (!map->debugfs) {dev_warn (map->dev,"Failed to create debugfs directory\n" );
Signature · 1 line
2.7.4
Mark Brown
maintainerApplied "regmap: debugfs: Disambiguate dummy debugfs file name" to the regmap tree
The patch
regmap: debugfs: Disambiguate dummy debugfs file name
has been applied to the regmap tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
a430ab205d29e7d1537b220fcf989b8080d8267fMon Sep 17 00:00:00 2001
From: Fabio Estevam <[email protected]>
Date: Mon, 5 Mar 2018 15:52:09 -0300
Subject: [PATCH] regmap: debugfs: Disambiguate dummy debugfs file name
Since commit 9b947a13e7f6 ("regmap: use debugfs even when no device") allows the usage of regmap debugfs even when there is no device associated, which causes several warnings like this:
(NULL device *): Failed to create debugfs directory
This happens when the debugfs file name is 'dummy'.
The first dummy debugfs creation works fine, but subsequent creations fail as they have all the same name.
Disambiguate the 'dummy' debugfs file name by adding a suffix entry, so that the names become dummy0, dummy1, dummy2, etc.
--- drivers/base/regmap/regmap-debugfs.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/base/regmap/regmap-debugfs.c +6 -0
@@ -25,6 +25,7 @@ struct regmap_debugfs_node {struct list_head link; }; +static unsigned int dummy_index;static struct dentry *regmap_debugfs_root;static LIST_HEAD (regmap_debugfs_early_list);static DEFINE_MUTEX (regmap_debugfs_early_lock);
@@ -573,6 +574,11 @@ void regmap_debugfs_init(struct regmap *map, const char *name) name = devname; } +if (!strcmp (name,"dummy" )) { + name =kasprintf (GFP_KERNEL ,"dummy%d" , dummy_index); + dummy_index++; + } + map->debugfs =debugfs_create_dir (name, regmap_debugfs_root);if (!map->debugfs) {dev_warn (map->dev,"Failed to create debugfs directory\n" );
Signature · 1 line
2.16.2