dt-bindings: ifc: Fix the unit address format in the examples
Subsystems (2)
PATCH v2 1/1 dt-bindings: ifc: Fix the unit address format in the examples
From: Fabio Estevam <[email protected]>
DTC warnings will be seen if these examples are used in a real dts file due to a mismatch in the unit address notation.
Align the unit address notation to what is done in the real dts files as per commit f81d7af79575 ("arm64: dts: fsl: fix ifc simple-bus unit address format warnings")
---
Hi,
Commit f81d7af79575 ("arm64: dts: fsl: fix ifc simple-bus unit address format warnings") is present in Shawn Guo's tree.
Changes since v1:
- Add a 'ifc' prefix in the Subject
Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt +3 -3
@@ -43,7 +43,7 @@ Example: 0x1 0x0 0x0 0xffa00000 0x00010000 0x3 0x0 0x0 0xffb00000 0x00020000>; - flash@0,0 { + flash@0 { #address-cells = <1>; #size-cells = <1>; compatible = "cfi-flash";
@@ -58,7 +58,7 @@ Example: }; }; - flash@1,0 { + flash@100000000 { #address-cells = <1>; #size-cells = <1>; compatible = "fsl,ifc-nand";
@@ -73,7 +73,7 @@ Example: }; }; - cpld@3,0 { + cpld@@300000000 { #address-cells = <1>; #size-cells = <1>; compatible = "fsl,p1010rdb-cpld";
Signature · 1 line
2.7.4
Shawn Guo
AppliedQuoted 10 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
DTC warnings will be seen if these examples are used in a real dts file due to a mismatch in the unit address notation.
Align the unit address notation to what is done in the real dts files as per commit
f81d7af79575("arm64: dts: fsl: fix ifc simple-bus unit address format warnings")Signed-off-by Fabio Estevam <[email protected]>
Applied, thanks.
Rob Herring
maintainerQuoted 9 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
DTC warnings will be seen if these examples are used in a real dts file due to a mismatch in the unit address notation.
Align the unit address notation to what is done in the real dts files as per commit
f81d7af79575("arm64: dts: fsl: fix ifc simple-bus unit address format warnings")
Quoted 6 lines
Signed-off-by Fabio Estevam <[email protected]>---
Hi,Commit
f81d7af79575("arm64: dts: fsl: fix ifc simple-bus unit address format warnings") is present in Shawn Guo's tree.
This "fix" is wrong. Memory controllers with chip selects should have the chip select in the unit-address. The correct fix here is you should drop "simple-bus".
Rob
Hi Rob,
Quoted 3 lines · Rob Herring
This "fix" is wrong. Memory controllers with chip selects should have the chip select in the unit-address. The correct fix here is you should drop "simple-bus".
Thanks. I will revert the change and will drop "simple-bus" as suggested.