soc: imx: gpc: Use kemdup() function
Fabio Estevam
reviewerPATCH 1/1 soc: imx: gpc: Use kemdup() function
From: Fabio Estevam <[email protected]>
Use kmemdup() rather than duplicating its implementation.
Detected with Coccinelle script.
Signed-off-by Fabio Estevam <[email protected]>
--- drivers/soc/imx/gpc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/soc/imx/gpc.c +2 -2
@@ -444,12 +444,12 @@ static int imx_gpc_probe(struct platform_device *pdev)if (domain_index >= of_id_data->num_domains)continue ; - domain =kmalloc (sizeof (*domain),GFP_KERNEL ); + domain =kmemdup (&imx_gpc_domains[domain_index], +sizeof (*domain),GFP_KERNEL );if (!domain) {of_node_put (np);return -ENOMEM ; } -memcpy (domain, &imx_gpc_domains[domain_index],sizeof (*domain)); domain->regmap = regmap; domain->ipg_rate_mhz = ipg_rate_mhz;
Signature · 1 line
2.7.4
PATCH 1/1 soc: imx: gpc: Use kemdup() function
Hi Fabio,
Quoted 7 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Use
kmemdup()rather than duplicating its implementation.Detected with Coccinelle script.
Signed-off-by Fabio Estevam <[email protected]>
I copied you on my reply to Andrey Smirnov, in which I requested to use platform_device_add_data() for his patches. That said, your patches will be dropped as well.
Shawn
Quoted 26 lines
--- drivers/soc/imx/gpc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/soc/imx/gpc.c +2
-2@@ -444,12 +444,12 @@ static int imx_gpc_probe(struct platform_device *pdev)if (domain_index >= of_id_data->num_domains)continue ; - domain =kmalloc (sizeof (*domain),GFP_KERNEL ); + domain =kmemdup (&imx_gpc_domains[domain_index], +sizeof (*domain),GFP_KERNEL );if (!domain) {of_node_put (np);return -ENOMEM ; } -memcpy (domain, &imx_gpc_domains[domain_index],sizeof (*domain)); domain->regmap = regmap; domain->ipg_rate_mhz = ipg_rate_mhz;Signature · 1 line
2.7.4