Skip to contentSkip to conversation

patch "mei: remove dev_err message on an unsupported ioctl" added to char-misc-next

PATCH [email protected] 1 participant 1 message Mar 15, 2018

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

mei: remove dev_err message on an unsupported ioctl

to my char-misc git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
in the char-misc-next branch.

The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)

The patch will also be merged in the next major kernel release during the merge window.

If you have any questions about this process, please let me know.

Quoted 1 line

From bb0829a741792b56c908d7745bc0b2b540293bcc Mon Sep 17 00:00:00 2001

From: Colin Ian King <[email protected]>
Date: Tue, 27 Feb 2018 16:21:05 +0000
Subject: mei: remove dev_err message on an unsupported ioctl

Currently the driver spams the kernel log on unsupported ioctls which is unnecessary as the ioctl returns -ENOIOCTLCMD to indicate this anyway. I suspect this was originally for debugging purposes but it really is not required so remove it.

---
 drivers/misc/mei/main.c | 1 -
 1 file changed, 1 deletion(-)
drivers/misc/mei/main.c +0 -1
index 401b1bc4d282..7465f17e1559 100644
@@ -528,7 +528,6 @@ static long mei_ioctl(struct file *file, unsigned int cmd, unsigned long data)
 		break;
 
 	default:
-		dev_err(dev->dev, ": unsupported ioctl %d.\n", cmd);
 		rets = -ENOIOCTLCMD;
 	}
 
Signature · 1 line
2.16.2