xen/pirq: fix error path cleanup when binding MSIs
Subsystems (2)
PATCH 1/1 xen/pirq: fix error path cleanup when binding MSIs
Current cleanup in the error path of xen_bind_pirq_msi_to_irq is wrong. First of all there's an off-by-one in the cleanup loop, which can lead to unbinding wrong IRQs.
Secondly IRQs not bound won't be freed, thus leaking IRQ numbers.
Note that there's no need to differentiate between bound and unbound IRQs when freeing them, __unbind_from_irq will deal with both of them correctly.
---
Cc: Boris Ostrovsky <[email protected]>
Cc: Juergen Gross <[email protected]>
Cc: Amit Shah <[email protected]>
CC: [email protected]
Cc: [email protected]
--- drivers/xen/events/events_base.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/xen/events/events_base.c +2 -2
@@ -763,8 +763,8 @@ int xen_bind_pirq_msi_to_irq(struct pci_dev *dev, struct msi_desc *msidesc,mutex_unlock (&irq_mapping_update_lock);return irq; error_irq: -for (; i >=0 ; i--) -__unbind_from_irq (irq + i); +while (nvec--) +__unbind_from_irq (irq + nvec);mutex_unlock (&irq_mapping_update_lock);return ret; }
Signature · 1 line
2.16.1
Quoted 37 lines · Roger Pau Monne
Current cleanup in the error path of
xen_bind_pirq_msi_to_irqis wrong. First of all there's an off-by-one in the cleanup loop, which can lead to unbinding wrong IRQs.Secondly IRQs not bound won't be freed, thus leaking IRQ numbers.
Note that there's no need to differentiate between bound and unbound IRQs when freeing them,
__unbind_from_irqwill deal with both of them correctly.Fixes 4892c9b4ada9f9 ("xen: add support for MSI message groups")Reported-by Hooman Mirhadi <[email protected]>Signed-off-by Roger Pau Monné <[email protected]>---
Cc: Boris Ostrovsky <[email protected]>
Cc: Juergen Gross <[email protected]>
Cc: Amit Shah <[email protected]>
CC: [email protected]
Cc: [email protected]
---
drivers/xen/events/events_base.c | 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)drivers/xen/events/events_base.c +0
-0@@ -763,8 +763,8 @@ int xen_bind_pirq_msi_to_irq(struct pci_dev *dev,struct msi_desc *msidesc, mutex_unlock(&irq_mapping_update_lock); return irq;error_irq:
drivers/xen/events/events_base.c +2
-2-for (; i >=0 ; i--) -__unbind_from_irq (irq + i); +while (nvec--) +__unbind_from_irq (irq + nvec);
Quoted 3 lines
mutex_unlock(&irq_mapping_update_lock);
return ret;
}
Amit
Amazon Development Center Germany GmbH
Berlin - Dresden - Aachen
main office: Krausenstr. 38, 10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B
Boris Ostrovsky
Reviewed-byQuoted 34 lines · Amit
Quoted 33 lines · Roger Pau Monne
Current cleanup in the error path of
xen_bind_pirq_msi_to_irqis wrong. First of all there's an off-by-one in the cleanup loop, which can lead to unbinding wrong IRQs.Secondly IRQs not bound won't be freed, thus leaking IRQ numbers.
Note that there's no need to differentiate between bound and unbound IRQs when freeing them,
__unbind_from_irqwill deal with both of them correctly.Fixes 4892c9b4ada9f9 ("xen: add support for MSI message groups")Reported-by Hooman Mirhadi <[email protected]>Signed-off-by Roger Pau Monné <[email protected]>---
Cc: Boris Ostrovsky <[email protected]>
Cc: Juergen Gross <[email protected]>
Cc: Amit Shah <[email protected]>
CC: [email protected]
Cc: [email protected]
---
drivers/xen/events/events_base.c | 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)drivers/xen/events/events_base.c +0
-0@@ -763,8 +763,8 @@ int xen_bind_pirq_msi_to_irq(struct pci_dev *dev,struct msi_desc *msidesc, mutex_unlock(&irq_mapping_update_lock); return irq;error_irq:
Quoted 8 lines
Quoted 7 lines
drivers/xen/events/events_base.c +2
-2-for (; i >=0 ; i--) -__unbind_from_irq (irq + i); +while (nvec--) +__unbind_from_irq (irq + nvec);
mutex_unlock(&irq_mapping_update_lock);
return ret;
}Reviewed-by Amit Shah <[email protected]>
Boris Ostrovsky
Reviewed-byQuoted 34 lines · Amit
Quoted 33 lines · Roger Pau Monne
Current cleanup in the error path of
xen_bind_pirq_msi_to_irqis wrong. First of all there's an off-by-one in the cleanup loop, which can lead to unbinding wrong IRQs.Secondly IRQs not bound won't be freed, thus leaking IRQ numbers.
Note that there's no need to differentiate between bound and unbound IRQs when freeing them,
__unbind_from_irqwill deal with both of them correctly.Fixes 4892c9b4ada9f9 ("xen: add support for MSI message groups")Reported-by Hooman Mirhadi <[email protected]>Signed-off-by Roger Pau Monné <[email protected]>---
Cc: Boris Ostrovsky <[email protected]>
Cc: Juergen Gross <[email protected]>
Cc: Amit Shah <[email protected]>
CC: [email protected]
Cc: [email protected]
---
drivers/xen/events/events_base.c | 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)drivers/xen/events/events_base.c +0
-0@@ -763,8 +763,8 @@ int xen_bind_pirq_msi_to_irq(struct pci_dev *dev,struct msi_desc *msidesc, mutex_unlock(&irq_mapping_update_lock); return irq;error_irq:
Quoted 8 lines
Quoted 7 lines
drivers/xen/events/events_base.c +2
-2-for (; i >=0 ; i--) -__unbind_from_irq (irq + i); +while (nvec--) +__unbind_from_irq (irq + nvec);
mutex_unlock(&irq_mapping_update_lock);
return ret;
}Reviewed-by Amit Shah <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 37 lines · Roger Pau Monne
Current cleanup in the error path of
xen_bind_pirq_msi_to_irqis wrong. First of all there's an off-by-one in the cleanup loop, which can lead to unbinding wrong IRQs.Secondly IRQs not bound won't be freed, thus leaking IRQ numbers.
Note that there's no need to differentiate between bound and unbound IRQs when freeing them,
__unbind_from_irqwill deal with both of them correctly.Fixes 4892c9b4ada9f9 ("xen: add support for MSI message groups")Reported-by Hooman Mirhadi <[email protected]>Signed-off-by Roger Pau Monné <[email protected]>---
Cc: Boris Ostrovsky <[email protected]>
Cc: Juergen Gross <[email protected]>
Cc: Amit Shah <[email protected]>
CC: [email protected]
Cc: [email protected]
---
drivers/xen/events/events_base.c | 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)drivers/xen/events/events_base.c +0
-0@@ -763,8 +763,8 @@ int xen_bind_pirq_msi_to_irq(struct pci_dev *dev,struct msi_desc *msidesc, mutex_unlock(&irq_mapping_update_lock); return irq;error_irq:
drivers/xen/events/events_base.c +2
-2-for (; i >=0 ; i--) -__unbind_from_irq (irq + i); +while (nvec--) +__unbind_from_irq (irq + nvec);
Quoted 3 lines
mutex_unlock(&irq_mapping_update_lock);
return ret;
}
Amit
Amazon Development Center Germany GmbH
Berlin - Dresden - Aachen
main office: Krausenstr. 38, 10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B
_______________________________________________
Xen-devel mailing list [email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Juergen Gross
maintainerQuoted 6 lines · Roger Pau Monne
Current cleanup in the error path of
xen_bind_pirq_msi_to_irqis wrong. First of all there's an off-by-one in the cleanup loop, which can lead to unbinding wrong IRQs.Secondly IRQs not bound won't be freed, thus leaking IRQ numbers.
Quoted 7 lines
Note that there's no need to differentiate between bound and unbound IRQs when freeing them,
__unbind_from_irqwill deal with both of them correctly.Fixes 4892c9b4ada9f9 ("xen: add support for MSI message groups")Reported-by Hooman Mirhadi <[email protected]>Signed-off-by Roger Pau Monné <[email protected]>
Committed to xen/tip for-linus-4.16a
Juergen
Juergen Gross
maintainerQuoted 6 lines · Roger Pau Monne
Current cleanup in the error path of
xen_bind_pirq_msi_to_irqis wrong. First of all there's an off-by-one in the cleanup loop, which can lead to unbinding wrong IRQs.Secondly IRQs not bound won't be freed, thus leaking IRQ numbers.
Quoted 7 lines
Note that there's no need to differentiate between bound and unbound IRQs when freeing them,
__unbind_from_irqwill deal with both of them correctly.Fixes 4892c9b4ada9f9 ("xen: add support for MSI message groups")Reported-by Hooman Mirhadi <[email protected]>Signed-off-by Roger Pau Monné <[email protected]>
Committed to xen/tip for-linus-4.16a
Juergen
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 13 lines · Roger Pau Monne
Current cleanup in the error path of
xen_bind_pirq_msi_to_irqis wrong. First of all there's an off-by-one in the cleanup loop, which can lead to unbinding wrong IRQs.Secondly IRQs not bound won't be freed, thus leaking IRQ numbers.
Note that there's no need to differentiate between bound and unbound IRQs when freeing them,
__unbind_from_irqwill deal with both of them correctly.Fixes 4892c9b4ada9f9 ("xen: add support for MSI message groups")Reported-by Hooman Mirhadi <[email protected]>Signed-off-by Roger Pau Monné <[email protected]>
Quoted 6 lines
---
Cc: Boris Ostrovsky <[email protected]>
Cc: Juergen Gross <[email protected]>
Cc: Amit Shah <[email protected]>
CC: [email protected]
Cc: [email protected]
The CC to stable got lost on commit, so this didn't actually make it to the stable queue. Can you please get it queued?
Thanks,
Amazon Development Center Germany GmbH
Berlin - Dresden - Aachen
main office: Krausenstr. 38, 10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B
Quoted 13 lines · Roger Pau Monne
Current cleanup in the error path of
xen_bind_pirq_msi_to_irqis wrong. First of all there's an off-by-one in the cleanup loop, which can lead to unbinding wrong IRQs.Secondly IRQs not bound won't be freed, thus leaking IRQ numbers.
Note that there's no need to differentiate between bound and unbound IRQs when freeing them,
__unbind_from_irqwill deal with both of them correctly.Fixes 4892c9b4ada9f9 ("xen: add support for MSI message groups")Reported-by Hooman Mirhadi <[email protected]>Signed-off-by Roger Pau Monné <[email protected]>
Quoted 6 lines
---
Cc: Boris Ostrovsky <[email protected]>
Cc: Juergen Gross <[email protected]>
Cc: Amit Shah <[email protected]>
CC: [email protected]
Cc: [email protected]
The CC to stable got lost on commit, so this didn't actually make it to the stable queue. Can you please get it queued?
Thanks,
Amazon Development Center Germany GmbH
Berlin - Dresden - Aachen
main office: Krausenstr. 38, 10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B
_______________________________________________
Xen-devel mailing list [email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel