Skip to contentSkip to conversation

android: Add missing include exports

PATCH In review Stefan Schake 3 participants 3 messages Mar 18, 2018 – Mar 22, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 android: Add missing include exports

They were set for the static library but not the shared variant.

---
 Android.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Android.mk +3 -1
index 8611c5e..1b77c53 100644
@@ -53,7 +53,9 @@ LOCAL_MODULE := libdrm
 
 LOCAL_SRC_FILES := $(LIBDRM_FILES)
 LOCAL_EXPORT_C_INCLUDE_DIRS := \
-        $(LOCAL_PATH)/include/drm
+	$(LOCAL_PATH) \
+	$(LOCAL_PATH)/include/drm \
+	$(LOCAL_PATH)/android
 
 LOCAL_SHARED_LIBRARIES := \
 	libcutils
Signature · 6 lines
2.7.4

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Acked-by on v1 1/1
#1 lore raw
Quoted 14 lines · Stefan Schake

They were set for the static library but not the shared variant.

---
 Android.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Android.mk +0 -0
index 8611c5e..1b77c53 100644
@@ -53,7 +53,9 @@ LOCAL_MODULE := libdrm
 

Android.mk LOCAL_MODULE := libdrm

Quoted 10 lines
Android.mk +3 -2
 LOCAL_SRC_FILES := $(LIBDRM_FILES)
 LOCAL_EXPORT_C_INCLUDE_DIRS := \
-        $(LOCAL_PATH)/include/drm
+       $(LOCAL_PATH) \
+       $(LOCAL_PATH)/include/drm \
+       $(LOCAL_PATH)/android
 
 LOCAL_SHARED_LIBRARIES := \
        libcutils
--

I've validated with this along with your suggested change to my drm_hwcomposer patch, and it is building just fine. So I'm reworking my patch stack to include this.

thanks
-john
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#2 lore raw
Quoted 30 lines · John Stultz
Quoted 14 lines · Stefan Schake

They were set for the static library but not the shared variant.

---
 Android.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Android.mk +0 -0
index 8611c5e..1b77c53 100644
@@ -53,7 +53,9 @@ LOCAL_MODULE := libdrm
 

Android.mk LOCAL_MODULE := libdrm

Quoted 10 lines
Android.mk +3 -2
 LOCAL_SRC_FILES := $(LIBDRM_FILES)
 LOCAL_EXPORT_C_INCLUDE_DIRS := \
-        $(LOCAL_PATH)/include/drm
+       $(LOCAL_PATH) \
+       $(LOCAL_PATH)/include/drm \
+       $(LOCAL_PATH)/android
 
 LOCAL_SHARED_LIBRARIES := \
        libcutils
--

I've validated with this along with your suggested change to my drm_hwcomposer patch, and it is building just fine. So I'm reworking my patch stack to include this.

Quoted 2 lines

Looks spot on - pushed to master. Thanks gents!

-Emil
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel