Skip to contentSkip to conversation

Patch "serial: 8250_dw: Disable clock on error" has been added to the 4.14-stable tree

PATCH [email protected] 1 participant 1 message Mar 22, 2018

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

serial: 8250_dw: Disable clock on error

to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:

     serial-8250_dw-disable-clock-on-error.patch

and it can be found in the queue-4.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Thu Mar 22 14:26:48 CET 2018

From: Stefan Potyra <[email protected]>
Date: Wed, 6 Dec 2017 16:46:12 +0100
Subject: serial: 8250_dw: Disable clock on error

From: Stefan Potyra <[email protected]>

[ Upstream commit 8af016aa5a27c6a2505460eb4d83f1e70c38dc43 ]

If there is no clock rate for uartclk defined, disable the previously enabled clock again.

Found by Linux Driver Verification project (linuxtesting.org).

Fixes 23f5b3fdd04e serial: 8250_dw: only get the clock rate in one place
---
 drivers/tty/serial/8250/8250_dw.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/tty/serial/8250/8250_dw.c +2 -1
@@ -513,7 +513,8 @@ static int dw8250_probe(struct platform_
 	/* If no clock rate is defined, fail. */
 	if (!p->uartclk) {
 		dev_err(dev, "clock rate not defined\n");
-		return -EINVAL;
+		err = -EINVAL;
+		goto err_clk;
 	}
 
 	data->pclk = devm_clk_get(dev, "apb_pclk");

Patches currently in stable-queue which might be from [email protected] are

queue-4.14/serial-8250_dw-disable-clock-on-error.patch