Patch "mt7601u: check return value of alloc_skb" has been added to the 4.9-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
mt7601u: check return value of alloc_skb
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
mt7601u-check-return-value-of-alloc_skb.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Thu Mar 22 14:40:23 CET 2018
From: Pan Bian <[email protected]>
Date: Sun, 23 Apr 2017 15:00:23 +0800
Subject: mt7601u: check return value of alloc_skb
From: Pan Bian <[email protected]>
[ Upstream commit 5fb01e91daf84ad1e50edfcf63116ecbe31e7ba7 ]
Function alloc_skb() will return a NULL pointer if there is no enough memory. However, in function mt7601u_mcu_msg_alloc(), its return value is not validated before it is used. This patch fixes it.
--- drivers/net/wireless/mediatek/mt7601u/mcu.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
drivers/net/wireless/mediatek/mt7601u/mcu.c +8 -2
@@ -66,8 +66,10 @@ mt7601u_mcu_msg_alloc(struct mt7601u_devWARN_ON (len %4 );/* if length is not divisible by 4 we need to pad */ skb =alloc_skb (len +MT_DMA_HDR_LEN +4 ,GFP_KERNEL ); -skb_reserve (skb,MT_DMA_HDR_LEN ); -memcpy (skb_put (skb, len), data, len); +if (skb) { +skb_reserve (skb,MT_DMA_HDR_LEN ); +memcpy (skb_put (skb, len), data, len); + }return skb; }
@@ -170,6 +172,8 @@ static int mt7601u_mcu_function_select(s }; skb =mt7601u_mcu_msg_alloc (dev, &msg,sizeof (msg)); +if (!skb) +return -ENOMEM ;return mt7601u_mcu_msg_send (dev, skb,CMD_FUN_SET_OP , func ==5 ); }
@@ -205,6 +209,8 @@ mt7601u_mcu_calibrate(struct mt7601u_dev }; skb =mt7601u_mcu_msg_alloc (dev, &msg,sizeof (msg)); +if (!skb) +return -ENOMEM ;return mt7601u_mcu_msg_send (dev, skb,CMD_CALIBRATION_OP , true); }
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/tipc-check-return-value-of-nlmsg_new.patch queue-4.9/mt7601u-check-return-value-of-alloc_skb.patch queue-4.9/rndis_wlan-add-return-value-validation.patch queue-4.9/libertas-check-return-value-of-alloc_workqueue.patch queue-4.9/staging-wilc1000-fix-unchecked-return-value.patch queue-4.9/qlcnic-fix-unchecked-return-value.patch queue-4.9/wan-pc300too-abort-path-on-failure.patch queue-4.9/power-supply-isp1704-fix-unchecked-return-value-of-devm_kzalloc.patch