Skip to contentSkip to conversation

arm: dts: modify Nuvoton NPCM750 device tree

PATCH In review Tomer Maimon 2 participants 4 messages Mar 26, 2018 – Apr 4, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover arm: dts: modify Nuvoton NPCM750 device tree

The NPCM7xx are a family of BMC's that include several chips as:
NPCM750, NPCM730 etc.

All of the NPCM7xx BMC's have the common modules like Cortex-A9, WDT, timers, etc, and there are a optional modules that can be added.

NPCM750 device tree already pushed to arm-soc.git:
https://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git/commit/?h=for-next&id=d6bdd009c21db3f677dd1d1bbb8c20bc819074bc

After discussion with Rob Herring we have modified the structure of the NPCM7xx device tree as follow:

nuvoton-common-npcm7xx device tree include all common modules nuvoton-npcm750 device tree include specific npcm750 modules, the nuvoton-npcm750 device tree include nuvoton-common-npcm7xx device tree

In addition, the NPCM7xx device tree include the following changes:
- watchdog module added
- clock module modification
- serial module modification
- Modify Makefile NPCM7XX configuration name

Sorry if it cause more work after pushing NPCM750 device tree.

Thanks a lot,

Tomer

Tomer Maimon (1):
arm: dts: modify Nuvoton NPCM750 device tree

 arch/arm/boot/dts/Makefile                    |   2 +-
 arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi | 187 ++++++++++++++++++++++++++
 arch/arm/boot/dts/nuvoton-npcm750-evb.dts     |   6 +-
 arch/arm/boot/dts/nuvoton-npcm750.dtsi        | 131 +-----------------
 4 files changed, 198 insertions(+), 128 deletions(-)
 create mode 100644 arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 arm: dts: modify Nuvoton NPCM750 device tree

Add a common device tree for all Nuvoton NPCM7xx BMCs and include it in NPCM750 (Poleg) device tree.

---
 arch/arm/boot/dts/Makefile                    |   2 +-
 arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi | 187 ++++++++++++++++++++++++++
 arch/arm/boot/dts/nuvoton-npcm750-evb.dts     |   6 +-
 arch/arm/boot/dts/nuvoton-npcm750.dtsi        | 131 +-----------------
 4 files changed, 198 insertions(+), 128 deletions(-)
 create mode 100644 arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi
arch/arm/boot/dts/Makefile +1 -1
index c945d4670ea3..aaf9e30bce78 100644
@@ -307,7 +307,7 @@ dtb-$(CONFIG_ARCH_LPC18XX) += \
 dtb-$(CONFIG_ARCH_LPC32XX) += \
 	lpc3250-ea3250.dtb \
 	lpc3250-phy3250.dtb
-dtb-$(CONFIG_ARCH_NPCM750) += \
+dtb-$(CONFIG_ARCH_NPCM7XX) += \
 	nuvoton-npcm750-evb.dtb
 dtb-$(CONFIG_MACH_MESON6) += \
 	meson6-atv1200.dtb
arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi new file +187 -0

187 lines not on this page · raw message

arch/arm/boot/dts/nuvoton-npcm750-evb.dts +5 -1
index cabde3d5be8a..15f744f1beea 100644
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0
-// Copyright (c) 2018 Nuvoton Technology corporation.
+// Copyright (c) 2018 Nuvoton Technology [email protected]
 // Copyright 2018 Google, Inc.
 
 /dts-v1/;
@@ -18,6 +18,10 @@
 	};
 };
 
+&watchdog1 {
+	status = "okay";
+};
+
 &serial0 {
 	status = "okay";
 };
arch/arm/boot/dts/nuvoton-npcm750.dtsi +5 -126

160 lines not on this page · raw message

Signature · 1 line
2.14.1
maintainer
#2 lore raw
In reply to Tomer Maimon
Quoted 16 lines · Tomer Maimon

The NPCM7xx are a family of BMC's that include several chips as:
NPCM750, NPCM730 etc.

All of the NPCM7xx BMC's have the common modules like Cortex-A9, WDT, timers, etc, and there are a optional modules that can be added.

NPCM750 device tree already pushed to arm-soc.git:
https://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git/commit/?h=for-next&id=d6bdd009c21db3f677dd1d1bbb8c20bc819074bc

After discussion with Rob Herring we have modified the structure of the NPCM7xx device tree as follow:

nuvoton-common-npcm7xx device tree include all common modules nuvoton-npcm750 device tree include specific npcm750 modules, the nuvoton-npcm750 device tree include nuvoton-common-npcm7xx device tree

Quoted 7 lines

In addition, the NPCM7xx device tree include the following changes:
- watchdog module added
- clock module modification
- serial module modification
- Modify Makefile NPCM7XX configuration name

Sorry if it cause more work after pushing NPCM750 device tree.

I only see one patch here, which fails to describe the changes and combines all of the above changes into one commit.

Please follow the usual style for sending patches and do one thing at a time. In particular, never move large parts of a file code around in a patch that also contains other changes, those need to be split up. Each patch should also have a description that explains what it's for.

Arnd

#3 lore raw
Quoted 31 lines · Arnd Bergmann
Quoted 8 lines · Tomer Maimon

The NPCM7xx are a family of BMC's that include several chips as:
NPCM750, NPCM730 etc.

All of the NPCM7xx BMC's have the common modules like Cortex-A9, WDT, timers, etc, and there are a optional modules that can be added.

NPCM750 device tree already pushed to arm-soc.git:
https://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-

soc.git/commit/?h=for-next&id=d6bdd009c21db3f677dd1d1bbb8c20bc819074bc

Quoted 7 lines

After discussion with Rob Herring we have modified the structure of the NPCM7xx device tree as follow:

nuvoton-common-npcm7xx device tree include all common modules nuvoton-npcm750 device tree include specific npcm750 modules, the nuvoton-npcm750 device tree include nuvoton-common-npcm7xx device

tree

Quoted 8 lines

In addition, the NPCM7xx device tree include the following changes:
- watchdog module added
- clock module modification
- serial module modification
- Modify Makefile NPCM7XX configuration name

Sorry if it cause more work after pushing NPCM750 device tree.

I only see one patch here, which fails to describe the changes and combines all of the above changes into one commit.

Quoted 8 lines

Please follow the usual style for sending patches and do one thing at a time. In particular, never move large parts of a file code around in a patch that also contains other changes, those need to be split up. Each patch should also have a description that explains what it's for.

Arnd

sent again (split patches)

Thanks!