Skip to contentSkip to conversation

waf.bbclass: Throw error if waf doesn't exist

PATCH In review Changhyeok Bae 2 participants 4 messages Mar 27, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 waf.bbclass: Throw error if waf doesn't exist

From: Amanda Brindle <[email protected]>

Before, waf.bbclass would fail to catch FileNotFoundError. Now, it will catch this error and say that waf doesn't exist.

Fixes [YOCTO 12553]

---
 meta/classes/waf.bbclass | 2 ++
 1 file changed, 2 insertions(+)
meta/classes/waf.bbclass +2 -0
index f9a851d..19e9376 100644
@@ -15,6 +15,8 @@ python waf_preconfigure() {
             d.setVar("WAF_EXTRA_CONF", "--bindir=${bindir} --libdir=${libdir}")
     except subprocess.CalledProcessError as e:
         bb.warn("Unable to execute waf --version, exit code %d. Assuming waf version without bindir/libdir support." % e.returncode)
+    except FileNotFoundError:
+        bb.fatal("waf does not exist in %s" % subsrcdir)
 }
 
 do_configure[prefuncs] += "waf_preconfigure"
Signature · 1 line
2.7.4
#1 lore raw

PATCH 2/2 distcc: Change SRC_URI

From: Armin Kuster <[email protected]>

ERROR: distcc-3.2-r0 do_fetch: Fetcher failure: Unable to find revision d8b18df3e9dcbe4f092bed565835d3975e99432c in branch 3.2 even from upstream
ERROR: distcc-3.2-r0 do_fetch: Fetcher failure for URL: 'git://github.com/distcc/distcc.git;branch=3.2'. Unable to fetch URL from any source.
ERROR: distcc-3.2-r0 do_fetch: Function failed: base_do_fetch

[v2]
upstream deleted the branch and the hash no longer exists.

Took the git snapshot from yocto and created a copy on my github. There was no offical 3.2 release, only rc versions.

---
 meta/recipes-devtools/distcc/distcc_3.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/distcc/distcc_3.2.bb +1 -1
index ea3d7c1..ff0e22f 100644
@@ -14,7 +14,7 @@ PACKAGECONFIG[popt] = "--without-included-popt,--with-included-popt,popt"
 
 RRECOMMENDS_${PN} = "avahi-daemon"
 
-SRC_URI = "git://github.com/distcc/distcc.git;branch=${PV} \
+SRC_URI = "git://github.com/akuster/distcc.git;branch=${PV} \
            file://separatebuilddir.patch \
            file://0001-zeroconf-Include-fcntl.h.patch \
            file://default \
Signature · 1 line
2.7.4
#2 lore raw

Re: [PATCH 2/2] distcc: Change SRC_URI

Sorry. Please ignore those 2 patches.

Thanks
Changhyeok

2018-03-27 9:40 GMT+09:00 Changhyeok Bae <[email protected]>:

Quoted 40 lines

From: Armin Kuster <[email protected]>

ERROR: distcc-3.2-r0 do_fetch: Fetcher failure: Unable to find revision d8b18df3e9dcbe4f092bed565835d3975e99432c in branch 3.2 even from upstream
ERROR: distcc-3.2-r0 do_fetch: Fetcher failure for URL: 'git:// github.com/distcc/distcc.git;branch=3.2'. Unable to fetch URL from any source.
ERROR: distcc-3.2-r0 do_fetch: Function failed: base_do_fetch

[v2]
upstream deleted the branch and the hash no longer exists.

Took the git snapshot from yocto and created a copy on my github. There was no offical 3.2 release, only rc versions.

---
 meta/recipes-devtools/distcc/distcc_3.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/distcc/distcc_3.2.bb +0 -0
index ea3d7c1..ff0e22f 100644
@@ -14,7 +14,7 @@ PACKAGECONFIG[popt] = "--without-included-popt,--

with-included-popt,popt"

RRECOMMENDS_${PN} = "avahi-daemon"

meta/recipes-devtools/distcc/distcc_3.2.bb +1 -2
-SRC_URI = "git://github.com/distcc/distcc.git;branch=${PV} \
+SRC_URI = "git://github.com/akuster/distcc.git;branch=${PV} \
            file://separatebuilddir.patch \
            file://0001-zeroconf-Include-fcntl.h.patch \
            file://default \
--

2.7.4

Signature · 2 lines
Thanks
Changhyeok
#3 lore raw

✗ patchtest: failure for "waf.bbclass: Throw error if wa..." and 1 more

In reply to Changhyeok Bae

== Series Details ==

Series: "waf.bbclass: Throw error if wa..." and 1 more
Revision: 1
URL : https://patchwork.openembedded.org/series/11579/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at aee44c6b1c)

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe