Skip to contentSkip to conversation

Patch "staging: lustre: ptlrpc: kfree used instead of kvfree" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Mar 27, 2018

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

staging: lustre: ptlrpc: kfree used instead of kvfree

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
staging-lustre-ptlrpc-kfree-used-instead-of-kvfree.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From c3eec59659cf25916647d2178c541302bb4822ad Mon Sep 17 00:00:00 2001

From: Nadav Amit <[email protected]>
Date: Tue, 5 Sep 2017 20:25:25 +0000
Subject: staging: lustre: ptlrpc: kfree used instead of kvfree

From: Nadav Amit <[email protected]>

commit c3eec59659cf25916647d2178c541302bb4822ad upstream.

rq_reqbuf is allocated using kvmalloc() but released in one occasion using kfree() instead of kvfree().

The issue was found using grep based on a similar bug.

Fixes d7e09d0397e8 ("add Lustre file system client support")
Fixes ee0ec1946ec2 ("lustre: ptlrpc: Replace uses of OBD_{ALLOC,FREE}_LARGE")
Cc Peng Tao <[email protected]>
Cc Oleg Drokin <[email protected]>
Cc James Simmons <[email protected]>
---
 drivers/staging/lustre/lustre/ptlrpc/sec.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lustre/ptlrpc/sec.c +1 -1
@@ -824,7 +824,7 @@ void sptlrpc_request_out_callback(struct
 	if (req->rq_pool || !req->rq_reqbuf)
 		return;
 
-	kfree(req->rq_reqbuf);
+	kvfree(req->rq_reqbuf);
 	req->rq_reqbuf = NULL;
 	req->rq_reqbuf_len = 0;
 }

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/staging-lustre-ptlrpc-kfree-used-instead-of-kvfree.patch