Skip to contentSkip to conversation

Add pvcalls info to xl man page and add missing LIBXL_HAVE_PVCALLS

PATCH In review Stefano Stabellini 3 participants 4 messages Mar 30, 2018 – Apr 3, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add pvcalls info to xl man page and add missing LIBXL_HAVE_PVCALLS

Add a short entry to the xl.cfg man page about pvcalls. Also add LIBXL_HAVE_PVCALLS to mark the presence of pvcalls support in libxl.

---
 docs/man/xl.cfg.pod.5.in | 7 +++++++
 tools/libxl/libxl.h      | 7 +++++++
 2 files changed, 14 insertions(+)
docs/man/xl.cfg.pod.5.in +7 -0
index 2c1a6e1..47d8824 100644
@@ -685,6 +685,13 @@ Specify the backend domain name or id, defaults to dom0.
 
 =back
 
+=item B<pvcalls=[ "backend=domain-id", ... ]>
+
+Creates a Xen pvcalls connection to handle pvcalls requests from
+frontend to backend. It can be used as an alternative networking model.
+For more information about the protocol, see
+https://xenbits.xen.org/docs/unstable/misc/pvcalls.html.
+
 =item B<vfb=[ "VFB_SPEC_STRING", "VFB_SPEC_STRING", ...]>
 
 Specifies the paravirtual framebuffer devices which should be supplied
tools/libxl/libxl.h +7 -0
index bffc5a1..eea57ca 100644
@@ -1127,6 +1127,13 @@ void libxl_mac_copy(libxl_ctx *ctx, libxl_mac *dst, const libxl_mac *src);
  */
 #define LIBXL_HAVE_PV_SHIM 1
 
+/*
+ * LIBXL_HAVE_PVCALLS
+ *
+ * If this is defined, libxl supports creating pvcalls interfaces.
+ */
+#define LIBXL_HAVE_PVCALLS 1
+
 typedef char **libxl_string_list;
 void libxl_string_list_dispose(libxl_string_list *sl);
 int libxl_string_list_length(const libxl_string_list *sl);
Signature · 7 lines
1.9.1


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#2 lore raw
In reply to Stefano Stabellini
Quoted 15 lines · Stefano Stabellini

Add a short entry to the xl.cfg man page about pvcalls. Also add LIBXL_HAVE_PVCALLS to mark the presence of pvcalls support in libxl.

---
 docs/man/xl.cfg.pod.5.in | 7 +++++++
 tools/libxl/libxl.h      | 7 +++++++
 2 files changed, 14 insertions(+)
docs/man/xl.cfg.pod.5.in +0 -0
index 2c1a6e1..47d8824 100644

docs/man/xl.cfg.pod.5.in Specify the backend domain name or id, defaults to dom0. · line 688

Quoted 4 lines
docs/man/xl.cfg.pod.5.in +1 -0
@@ -685,6 +685,13 @@ Specify the backend domain name or id, defaults to dom0.
 
 =back
 
+=item B<pvcalls=[ "backend=domain-id", ... ]>

The 'backend' parameter in the disk config [0] contains the domain name, not the domain id. I think it would be good to keep the same semantics for both.

Thanks, Roger.

[0] https://xenbits.xen.org/docs/unstable/man/xl-disk-configuration.5.html

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#3 lore raw
Quoted 25 lines · Roger Pau Monné
Quoted 15 lines · Stefano Stabellini

Add a short entry to the xl.cfg man page about pvcalls. Also add LIBXL_HAVE_PVCALLS to mark the presence of pvcalls support in libxl.

---
 docs/man/xl.cfg.pod.5.in | 7 +++++++
 tools/libxl/libxl.h      | 7 +++++++
 2 files changed, 14 insertions(+)
docs/man/xl.cfg.pod.5.in +0 -0
index 2c1a6e1..47d8824 100644

docs/man/xl.cfg.pod.5.in Specify the backend domain name or id, defaults to dom0. · line 688

Quoted 4 lines
docs/man/xl.cfg.pod.5.in +1 -0
@@ -685,6 +685,13 @@ Specify the backend domain name or id, defaults to dom0.
 
 =back
 
+=item B<pvcalls=[ "backend=domain-id", ... ]>

The 'backend' parameter in the disk config [0] contains the domain name, not the domain id. I think it would be good to keep the same semantics for both.

Quoted 3 lines

Thanks, Roger.

[0] https://xenbits.xen.org/docs/unstable/man/xl-disk-configuration.5.html

I think that's only a matter of ambiguous wording. It should support both a name and a domid -- libxl__resolve_domid handles both.

Wei.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel